Remove counter for forwarding

Author: andreasohlund

src/ServiceControl.Audit/Auditing/AuditIngestor.cs

@@ -25,13 +25,12 @@ public AuditIngestor(
             IEnumerable<IEnrichImportedAuditMessages> auditEnrichers, // allows extending message enrichers with custom enrichers registered in the DI container
             IMessageSession messageSession,
             Lazy<IMessageDispatcher> messageDispatcher,
-            ITransportCustomization transportCustomization,
-            AuditIngestionMetrics metrics
+            ITransportCustomization transportCustomization
         )
         {
             this.settings = settings;
             this.messageDispatcher = messageDispatcher;
-            this.metrics = metrics;
+
             var enrichers = new IEnrichImportedAuditMessages[] { new MessageTypeEnricher(), new EnrichWithTrackingIds(), new ProcessingStatisticsEnricher(), new DetectNewEndpointsFromAuditImportsEnricher(endpointInstanceMonitoring), new DetectSuccessfulRetriesEnricher(), new SagaRelationshipsEnricher() }.Concat(auditEnrichers).ToArray();
 
             logQueueAddress = transportCustomization.ToTransportQualifiedQueueName(settings.AuditLogQueue);
@@ -53,7 +52,6 @@ public async Task Ingest(List<MessageContext> contexts)
                 if (settings.ForwardAuditMessages)
                 {
                     await Forward(stored, logQueueAddress);
-                    metrics.IncrementMessagesForwarded(stored.Count);
                 }
 
                 foreach (var context in contexts)
@@ -132,7 +130,6 @@ public async Task VerifyCanReachForwardingAddress()
         readonly AuditPersister auditPersister;
         readonly Settings settings;
         readonly Lazy<IMessageDispatcher> messageDispatcher;
-        readonly AuditIngestionMetrics metrics;
         readonly string logQueueAddress;
 
         static readonly ILog Log = LogManager.GetLogger<AuditIngestor>();

src/ServiceControl.Audit/Auditing/Metrics/AuditIngestionMetrics.cs

@@ -9,14 +9,11 @@ public AuditIngestionMetrics(IMeterFactory meterFactory)
     {
         var meter = meterFactory.Create(MeterName, MeterVersion);
 
-        forwardedMessagesCounter = meter.CreateCounter<long>(CreateInstrumentName("forwarded"), description: "Audit ingestion forwarded message count");
         batchDuration = meter.CreateHistogram<double>(CreateInstrumentName("batch_duration"), unit: "ms", "Average audit message batch processing duration");
         consecutiveBatchFailureGauge = meter.CreateObservableGauge(CreateInstrumentName("consecutive_batch_failures"), () => consecutiveBatchFailures, unit: "count", description: "Consecutive audit ingestion batch failure");
         ingestionDuration = meter.CreateHistogram<double>(CreateInstrumentName("duration"), unit: "ms", description: "Average incoming audit message processing duration");
     }
 
-    public void IncrementMessagesForwarded(int count) => forwardedMessagesCounter.Add(count);
-
     public MessageIngestionMetrics BeginIngestion(MessageContext messageContext) => new(messageContext, ingestionDuration);
 
     public BatchMetrics BeginBatch(int maxBatchSize) => new(maxBatchSize, batchDuration, RecordBatchOutcome);
@@ -37,7 +34,6 @@ void RecordBatchOutcome(bool success)
 
     long consecutiveBatchFailures;
 
-    readonly Counter<long> forwardedMessagesCounter;
     readonly Histogram<double> batchDuration;
 #pragma warning disable IDE0052
     readonly ObservableGauge<long> consecutiveBatchFailureGauge;