Add test to check that indexes are reset on setup

Author: andreasohlund

src/ServiceControl.Audit.Persistence.RavenDB/DatabaseSetup.cs

@@ -23,7 +23,7 @@ public async Task Execute(IDocumentStore documentStore, CancellationToken cancel
 
         await UpdateDatabaseSettings(documentStore, configuration.Name, cancellationToken);
 
-        await CreateIndexes(documentStore, cancellationToken);
+        await CreateIndexes(documentStore, configuration.EnableFullTextSearch, cancellationToken);
 
         await ConfigureExpiration(documentStore, cancellationToken);
     }
@@ -79,13 +79,13 @@ public static async Task DeleteLegacySagaDetailsIndex(IDocumentStore documentSto
         }
     }
 
-    async Task CreateIndexes(IDocumentStore documentStore, CancellationToken cancellationToken)
+    internal static async Task CreateIndexes(IDocumentStore documentStore, bool enableFreeTextSearch, CancellationToken cancellationToken)
     {
         await DeleteLegacySagaDetailsIndex(documentStore, cancellationToken);
 
         List<AbstractIndexCreationTask> indexList = [new FailedAuditImportIndex(), new SagaDetailsIndex()];
 
-        if (configuration.EnableFullTextSearch)
+        if (enableFreeTextSearch)
         {
             indexList.Add(new MessagesViewIndexWithFullTextSearch());
             await documentStore.Maintenance.SendAsync(new DeleteIndexOperation(MessagesViewIndexName), cancellationToken);

src/ServiceControl.Audit.Persistence.Tests.RavenDB/IndexSetupTests.cs

@@ -1,17 +1,18 @@
 namespace ServiceControl.Audit.Persistence.Tests;
 
-using System;
+using System.Threading;
 using System.Threading.Tasks;
-using global::ServiceControl.Audit.Persistence.RavenDB;
 using NUnit.Framework;
+using Persistence.RavenDB;
+using Persistence.RavenDB.Indexes;
 using Raven.Client.Documents.Indexes;
 using Raven.Client.Documents.Operations.Indexes;
 
 [TestFixture]
 class IndexSetupTests : PersistenceTestFixture
 {
     [Test]
-    public async Task Corax_should_the_defaul_search_engine_type()
+    public async Task Corax_should_be_the_default_search_engine_type()
     {
         var indexes = await configuration.DocumentStore.Maintenance.SendAsync(new GetIndexesOperation(0, int.MaxValue));
 
@@ -31,4 +32,27 @@ public async Task Free_text_search_index_should_be_used_by_default()
         Assert.That(nonFreeTextIndex, Is.Null);
         Assert.That(freeTextIndex, Is.Not.Null);
     }
+
+    [Test]
+    public async Task Indexes_should_be_reset_on_setup()
+    {
+        var index = new MessagesViewIndexWithFullTextSearch { Configuration = { ["Indexing.Static.SearchEngineType"] = SearchEngineType.Lucene.ToString() } };
+
+        await IndexCreation.CreateIndexesAsync([index], configuration.DocumentStore);
+
+        //TODO: find a better way
+        await Task.Delay(1000);
+
+        var indexStatsBefore = await configuration.DocumentStore.Maintenance.SendAsync(new GetIndexStatisticsOperation(index.IndexName));
+
+        Assert.That(indexStatsBefore.SearchEngineType, Is.EqualTo(SearchEngineType.Lucene));
+
+        await DatabaseSetup.CreateIndexes(configuration.DocumentStore, true, CancellationToken.None);
+
+        //TODO: find a better way
+        await Task.Delay(1000);
+
+        var indexStatsAfter = await configuration.DocumentStore.Maintenance.SendAsync(new GetIndexStatisticsOperation(index.IndexName));
+        Assert.That(indexStatsAfter.SearchEngineType, Is.EqualTo(SearchEngineType.Corax));
+    }
 }