Skip to content

Commit c9419f9

Browse files
committed
Added a few comments
1 parent d7e35c2 commit c9419f9

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/ServiceControl.MultiInstance.AcceptanceTests/Recoverability/WhenRetryingSameMessageMultipleTimes.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ await Define<MyContext>()
3434
b.When(bus => bus.SendLocal(new MyMessage())).DoNotFailOnErrorMessages())
3535
.Done(async c =>
3636
{
37-
if (c.RetryCount >= retryTypes.Length)
37+
if (c.RetryCount >= retryTypes.Length) // Are all retries done?
3838
{
3939
return !(await GetAllFailedMessage(ServiceControlInstanceName, FailedMessageStatus.Unresolved))
40-
.HasResult;
40+
.HasResult; // Should return true if all failed messages are no longer unresolved
4141
}
4242

4343
if (retryTypes[c.RetryCount] == RetryType.Edit)
@@ -46,7 +46,7 @@ await Define<MyContext>()
4646
FailedMessageStatus.Unresolved);
4747
if (!results.HasResult)
4848
{
49-
return false;
49+
return false; // No failed messages yet
5050
}
5151

5252
var result = results.Items.Single();
@@ -57,7 +57,7 @@ await Define<MyContext>()
5757
var failedMessage = await GetFailedMessage(c.UniqueMessageId, ServiceControlInstanceName, FailedMessageStatus.Unresolved);
5858
if (!failedMessage.HasResult)
5959
{
60-
return false;
60+
return false; // No failed message yet
6161
}
6262

6363
if (retryTypes[c.RetryCount] == RetryType.Edit)

src/ServiceControl.MultiInstance.AcceptanceTests/Recoverability/WhenRetryingWithEdit.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ await Define<MyContext>()
3030
FailedMessageStatus.Unresolved);
3131
if (!failedMessage.HasResult)
3232
{
33-
return false;
33+
return false; // No failed message yet
3434
}
3535

3636
await this.Post<object>($"/api/edit/{failedMessage.Item.UniqueMessageId}",
@@ -47,7 +47,7 @@ await this.Post<object>($"/api/edit/{failedMessage.Item.UniqueMessageId}",
4747

4848
var failedResolvedMessage = await GetFailedMessage(c.UniqueMessageId, ServiceControlInstanceName, FailedMessageStatus.Resolved);
4949

50-
return failedResolvedMessage.HasResult;
50+
return failedResolvedMessage.HasResult; // If there is a result it means the message was resolved
5151
})
5252
.Run(TimeSpan.FromMinutes(2));
5353
}

0 commit comments

Comments
 (0)