Favor connection string over server URL when trying to connect to RavenDB to retrieve dirty memory details

Author: mauroservienti

src/ServiceControl.Audit.Persistence.RavenDB/MemoryInformationRetriever.cs

@@ -13,7 +13,7 @@ class MemoryInformationRetriever(DatabaseConfiguration databaseConfiguration)
     // string when running in external mode. However, the tricky part is that when tests are run they
     // behave like if it was external mode. If the connection string contain always only the server
     // URL, this code is safe, otherwise it need to be adjusted to extract the server URL.
-    readonly HttpClient client = new() { BaseAddress = new Uri(databaseConfiguration.ServerConfiguration.ServerUrl ?? databaseConfiguration.ServerConfiguration.ConnectionString) };
+    readonly HttpClient client = new() { BaseAddress = new Uri(databaseConfiguration.ServerConfiguration.ConnectionString ?? databaseConfiguration.ServerConfiguration.ServerUrl) };
 
     record ResponseDto
     {

src/ServiceControl.Persistence.RavenDB/MemoryInformationRetriever.cs

@@ -9,10 +9,11 @@ namespace ServiceControl.Persistence.RavenDB;
 class MemoryInformationRetriever(RavenPersisterSettings persisterSettings)
 {
     // What does a connection string look like? Is it only a URI or could it contain other stuff?
-    // The primary instance has only the concept of a connection string (vs the Audit instance having
-    // both a ServiceUrl and a ConnectionString). If the connection string contain always only the
-    // server URL, this code is safe, otherwise it need to be adjusted to extract the server URL.
-    readonly HttpClient client = new() { BaseAddress = new Uri(persisterSettings.ServerUrl ?? persisterSettings.ConnectionString) };
+    // The ?? operator is needed because ServerUrl is populated when running embedded and connection
+    // string when running in external mode. However, the tricky part is that when tests are run they
+    // behave like if it was external mode. If the connection string contain always only the server
+    // URL, this code is safe, otherwise it need to be adjusted to extract the server URL.
+    readonly HttpClient client = new() { BaseAddress = new Uri(persisterSettings.ConnectionString ?? persisterSettings.ServerUrl) };
 
     record ResponseDto
     {