Skip to content

Commit cdc69ee

Browse files
committed
Better name for the ingested count
1 parent 1abcae6 commit cdc69ee

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/ServiceControl.Audit/Auditing/AuditIngestion.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ async Task OnMessage(MessageContext messageContext, CancellationToken cancellati
187187
await channel.Writer.WriteAsync(messageContext, cancellationToken);
188188
await taskCompletionSource.Task;
189189

190-
ingestedMessagesCounter.Add(1);
190+
successfulMessagesCounter.Add(1);
191191
messageSize.Record(messageContext.Body.Length / 1024.0);
192192
}
193193
}
@@ -218,7 +218,7 @@ protected override async Task ExecuteAsync(CancellationToken stoppingToken)
218218
}
219219

220220
auditBatchSize.Record(contexts.Count);
221-
221+
222222
await auditIngestor.Ingest(contexts);
223223
}
224224

@@ -296,7 +296,7 @@ public override async Task StopAsync(CancellationToken cancellationToken)
296296
readonly Histogram<long> auditBatchSize = Telemetry.Meter.CreateHistogram<long>(Telemetry.CreateInstrumentName("ingestion", "batch_size"), description: "Audit ingestion average batch size");
297297
readonly Histogram<double> auditBatchDuration = Telemetry.Meter.CreateHistogram<double>(Telemetry.CreateInstrumentName("ingestion", "batch_duration"), unit: "ms", "Average audit message batch processing duration");
298298
readonly Histogram<double> messageSize = Telemetry.Meter.CreateHistogram<double>(Telemetry.CreateInstrumentName("ingestion", "message_size"), unit: "kilobytes", description: "Average audit message body size");
299-
readonly Counter<long> ingestedMessagesCounter = Telemetry.Meter.CreateCounter<long>(Telemetry.CreateInstrumentName("ingestion", "count"), description: "Successful ingested audit message count");
299+
readonly Counter<long> successfulMessagesCounter = Telemetry.Meter.CreateCounter<long>(Telemetry.CreateInstrumentName("ingestion", "successful"), description: "Successful ingested audit message count");
300300
readonly Histogram<long> consecutiveBatchFailuresCounter = Telemetry.Meter.CreateHistogram<long>(Telemetry.CreateInstrumentName("ingestion", "consecutive_batch_failures"), unit: "count", description: "Consecutive audit ingestion batch failure");
301301
readonly Histogram<double> ingestionDuration = Telemetry.Meter.CreateHistogram<double>(Telemetry.CreateInstrumentName("ingestion", "duration"), unit: "ms", description: "Average incoming audit message processing duration");
302302
readonly Watchdog watchdog;

0 commit comments

Comments
 (0)