Collection initializers

Author: DavidBoike

src/ServiceControl.LicenseManagement/LicenseDetails.cs

@@ -33,7 +33,7 @@ public static LicenseDetails TrialFromEndDate(DateOnly endDate)
                 LicenseType = "Trial",
                 ExpirationDate = endDate.ToDateTime(TimeOnly.MinValue),
                 IsExtendedTrial = false,
-                ValidApplications = new List<string> { "All" }
+                ValidApplications = ["All"]
             });
         }
 
@@ -44,7 +44,7 @@ public static LicenseDetails TrialExpired()
                 LicenseType = "Trial",
                 ExpirationDate = DateTime.UtcNow.Date.AddDays(-2), //HasLicenseDateExpired uses a grace period of 1 day
                 IsExtendedTrial = false,
-                ValidApplications = new List<string> { "All" }
+                ValidApplications = ["All"]
             });
         }
 

src/ServiceControlInstaller.Engine/Accounts/Lsa.cs

@@ -25,7 +25,7 @@ public static string[] GetPrivileges(string identity)
                 // the user has no privileges
                 if (win32ErrorCode == StatusObjectNameNotFound)
                 {
-                    return new string[0];
+                    return [];
                 }
 
                 HandleLsaResult(result);

src/ServiceControlInstaller.Engine/Configuration/ServiceControl/UpgradeInfo.cs

@@ -6,13 +6,13 @@
     public class UpgradeInfo
     {
         static readonly SemanticVersion[] LastVersionForEachMajor =
-        {
+        [
             new(1, 48, 0),
             new(2, 1, 5),
             new(3, 8, 4),
             new(4, 33, 0), // Added IngestErrorMessages setting to enable message replay during 4to5 upgrade guide scenario 
-            new(5, 11, 0),
-        };
+            new(5, 11, 0)
+        ];
 
         public SemanticVersion[] UpgradePath { get; private init; }
         public bool HasIncompatibleVersion { get; private init; }

src/ServiceControlInstaller.Engine/Instances/MonitoringNewInstance.cs

@@ -32,11 +32,11 @@ string[] FlagFiles
             get
             {
                 const string flagFileName = ".notconfigured";
-                return new[]
-                {
+                return
+                [
                     Path.Combine(InstallPath, flagFileName),
                     Path.Combine(LogPath, flagFileName)
-                };
+                ];
             }
         }
 

src/ServiceControlInstaller.Engine/Instances/PersistenceManifest.cs

@@ -15,11 +15,11 @@ public class PersistenceManifest
 
         public bool IsSupported { get; set; } = true;
 
-        public Setting[] Settings { get; set; } = Array.Empty<Setting>();
+        public Setting[] Settings { get; set; } = [];
 
-        public string[] SettingsWithPathsToCleanup { get; set; } = Array.Empty<string>();
+        public string[] SettingsWithPathsToCleanup { get; set; } = [];
 
-        public string[] Aliases { get; set; } = Array.Empty<string>();
+        public string[] Aliases { get; set; } = [];
 
         internal bool IsMatch(string persistenceType) =>
             string.Equals(TypeName, persistenceType, StringComparison.Ordinal) // Type names are case-sensitive

src/ServiceControlInstaller.Engine/Instances/ServiceControlBaseService.cs

@@ -330,7 +330,7 @@ public virtual void DisableMaintenanceMode()
 
         protected virtual IEnumerable<string> GetPersistencePathsToCleanUp()
         {
-            return Enumerable.Empty<string>();
+            return [];
         }
 
         protected virtual void ValidateConnectionString()

src/ServiceControlInstaller.Engine/Instances/ServiceControlInstallableBase.cs

@@ -59,12 +59,12 @@ string[] FlagFiles
             get
             {
                 const string flagFileName = ".notconfigured";
-                return new[]
-                {
+                return
+                [
                     Path.Combine(InstallPath, flagFileName),
                     Path.Combine(DBPath, flagFileName),
                     Path.Combine(LogPath, flagFileName)
-                };
+                ];
             }
         }
 

src/ServiceControlInstaller.Engine/Instances/ServiceControlInstance.cs

@@ -26,7 +26,7 @@ public ServiceControlInstance(IWindowsServiceController service) : base(service)
 
         public TimeSpan? AuditRetentionPeriod { get; set; }
 
-        public List<RemoteInstanceSetting> RemoteInstances { get; set; } = new List<RemoteInstanceSetting>();
+        public List<RemoteInstanceSetting> RemoteInstances { get; set; } = [];
 
         public PersistenceManifest PersistenceManifest { get; set; }
 
@@ -207,12 +207,12 @@ protected override void Prepare(string zipFilePath, string destDir)
         protected override IEnumerable<string> GetPersistencePathsToCleanUp()
         {
             string[] keys =
-            {
+            [
                 "Raven/IndexStoragePath",
                 "Raven/CompiledIndexCacheDirectory",
                 "Raven/Esent/LogsPath",
                 ServiceControlSettings.DBPath.Name
-            };
+            ];
 
             var settings = AppConfig.Config.AppSettings.Settings;
             foreach (var key in keys)

src/ServiceControlInstaller.Engine/Instances/ServiceControlNewInstance.cs

@@ -42,7 +42,7 @@ public override void WriteConfigurationFile()
 
         public override string DirectoryName => "ServiceControl";
 
-        public List<RemoteInstanceSetting> RemoteInstances { get; set; } = new List<RemoteInstanceSetting>();
+        public List<RemoteInstanceSetting> RemoteInstances { get; set; } = [];
 
         public void AddRemoteInstance(string apiUri)
         {

src/ServiceControlInstaller.Engine/Instances/TransportInfo.cs

@@ -21,7 +21,7 @@ public class TransportInfo
 
         public string AutoMigrateTo { get; set; }
 
-        public string[] Aliases { get; set; } = Array.Empty<string>();
+        public string[] Aliases { get; set; } = [];
 
         public string ZipName
         {
@@ -65,6 +65,6 @@ public override int GetHashCode()
 
     public class TransportManifest
     {
-        public TransportInfo[] Definitions { get; set; } = Array.Empty<TransportInfo>();
+        public TransportInfo[] Definitions { get; set; } = [];
     }
 }