Add a comment for posterity

Author: mauroservienti

src/ServiceControl.Audit.Persistence.RavenDB/LicenseStatusCheck.cs

@@ -16,8 +16,9 @@ public static async Task WaitForLicenseOrThrow(DatabaseConfiguration configurati
         {
             BaseAddress = new Uri(configuration.ServerConfiguration.ConnectionString ?? configuration.ServerConfiguration.ServerUrl)
         };
-        using var cts = new CancellationTokenSource(30_000);
 
+        // Not linking to the incoming cancellationToken to ensure no OperationCancelledException prevents the last InvalidOperationException to be thrown
+        using var cts = new CancellationTokenSource(30_000);
         while (!cts.IsCancellationRequested)
         {
             var httpResponse = await client.GetAsync("license/status", cancellationToken);

src/ServiceControl.Persistence.RavenDB/LicenseStatusCheck.cs

@@ -16,8 +16,9 @@ public static async Task WaitForLicenseOrThrow(RavenPersisterSettings configurat
         {
             BaseAddress = new Uri(configuration.ConnectionString ?? configuration.ServerUrl)
         };
-        using var cts = new CancellationTokenSource(30_000);
 
+        // Not linking to the incoming cancellationToken to ensure no OperationCancelledException prevents the last InvalidOperationException to be thrown
+        using var cts = new CancellationTokenSource(30_000);
         while (!cts.IsCancellationRequested)
         {
             var httpResponse = await client.GetAsync("license/status", cancellationToken);