Skip to content

Commit d8d6fc7

Browse files
authored
Merge pull request #4614 from Particular/john/aud
Adding audience to the metrics api client
2 parents b9deb0f + d03a8c8 commit d8d6fc7

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

src/ServiceControl.Transports.ASBS/AzureQuery.cs

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,11 @@ protected override void InitializeCore(ReadOnlyDictionary<string, string> settin
9999
Diagnostics.AppendLine("Client secret set");
100100
}
101101

102-
ArmEnvironment environment = GetEnvironment();
102+
(ArmEnvironment armEnvironment, MetricsQueryAudience metricsQueryAudience) environment = GetEnvironment();
103103

104104
if (managementUrl == null)
105105
{
106-
Diagnostics.AppendLine($"Management Url not set, defaulted to \"{environment.Endpoint}\"");
106+
Diagnostics.AppendLine($"Management Url not set, defaulted to \"{environment.armEnvironment.Endpoint}\"");
107107
}
108108
else
109109
{
@@ -126,9 +126,10 @@ protected override void InitializeCore(ReadOnlyDictionary<string, string> settin
126126
clientCredentials = new ClientSecretCredential(tenantId, clientId, clientSecret);
127127
}
128128

129-
client = new MetricsQueryClient(environment.Endpoint, clientCredentials,
129+
client = new MetricsQueryClient(environment.armEnvironment.Endpoint, clientCredentials,
130130
new MetricsQueryClientOptions
131131
{
132+
Audience = environment.metricsQueryAudience,
132133
Transport = new HttpClientTransport(
133134
new HttpClient(new SocketsHttpHandler
134135
{
@@ -138,7 +139,7 @@ protected override void InitializeCore(ReadOnlyDictionary<string, string> settin
138139
armClient = new ArmClient(clientCredentials, subscriptionId,
139140
new ArmClientOptions
140141
{
141-
Environment = environment,
142+
Environment = environment.armEnvironment,
142143
Transport = new HttpClientTransport(
143144
new HttpClient(new SocketsHttpHandler
144145
{
@@ -148,31 +149,31 @@ protected override void InitializeCore(ReadOnlyDictionary<string, string> settin
148149

149150
return;
150151

151-
ArmEnvironment GetEnvironment()
152+
(ArmEnvironment armEnvironment, MetricsQueryAudience metricsQueryAudience) GetEnvironment()
152153
{
153154
if (managementUrlParsed == null)
154155
{
155-
return ArmEnvironment.AzurePublicCloud;
156+
return (ArmEnvironment.AzurePublicCloud, MetricsQueryAudience.AzurePublicCloud);
156157
}
157158

158159
if (managementUrlParsed == ArmEnvironment.AzurePublicCloud.Endpoint)
159160
{
160-
return ArmEnvironment.AzurePublicCloud;
161+
return (ArmEnvironment.AzurePublicCloud, MetricsQueryAudience.AzurePublicCloud);
161162
}
162163

163164
if (managementUrlParsed == ArmEnvironment.AzureChina.Endpoint)
164165
{
165-
return ArmEnvironment.AzureChina;
166+
return (ArmEnvironment.AzureChina, MetricsQueryAudience.AzureChina);
166167
}
167168

168169
if (managementUrlParsed == ArmEnvironment.AzureGermany.Endpoint)
169170
{
170-
return ArmEnvironment.AzureGermany;
171+
return (ArmEnvironment.AzureGermany, MetricsQueryAudience.AzurePublicCloud);
171172
}
172173

173174
if (managementUrlParsed == ArmEnvironment.AzureGovernment.Endpoint)
174175
{
175-
return ArmEnvironment.AzureGovernment;
176+
return (ArmEnvironment.AzureGovernment, MetricsQueryAudience.AzureGovernment);
176177
}
177178

178179
string options = string.Join(", ",
@@ -183,7 +184,7 @@ ArmEnvironment GetEnvironment()
183184
}.Select(armEnvironment => $"\"{armEnvironment.Endpoint}\""));
184185
InitialiseErrors.Add($"Management url configuration is invalid, available options are {options}");
185186

186-
return ArmEnvironment.AzurePublicCloud;
187+
return (ArmEnvironment.AzurePublicCloud, MetricsQueryAudience.AzurePublicCloud);
187188
}
188189
}
189190

0 commit comments

Comments
 (0)