Refactor logging settings initialization across services

Author: ramonsmits

src/ServiceControl.Audit/Infrastructure/Settings/Settings.cs

@@ -22,6 +22,7 @@ public Settings(
             LoggingSettings loggingSettings = null
         )
         {
+            // TODO: Consider GetRequiredSection ?
             IConfiguration serviceBusSection = configuration.GetSection(SectionNameServiceBus);
             IConfiguration serviceControlAuditsection = configuration.GetSection(SectionName);
             IConfiguration serviceControlSection = configuration.GetSection(SectionNameServiceControl);

src/ServiceControl.Monitoring/Program.cs

@@ -18,7 +18,7 @@
 
     var section = bootstrapConfig.GetSection(Settings.SectionName);
 
-    var loggingSettings = LoggingSettingsFactory.Create(bootstrapConfig);
+    var loggingSettings = LoggingSettingsFactory.Create(section);
     LoggingConfigurator.ConfigureLogging(loggingSettings);
     logger = LoggerUtil.CreateStaticLogger<Program>();
 

src/ServiceControl.Monitoring/Settings.cs

@@ -18,9 +18,8 @@ public Settings() { }
 
         public Settings(ILogger<Settings> logger, IConfigurationSection section, LoggingSettings loggingSettings, string transportType = null)
         {
-            LoggingSettings = loggingSettings; // TODO: Previously had a COALESCE
+            LoggingSettings = loggingSettings;
 
-            // Overwrite the instance name if it is specified in ENVVAR, reg, or config file
             InstanceName = section.GetValue("InstanceName", DEFAULT_INSTANCE_NAME);
 
             TransportType = section.GetValue("TransportType", transportType);

src/ServiceControl/Infrastructure/Settings/Settings.cs

@@ -13,7 +13,7 @@ public class Settings
 {
     public ServiceControlSettings ServiceControlSettings { get; set; }
     [JsonIgnore] public Func<string, AssemblyLoadContext> AssemblyLoadContextResolver { get; set; }
-    public LoggingSettings LoggingSettings { get; set; }
+    public LoggingSettings LoggingSettings { get; set; } = new ();
     public string NotificationsFilter { get; set; }
     public bool AllowMessageEditing { get; set; }
     public Func<MessageContext, bool> MessageFilter { get; set; } //HINT: acceptance tests only

src/ServiceControl/Program.cs

@@ -24,6 +24,7 @@
     var bootstrapSettings = section.Get<Settings>();
 
     var loggingSettings = LoggingSettingsFactory.Create(section);
+    bootstrapSettings.LoggingSettings = loggingSettings;    // TODO: Remove this when we have a better way to pass logging settings to the host
 
     LoggingConfigurator.ConfigureLogging(loggingSettings);