Move creation close to only usage

ramonsmits · web-flow · commit e59f772e652b · 2025-03-10T11:46:32.000+01:00
diff --git a/src/ServiceControl.Audit/Infrastructure/Settings/Settings.cs b/src/ServiceControl.Audit/Infrastructure/Settings/Settings.cs
@@ -63,11 +63,10 @@ void LoadAuditQueueInformation()
                 throw new Exception("ServiceBus/AuditQueue value is required to start the instance");
             }
 
-            var serviceControlNamespace = new SettingsRootNamespace("ServiceControl");
-
             if (!SettingsReader.TryRead(SettingsRootNamespace, "IngestAuditMessages", out bool ingestAuditMessages))
             {
                 // Backwards compatibility
+                var serviceControlNamespace = new SettingsRootNamespace("ServiceControl");
                 ingestAuditMessages = SettingsReader.Read(serviceControlNamespace, "IngestAuditMessages", true);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -63,11 +63,10 @@ void LoadAuditQueueInformation()`
`63`	`63`	`throw new Exception("ServiceBus/AuditQueue value is required to start the instance");`
`64`	`64`	`}`
`65`	`65`
`66`		`- var serviceControlNamespace = new SettingsRootNamespace("ServiceControl");`
`67`		`-`
`68`	`66`	`if (!SettingsReader.TryRead(SettingsRootNamespace, "IngestAuditMessages", out bool ingestAuditMessages))`
`69`	`67`	`{`
`70`	`68`	`// Backwards compatibility`
	`69`	`+ var serviceControlNamespace = new SettingsRootNamespace("ServiceControl");`
`71`	`70`	`ingestAuditMessages = SettingsReader.Read(serviceControlNamespace, "IngestAuditMessages", true);`
`72`	`71`	`}`
`73`	`72`