fix logging not being available during logging setup

Author: PhilBastian

src/ServiceControl.Audit/Program.cs

@@ -7,12 +7,14 @@
 using ServiceControl.Configuration;
 using ServiceControl.Infrastructure;
 
-var loggingSettings = new LoggingSettings(Settings.SettingsRootNamespace);
-LoggingConfigurator.ConfigureLogging(loggingSettings);
-var logger = LoggerUtil.CreateStaticLogger(typeof(Program));
+ILogger logger = null;
 
 try
 {
+    var loggingSettings = new LoggingSettings(Settings.SettingsRootNamespace);
+    LoggingConfigurator.ConfigureLogging(loggingSettings);
+    logger = LoggerUtil.CreateStaticLogger(typeof(Program));
+
     AppDomain.CurrentDomain.UnhandledException += (s, e) => logger.LogError(e.ExceptionObject as Exception, "Unhandled exception was caught.");
 
     // Hack: See https://github.com/Particular/ServiceControl/issues/4392
@@ -41,12 +43,20 @@
 }
 catch (Exception ex)
 {
-    logger.LogCritical(ex, "Unrecoverable error");
+    if (logger != null)
+    {
+        logger.LogCritical(ex, "Unrecoverable error");
+    }
+    else
+    {
+        LoggingConfigurator.ConfigureNLog("bootstrap.${shortdate}.txt", "./", NLog.LogLevel.Fatal);
+        NLog.LogManager.GetCurrentClassLogger().Fatal(ex, "Unrecoverable error");
+    }
     throw;
 }
 finally
 {
     // The following log statement is meant to leave a trail in the logs to determine if the process was killed
-    logger.LogInformation("Shutdown complete");
+    logger?.LogInformation("Shutdown complete");
     NLog.LogManager.Shutdown();
 }

src/ServiceControl.Infrastructure/LoggingConfigurator.cs

@@ -24,6 +24,16 @@ public static void ConfigureLogging(LoggingSettings loggingSettings)
                 return;
             }
 
+            var logLevel = loggingSettings.LogLevel.ToNLogLevel();
+            var loggingTo = ConfigureNLog("logfile.${shortdate}.txt", loggingSettings.LogPath, loggingSettings.LogLevel.ToNLogLevel());
+
+            //using LogManager here rather than LoggerUtil.CreateStaticLogger since this is exclusive to NLog
+            var logger = LogManager.GetLogger("LoggingConfiguration");
+            logger.InfoFormat("Logging to {0} with LogLevel '{1}'", loggingTo, logLevel.Name);
+        }
+
+        public static string ConfigureNLog(string logFileName, string logPath, LogLevel logLevel)
+        {
             //configure NLog
             var nlogConfig = new LoggingConfiguration();
             var simpleLayout = new SimpleLayout("${longdate}|${processtime}|${threadid}|${level}|${logger}|${message}${onexception:|${exception:format=tostring}}");
@@ -32,8 +42,8 @@ public static void ConfigureLogging(LoggingSettings loggingSettings)
             {
                 Name = "file",
                 ArchiveEvery = FileArchivePeriod.Day,
-                FileName = Path.Combine(loggingSettings.LogPath, "logfile.${shortdate}.txt"),
-                ArchiveFileName = Path.Combine(loggingSettings.LogPath, "logfile.{#}.txt"),
+                FileName = Path.Combine(logPath, logFileName),
+                ArchiveFileName = Path.Combine(logPath, "logfile.{#}.txt"),
                 ArchiveNumbering = ArchiveNumberingMode.DateAndSequence,
                 Layout = simpleLayout,
                 MaxArchiveFiles = 14,
@@ -64,7 +74,6 @@ public static void ConfigureLogging(LoggingSettings loggingSettings)
             nlogConfig.LoggingRules.Add(aspNetCoreRule);
             nlogConfig.LoggingRules.Add(httpClientRule);
 
-            var logLevel = loggingSettings.LogLevel.ToNLogLevel();
             nlogConfig.LoggingRules.Add(new LoggingRule("*", logLevel, consoleTarget));
 
             if (!AppEnvironment.RunningInContainer)
@@ -74,11 +83,8 @@ public static void ConfigureLogging(LoggingSettings loggingSettings)
 
             NLog.LogManager.Configuration = nlogConfig;
 
-            //using LogManager here rather than LoggerUtil.CreateStaticLogger since this is exclusive to NLog
-            var logger = LogManager.GetLogger("LoggingConfiguration");
             var logEventInfo = new LogEventInfo { TimeStamp = DateTime.UtcNow };
-            var loggingTo = AppEnvironment.RunningInContainer ? "console" : fileTarget.FileName.Render(logEventInfo);
-            logger.InfoFormat("Logging to {0} with LogLevel '{1}'", loggingTo, logLevel.Name);
+            return AppEnvironment.RunningInContainer ? "console" : fileTarget.FileName.Render(logEventInfo);
         }
 
         static LogLevel ToNLogLevel(this Microsoft.Extensions.Logging.LogLevel level)

src/ServiceControl.Monitoring/Program.cs

@@ -5,12 +5,14 @@
 using ServiceControl.Infrastructure;
 using ServiceControl.Monitoring;
 
-var loggingSettings = new LoggingSettings(Settings.SettingsRootNamespace);
-LoggingConfigurator.ConfigureLogging(loggingSettings);
-var logger = LoggerUtil.CreateStaticLogger<Program>();
+ILogger logger = null;
 
 try
 {
+    var loggingSettings = new LoggingSettings(Settings.SettingsRootNamespace);
+    LoggingConfigurator.ConfigureLogging(loggingSettings);
+    logger = LoggerUtil.CreateStaticLogger(typeof(Program));
+
     AppDomain.CurrentDomain.UnhandledException += (s, e) => logger.LogError(e.ExceptionObject as Exception, "Unhandled exception was caught.");
 
     // Hack: See https://github.com/Particular/ServiceControl/issues/4392
@@ -33,7 +35,15 @@
 }
 catch (Exception ex)
 {
-    logger.LogCritical(ex, "Unrecoverable error");
+    if (logger != null)
+    {
+        logger.LogCritical(ex, "Unrecoverable error");
+    }
+    else
+    {
+        LoggingConfigurator.ConfigureNLog("bootstrap.${shortdate}.txt", "./", NLog.LogLevel.Fatal);
+        NLog.LogManager.GetCurrentClassLogger().Fatal(ex, "Unrecoverable error");
+    }
     throw;
 }
 finally

src/ServiceControl/Program.cs

@@ -7,12 +7,14 @@
 using ServiceControl.Hosting.Commands;
 using ServiceControl.Infrastructure;
 
-var loggingSettings = new LoggingSettings(Settings.SettingsRootNamespace);
-LoggingConfigurator.ConfigureLogging(loggingSettings);
-var logger = LoggerUtil.CreateStaticLogger(typeof(Program));
+ILogger logger = null;
 
 try
 {
+    var loggingSettings = new LoggingSettings(Settings.SettingsRootNamespace);
+    LoggingConfigurator.ConfigureLogging(loggingSettings);
+    logger = LoggerUtil.CreateStaticLogger(typeof(Program));
+
     AppDomain.CurrentDomain.UnhandledException += (s, e) => logger.LogError(e.ExceptionObject as Exception, "Unhandled exception was caught");
 
     // Hack: See https://github.com/Particular/ServiceControl/issues/4392
@@ -41,12 +43,20 @@
 }
 catch (Exception ex)
 {
-    logger.LogCritical(ex, "Unrecoverable error");
+    if (logger != null)
+    {
+        logger.LogCritical(ex, "Unrecoverable error");
+    }
+    else
+    {
+        LoggingConfigurator.ConfigureNLog("bootstrap.${shortdate}.txt", "./", NLog.LogLevel.Fatal);
+        NLog.LogManager.GetCurrentClassLogger().Fatal(ex, "Unrecoverable error");
+    }
     throw;
 }
 finally
 {
     // The following log statement is meant to leave a trail in the logs to determine if the process was killed
-    logger.LogInformation("Shutdown complete");
+    logger?.LogInformation("Shutdown complete");
     NLog.LogManager.Shutdown();
 }