Fix batch result

Author: andreasohlund

docs/telemetry.md

@@ -21,7 +21,7 @@ The following metrics are available:
 The following ingestion metrics with their corresponding dimensions are available:
 
 - `sc.audit.ingestion.batch_duration_seconds` - Message batch processing duration in seconds
-  - `result` - Indicates if the full batch size was used (batch size == max concurrency of the transport): `full` or `partial`
+  - `result` - Indicates if the full batch size was used (batch size == max concurrency of the transport): `full`, `partial` or `failed`
 - `sc.audit.ingestion.message_duration_seconds` - Audit message processing duration in seconds
   - `message.category` - Indicates the category of the message ingested: `audit-message`, `saga-update` or `control-message`
   - `result` - Indicates the outcome of the operation: `success`, `failed` or `skipped` (if the message was filtered out and skipped)

src/ServiceControl.Audit/Auditing/Metrics/BatchMetrics.cs

@@ -8,19 +8,22 @@ public record BatchMetrics(int MaxBatchSize, Histogram<double> BatchDuration, Ac
 {
     public void Dispose()
     {
-        var tags = new TagList();
-
         var isSuccess = actualBatchSize > 0;
 
         IsSuccess(isSuccess);
 
+        string result;
+
         if (isSuccess)
         {
-            var result = actualBatchSize == MaxBatchSize ? "full" : "partial";
-            tags.Add("result", result);
+            result = actualBatchSize == MaxBatchSize ? "full" : "partial";
+        }
+        else
+        {
+            result = "failed";
         }
 
-        BatchDuration.Record(sw.Elapsed.TotalSeconds, tags);
+        BatchDuration.Record(sw.Elapsed.TotalSeconds, new TagList { { "result", result } });
     }
 
     public void Complete(int size) => actualBatchSize = size;