Remove analyser for configure await

Author: andreasohlund

src/.editorconfig

@@ -27,10 +27,9 @@ insert_final_newline = false
 dotnet_diagnostic.CA1068.severity = error
 dotnet_diagnostic.CA1710.severity = error
 dotnet_diagnostic.CA1711.severity = error
-dotnet_diagnostic.CA2007.severity = error
+dotnet_diagnostic.CA2007.severity = none
 dotnet_diagnostic.CA2016.severity = error
 
-
 #### .NET Coding Conventions ####
 
 # this. and Me. preferences

src/HealthCheckApp/Program.cs

@@ -7,7 +7,7 @@
     throw new Exception("Missing URL");
 }
 
-var response = await http.GetAsync(url).ConfigureAwait(false);
+var response = await http.GetAsync(url);
 response.EnsureSuccessStatusCode();
 
 if (response.Content.Headers.ContentType?.MediaType != "application/json" || response.Content.Headers.ContentLength == 0)

src/ServiceControl.Config/.editorconfig

@@ -1,8 +1,5 @@
 [*.cs]
 
-# Justification: Application synchronization contexts don't require ConfigureAwait(false)
-dotnet_diagnostic.CA2007.severity = none
-
 # may be enabled in future
 dotnet_diagnostic.PS0003.severity = none  # A parameter of type CancellationToken on a non-private delegate or method should be optional
 dotnet_diagnostic.PS0013.severity = none  # A Func used as a method parameter with a Task, ValueTask, or ValueTask<T> return type argument should have at least one CancellationToken parameter type argument unless it has a parameter type argument implementing ICancellableContext

src/ServiceControl.DomainEvents/DomainEvents.cs

@@ -21,7 +21,7 @@ public async Task Raise<T>(T domainEvent, CancellationToken cancellationToken) w
                 try
                 {
                     await handler.Handle(domainEvent, cancellationToken)
-                        .ConfigureAwait(false);
+                        ;
                 }
                 catch (Exception e)
                 {
@@ -36,7 +36,7 @@ await handler.Handle(domainEvent, cancellationToken)
                 try
                 {
                     await handler.Handle(domainEvent, cancellationToken)
-                    .ConfigureAwait(false);
+                    ;
                 }
                 catch (Exception e)
                 {

src/ServiceControl.Infrastructure.Metrics/MetricsReporter.cs

@@ -29,7 +29,7 @@ public void Start()
                     while (!tokenSource.IsCancellationRequested)
                     {
                         Print();
-                        await Task.Delay(interval, tokenSource.Token).ConfigureAwait(false);
+                        await Task.Delay(interval, tokenSource.Token);
                     }
                 }
                 catch (OperationCanceledException) when (tokenSource.IsCancellationRequested)

src/ServiceControl.Infrastructure/AsyncTimer.cs

@@ -22,20 +22,20 @@ public TimerJob(Func<CancellationToken, Task<TimerJobExecutionResult>> callback,
             {
                 try
                 {
-                    await Task.Delay(due, token).ConfigureAwait(false);
+                    await Task.Delay(due, token);
 
                     while (!token.IsCancellationRequested)
                     {
                         try
                         {
-                            var result = await callback(token).ConfigureAwait(false);
+                            var result = await callback(token);
                             if (result == TimerJobExecutionResult.DoNotContinueExecuting)
                             {
                                 tokenSource.Cancel();
                             }
                             else if (result == TimerJobExecutionResult.ScheduleNextExecution)
                             {
-                                await Task.Delay(interval, token).ConfigureAwait(false);
+                                await Task.Delay(interval, token);
                             }
 
                             //Otherwise execute immediately
@@ -64,14 +64,14 @@ public async Task Stop()
                 return;
             }
 
-            await tokenSource.CancelAsync().ConfigureAwait(false);
+            await tokenSource.CancelAsync();
             tokenSource.Dispose();
 
             if (task != null)
             {
                 try
                 {
-                    await task.ConfigureAwait(false);
+                    await task;
                 }
                 catch (OperationCanceledException) when (tokenSource.IsCancellationRequested)
                 {

src/ServiceControl.Infrastructure/IntegratedSetup.cs

@@ -52,7 +52,7 @@ public static async Task<int> Run()
             process.BeginOutputReadLine();
             process.BeginErrorReadLine();
 
-            await process.WaitForExitAsync().ConfigureAwait(false);
+            await process.WaitForExitAsync();
 
             return process.ExitCode;
         }

src/ServiceControl.Infrastructure/WaitHandleExtensions.cs

@@ -22,12 +22,12 @@ public static async Task<bool> WaitOneAsync(this WaitHandle handle, int millisec
                 tokenRegistration = cancellationToken.Register(
                     state => ((TaskCompletionSource<bool>)state).TrySetCanceled(),
                     tcs);
-                return await tcs.Task.ConfigureAwait(false);
+                return await tcs.Task;
             }
             finally
             {
                 registeredHandle?.Unregister(null);
-                await tokenRegistration.DisposeAsync().ConfigureAwait(false);
+                await tokenRegistration.DisposeAsync();
             }
         }
 

src/ServiceControl.Infrastructure/Watchdog.cs

@@ -61,7 +61,7 @@ public Task Start(Action onFailedOnStartup, CancellationToken cancellationToken)
                         cancellationTokenSource.CancelAfter(MaxStartDurationMs);
 
                         log.Debug($"Ensuring {taskName} is running");
-                        await ensureStarted(cancellationTokenSource.Token).ConfigureAwait(false);
+                        await ensureStarted(cancellationTokenSource.Token);
                         clearFailure();
                         startup = false;
                     }
@@ -85,7 +85,7 @@ public Task Start(Action onFailedOnStartup, CancellationToken cancellationToken)
                     }
                     try
                     {
-                        await Task.Delay(timeToWaitBetweenStartupAttempts, shutdownTokenSource.Token).ConfigureAwait(false);
+                        await Task.Delay(timeToWaitBetweenStartupAttempts, shutdownTokenSource.Token);
                     }
                     catch (OperationCanceledException) when (shutdownTokenSource.IsCancellationRequested)
                     {
@@ -102,8 +102,8 @@ public async Task Stop(CancellationToken cancellationToken)
             try
             {
                 log.Debug($"Stopping watching process {taskName}");
-                await shutdownTokenSource.CancelAsync().ConfigureAwait(false);
-                await watchdog.ConfigureAwait(false);
+                await shutdownTokenSource.CancelAsync();
+                await watchdog;
             }
             catch (Exception e)
             {
@@ -112,7 +112,7 @@ public async Task Stop(CancellationToken cancellationToken)
             }
             finally
             {
-                await ensureStopped(cancellationToken).ConfigureAwait(false);
+                await ensureStopped(cancellationToken);
             }
         }
     }