Skip to content

Commit 02dec82

Browse files
committed
Replace window.setTimeout with just setTimeout
This is to fix the flaky test failures that cause: Error: ReferenceError: window is not defined ❯ stopTimer src/composables/autoRefresh.ts:12:7 ❯ startTimer src/composables/autoRefresh.ts:20:5 ❯ executeAndResetTimer src/composables/autoRefresh.ts:31:7 ❯ Timeout._onTimeout src/composables/autoRefresh.ts:22:7 ❯ listOnTimeout node:internal/timers:588:17 ❯ processTimers node:internal/timers:523:7
1 parent 09c46ec commit 02dec82

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

src/Frontend/src/components/CopyToClipboard.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,16 @@ const props = withDefaults(
1313
);
1414
1515
const tippyRef = useTemplateRef<TippyComponent | null>("tippyRef");
16-
const timeoutId = ref(0);
16+
const timeoutId = ref<ReturnType<typeof setTimeout>>();
1717
1818
async function copyToClipboard() {
1919
await navigator.clipboard.writeText(props.value);
2020
2121
tippyRef.value?.show();
22-
timeoutId.value = window.setTimeout(() => tippyRef.value?.hide(), 3000);
22+
timeoutId.value = setTimeout(() => tippyRef.value?.hide(), 3000);
2323
}
2424
25-
watch(timeoutId, (_, previousTimeoutId) => window.clearTimeout(previousTimeoutId));
25+
watch(timeoutId, (_, previousTimeoutId) => clearTimeout(previousTimeoutId));
2626
</script>
2727

2828
<template>

src/Frontend/src/components/RefreshConfig.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ watch(
4949
(newValue) => {
5050
if (newValue) {
5151
showSpinning.value = true;
52-
window.setTimeout(() => {
52+
setTimeout(() => {
5353
showSpinning.value = false;
5454
}, 1000);
5555
}

src/Frontend/src/composables/autoRefresh.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
* @param defaultTimeout The time between refreshes in ms or null if no auto-refresh is desired
55
*/
66
export default function useAutoRefresh(refreshAction: () => Promise<void>, defaultTimeout: number | null, startImmediately = true) {
7-
let refreshInterval: number | null = null;
7+
let refreshInterval: ReturnType<typeof setTimeout> | null = null;
88
const timeout = { value: defaultTimeout };
99

1010
function stopTimer() {
1111
if (refreshInterval !== null) {
12-
window.clearTimeout(refreshInterval);
12+
clearTimeout(refreshInterval);
1313
refreshInterval = null;
1414
}
1515
}
@@ -18,7 +18,7 @@ export default function useAutoRefresh(refreshAction: () => Promise<void>, defau
1818
if (timeout.value === null) return;
1919

2020
stopTimer();
21-
refreshInterval = window.setTimeout(() => {
21+
refreshInterval = setTimeout(() => {
2222
executeAndResetTimer();
2323
}, timeout.value as number);
2424
}

src/Frontend/src/views/throughputreport/endpoints/useHiddenFeature.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const keyHandler = (event: KeyboardEvent) => {
88

99
watchEffect((onCleanup) => {
1010
if (keys.value.length > 0) {
11-
const timeout = window.setTimeout(() => keys.value.splice(0), 5000);
11+
const timeout = setTimeout(() => keys.value.splice(0), 5000);
1212
onCleanup(() => clearTimeout(timeout));
1313
}
1414
});

0 commit comments

Comments
 (0)