Added aria label back

Author: johnsimons

src/Frontend/src/components/heartbeats/LastHeartbeat.vue

@@ -6,14 +6,14 @@ defineProps<{ date?: string; tooltipTarget: string }>();
 </script>
 
 <template>
-  <p v-if="date"><time-since :date-utc="date" default-text-on-failure="unknown" title-value="Last Heartbeat" /></p>
+  <p v-if="date"><time-since aria-label="Last Heartbeat" :date-utc="date" default-text-on-failure="unknown" title-value="Last Heartbeat" /></p>
   <p v-else>
     <tippy :delay="[1000, 300]" :interactive="true">
       <template #content>
         <p>No heartbeat data received for this {{ tooltipTarget }}.</p>
         <p>Have you installed and configured the <a target="_blank" href="https://docs.particular.net/monitoring/heartbeats/install-plugin">heartbeats plugin</a> for this {{ tooltipTarget }}?</p>
       </template>
-      <span>No data available</span>
+      <span aria-label="Last Heartbeat">No data available</span>
     </tippy>
   </p>
 </template>

src/Frontend/test/specs/heartbeats/questions/getEndpointInstance.ts

@@ -4,7 +4,7 @@ import { screen, within } from "@testing-library/vue";
 export async function getEndpointInstance(instanceName: string) {
   const endpointRow = await screen.findByRole("row", { name: instanceName });
   const hostName = within(endpointRow).getByLabelText("instance-name").textContent;
-  const lastHeartbeat = within(endpointRow).getByTitle("Last Heartbeat").textContent;
+  const lastHeartbeat = within(endpointRow).getByLabelText("Last Heartbeat").textContent;
   const muted = (<HTMLInputElement>within(endpointRow).getByRole("checkbox", { hidden: true })).checked;
 
   return {

src/Frontend/test/specs/heartbeats/questions/getEndpointsForConfiguration.ts

@@ -16,7 +16,7 @@ export async function getEndpointsForConfiguration() {
     endpointRows.map((row) => {
       const endpointName = String(within(row).getByRole("link", { name: "details-link" }).textContent);
       const instances = String(within(row).getByLabelText("instance-count").textContent);
-      const lastHeartbeat = String(within(row).getByTitle("Last Heartbeat").textContent);
+      const lastHeartbeat = String(within(row).getByLabelText("Last Heartbeat").textContent);
       const trackingCheckbox = <HTMLInputElement>within(row).getByRole("checkbox", { hidden: true });
       const trackingEnabled = trackingCheckbox.ariaLabel === `onoffswitch${endpointName}` && trackingCheckbox.checked;
 

src/Frontend/test/specs/heartbeats/questions/getHeartbeatEndpointRecord.ts

@@ -29,7 +29,7 @@ function createRecordFromRowElement(endpointRow: HTMLElement) {
   return <EndpointRecord>{
     name: within(endpointRow).getByRole("link", { name: "details-link" }).textContent,
     instanceCount: within(endpointRow).getByLabelText("instance-count").textContent,
-    lastHeartbeat: within(endpointRow).getByTitle("Last Heartbeat").textContent,
+    lastHeartbeat: within(endpointRow).getByLabelText("Last Heartbeat").textContent,
     trackInstances: within(endpointRow).queryByTitle("Instances are being tracked") != null,
     instancesMuted: mutedInstanceCountElement === null ? 0 : Number(mutedInstanceCountElement.textContent),
   };