Skip to content

Commit 168fad5

Browse files
authored
Apply suggestions from code review
1 parent 84b7647 commit 168fad5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/Frontend/src/components/messages2/SequenceDiagram.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import useTooltips from "./SequenceDiagram/tooltipOverlay.ts";
99
import { onMounted, ref } from "vue";
1010
import LoadingSpinner from "@/components/LoadingSpinner.vue";
1111
const store = useSequenceDiagramStore();
12-
const { maxWidth, maxHeight } = storeToRefs(store);
12+
const { maxWidth, maxHeight, isLoading } = storeToRefs(store);
1313
const endpointYOffset = ref(0);
1414
1515
useTooltips();
@@ -22,7 +22,7 @@ onMounted(() => store.refreshConversation());
2222
<div class="toolbar">
2323
<a class="help-link" target="_blank" href="https://docs.particular.net/servicepulse/sequence-diagram"><i class="fa fa-info-circle" /> Sequence Diagram Help</a>
2424
</div>
25-
<LoadingSpinner v-if="store.isLoading" />
25+
<LoadingSpinner v-if="isLoading" />
2626
<div class="outer" @scroll="(ev) => (endpointYOffset = (ev.target as Element).scrollTop)">
2727
<svg class="sequence-diagram" :style="{ width: `max(100%, ${isNaN(maxWidth) ? 0 : maxWidth}px)` }" :height="maxHeight + 20">
2828
<Timeline />

src/Frontend/src/stores/SequenceDiagramStore.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export const useSequenceDiagramStore = defineStore("SequenceDiagramStore", () =>
4040
const handlerLocations = ref<HandlerLocation[]>([]);
4141
const highlightId = ref<string>();
4242

43-
const isLoading = computed(() => state.value.loading || !endpoints.value.length || !handlers.value.length || !routes.value.length);
43+
const isLoading = computed(() => conversationData.value.loading);
4444
const selectedId = computed(() => `${state.value.data.message_type ?? ""}(${state.value.data.id})`);
4545

4646
watch(

0 commit comments

Comments
 (0)