Skip to content

Commit 23cf740

Browse files
committed
Change to useTemplate for refs
As per https://vuejs.org/guide/essentials/template-refs
1 parent e14777f commit 23cf740

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

src/Frontend/src/components/failedmessages/DeletedMessageGroups.vue

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ interface ExtendedFailureGroupView extends FailureGroupView {
4040
}
4141
4242
let pollingFaster = false;
43-
const messageGroupList = ref();
4443
const archiveGroups = ref<ExtendedFailureGroupView[]>([]);
4544
const undismissedRestoreGroups = ref<ExtendedFailureGroupView[]>([]);
4645
const loadingData = ref(true);
@@ -68,12 +67,12 @@ function saveDefaultGroupingClassifier(classifier: string) {
6867
cookies.set("archived_groups_classification", classifier);
6968
}
7069
71-
function classifierChanged(classifier: string) {
70+
async function classifierChanged(classifier: string) {
7271
saveDefaultGroupingClassifier(classifier);
7372
7473
selectedClassifier.value = classifier;
7574
archiveGroups.value = [];
76-
messageGroupList.value = loadArchivedMessageGroups(classifier);
75+
await loadArchivedMessageGroups(classifier);
7776
}
7877
7978
async function getArchiveGroups(classifier: string) {
@@ -304,7 +303,7 @@ onMounted(async () => {
304303

305304
<div class="box-container">
306305
<div class="messagegrouplist">
307-
<div ref="messageGroupList">
306+
<div>
308307
<div class="row">
309308
<div class="col-sm-12">
310309
<no-data v-if="archiveGroups.length === 0 && !loadingData" title="message groups" message="There are currently no grouped message failures"></no-data>

src/Frontend/src/components/failedmessages/FailedMessageGroups.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script setup lang="ts">
2-
import { onMounted, ref } from "vue";
2+
import { onMounted, ref, useTemplateRef } from "vue";
33
import { licenseStatus } from "../../composables/serviceLicense";
44
import { connectionState } from "../../composables/serviceServiceControl";
55
import { useTypedFetchFromServiceControl } from "../../composables/serviceServiceControlUrls";
@@ -15,7 +15,7 @@ import getSortFunction from "@/components/getSortFunction";
1515
1616
const selectedClassifier = ref<string>("");
1717
const classifiers = ref<string[]>([]);
18-
const messageGroupList = ref<IMessageGroupList>();
18+
const messageGroupList = useTemplateRef<IMessageGroupList>("messageGroupList");
1919
const sortMethod = ref<SortOptions<GroupOperation>["sort"]>();
2020
2121
function sortGroups(sort: SortOptions<GroupOperation>) {

src/Frontend/src/components/failedmessages/FailedMessages.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script setup lang="ts">
2-
import { onMounted, onUnmounted, ref, watch } from "vue";
2+
import { onMounted, onUnmounted, ref, useTemplateRef, watch } from "vue";
33
import { licenseStatus } from "../../composables/serviceLicense";
44
import { connectionState } from "../../composables/serviceServiceControl";
55
import { useFetchFromServiceControl, usePatchToServiceControl, useTypedFetchFromServiceControl } from "../../composables/serviceServiceControlUrls";
@@ -31,7 +31,7 @@ const totalCount = ref(0);
3131
const showDelete = ref(false);
3232
const showConfirmRetryAll = ref(false);
3333
const showConfirmDeleteAll = ref(false);
34-
const messageList = ref<IMessageList>();
34+
const messageList = useTemplateRef<IMessageList>("messageList");
3535
const messages = ref<ExtendedFailedMessage[]>([]);
3636
const sortOptions: SortOptions<GroupOperation>[] = [
3737
{

src/Frontend/src/components/failedmessages/PendingRetries.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script setup lang="ts">
2-
import { onMounted, onUnmounted, ref, watch } from "vue";
2+
import { onMounted, onUnmounted, ref, useTemplateRef, watch } from "vue";
33
import { licenseStatus } from "../../composables/serviceLicense";
44
import { connectionState } from "../../composables/serviceServiceControl";
55
import { usePatchToServiceControl, usePostToServiceControl, useTypedFetchFromServiceControl } from "../../composables/serviceServiceControlUrls";
@@ -24,7 +24,7 @@ const perPage = 50;
2424
const cookies = useCookies().cookies;
2525
const selectedPeriod = ref("All Pending Retries");
2626
const endpoints = ref<string[]>([]);
27-
const messageList = ref<IMessageList>();
27+
const messageList = useTemplateRef<IMessageList>("messageList");
2828
const messages = ref<ExtendedFailedMessage[]>([]);
2929
const selectedQueue = ref("empty");
3030
const showConfirmRetry = ref(false);

0 commit comments

Comments
 (0)