Don't add proxy config for monitoring if monitoring is disabled

Author: johnsimons

src/ServicePulse/ReverseProxy.cs

@@ -7,6 +7,9 @@ static class ReverseProxy
 {
     public static (List<RouteConfig> routes, List<ClusterConfig> clusters) GetConfiguration(Settings settings)
     {
+        var routes = new List<RouteConfig>();
+        var clusters = new List<ClusterConfig>();
+
         var serviceControlInstance = new ClusterConfig
         {
             ClusterId = "serviceControlInstance",
@@ -15,17 +18,7 @@ public static (List<RouteConfig> routes, List<ClusterConfig> clusters) GetConfig
                 { "instance", new DestinationConfig { Address = settings.ServiceControlUri.ToString() } }
             }
         };
-
-        var monitoringInstance = new ClusterConfig
-        {
-            ClusterId = "monitoringInstance",
-            Destinations = new Dictionary<string, DestinationConfig>
-            {
-                { "instance", new DestinationConfig { Address = settings.MonitoringUri.ToString() } }
-            }
-        };
-
-        var serviceControlRoute = new RouteConfig()
+        var serviceControlRoute = new RouteConfig
         {
             RouteId = "serviceControlRoute",
             ClusterId = nameof(serviceControlInstance),
@@ -35,27 +28,30 @@ public static (List<RouteConfig> routes, List<ClusterConfig> clusters) GetConfig
             }
         }.WithTransformPathRemovePrefix("/api");
 
-        var monitoringRoute = new RouteConfig()
-        {
-            RouteId = "monitoringRoute",
-            ClusterId = nameof(monitoringInstance),
-            Match = new RouteMatch
-            {
-                Path = "/monitoring-api/{**catch-all}"
-            }
-        }.WithTransformPathRemovePrefix("/monitoring-api");
-
-        var routes = new List<RouteConfig>
-        {
-            serviceControlRoute,
-            monitoringRoute
-        };
+        clusters.Add(serviceControlInstance);
+        routes.Add(serviceControlRoute);
 
-        var clusters = new List<ClusterConfig>
+        if (settings.MonitoringUri != null)
         {
-            serviceControlInstance,
-            monitoringInstance
-        };
+            var monitoringInstance = new ClusterConfig
+            {
+                ClusterId = "monitoringInstance",
+                Destinations = new Dictionary<string, DestinationConfig>
+                {
+                    { "instance", new DestinationConfig { Address = settings.MonitoringUri.ToString() } }
+                }
+            };
+
+            var monitoringRoute = new RouteConfig
+            {
+                RouteId = "monitoringRoute",
+                ClusterId = nameof(monitoringInstance),
+                Match = new RouteMatch { Path = "/monitoring-api/{**catch-all}" }
+            }.WithTransformPathRemovePrefix("/monitoring-api");
+
+            clusters.Add(monitoringInstance);
+            routes.Add(monitoringRoute);
+        }
 
         return (routes, clusters);
     }