check for DOM element visibility

Author: soujay

src/Frontend/test/preconditions/licensing.ts

@@ -60,7 +60,7 @@ const getLicenseMockedResponse =
 
     const response = {
       ...licenseResponseTemplate,
-      license_type: licenseType,
+      license_type: status === LicenseStatus.ValidWithExpiringTrial || status === LicenseStatus.InvalidDueToExpiredTrial ? "Trial" : "Commercial",
       trial_license: trialLicense,
       expiration_date: expirationDate,
       upgrade_protection_expiration: upgradeProtectionExpiration,

src/Frontend/test/specs/configuration/questions/licenseExpiryDate.ts

@@ -1,6 +1,6 @@
 import { screen } from "@testing-library/vue";
 
 export async function licenseExpiryDate() {
-  const licenseExpiryDate = await screen.findByRole("note", { name: "license-expiry-date" });
-  return licenseExpiryDate.textContent?.trim;
+  const licenseExpiryDateElement = await screen.findByRole("note", { name: "license-expiry-date" });
+  return licenseExpiryDateElement;
 }

src/Frontend/test/specs/configuration/questions/licenseExpiryDaysLeft.ts

@@ -1,6 +1,6 @@
 import { screen } from "@testing-library/vue";
 
 export async function licenseExpiryDaysLeft() {
-  const licenseExpiryDaysLeft = await screen.findByRole("note", { name: "license-days-left" });
-  return licenseExpiryDaysLeft.textContent?.trim;
+  const licenseExpiryDaysLeftElement = await screen.findByRole("note", { name: "license-days-left" });
+  return licenseExpiryDaysLeftElement;
 }

src/Frontend/test/specs/configuration/viewing-license.spec.ts

@@ -40,6 +40,12 @@ describe("FEATURE: License", () => {
         expect(await licenseExpired()).toBe("Your license expired. Please update the license to continue using the Particular Service Platform.");
       });
     });
+    test.todo("EXAMPLE: Only 'LICENSE' tab is visible when license has expired");
+
+    /* SCENARIO
+          Given an expired license
+          Then "LICENSE" is the only visible tab in the Configuration screen
+        */
   });
 
   describe("RULE: License expiring soon must be displayed", () => {
@@ -48,26 +54,26 @@ describe("FEATURE: License", () => {
       await driver.setUp(precondition.hasExpiringLicense(LicenseType.Subscription, 10));
       await driver.goTo("/configuration/license");
       await waitFor(async () => {
-        // expect(await licenseExpiryDaysLeft()).toBeVisible(); //License expiry date: 2/5/2025 - expiring in 11 days
-        expect(await licenseExpiryDaysLeft()).toContain("expiring in"); //License expiry date: 2/5/2025 - expiring in 11 days
+        expect(await licenseExpiryDaysLeft()).toBeVisible(); //License expiry date: 2/5/2025 - expiring in 11 days
+        expect((await licenseExpiryDaysLeft()).textContent).toContain("expiring in"); //License expiry date: 2/5/2025 - expiring in 11 days
       });
     });
     test("EXAMPLE: License expiring tomorrow should show 'expiring tomorrow'", async ({ driver }) => {
       await driver.setUp(precondition.serviceControlWithMonitoring);
       await driver.setUp(precondition.hasExpiringLicense(LicenseType.Subscription, 0));
       await driver.goTo("/configuration/license");
       await waitFor(async () => {
-        // expect(await licenseExpiryDaysLeft()).toBeVisible();
-        expect(await licenseExpiryDaysLeft()).toContain("expiring tomorrow");
+        expect(await licenseExpiryDaysLeft()).toBeVisible();
+        expect((await licenseExpiryDaysLeft()).textContent).toContain("expiring tomorrow");
       });
     });
     test("EXAMPLE: License expiring today should show 'expiring today'", async ({ driver }) => {
       await driver.setUp(precondition.serviceControlWithMonitoring);
       await driver.setUp(precondition.hasExpiringLicense(LicenseType.Subscription, -1));
       await driver.goTo("/configuration/license");
       await waitFor(async () => {
-        //expect(await licenseExpiryDaysLeft()).toBeVisible();
-        expect(await licenseExpiryDaysLeft()).toContain("expiring today");
+        expect(await licenseExpiryDaysLeft()).toBeVisible();
+        expect((await licenseExpiryDaysLeft()).textContent).toContain("expiring today");
       });
     });
   });
@@ -78,35 +84,27 @@ describe("FEATURE: License", () => {
       await driver.setUp(precondition.hasExpiringLicense(LicenseType.UpgradeProtection, 10));
       await driver.goTo("/configuration/license");
       await waitFor(async () => {
-        // expect(await licenseExpiryDaysLeft()).toBeVisible(); //License expiry date: 2/5/2025 - expiring in 11 days
-        expect(await licenseExpiryDaysLeft()).toContain("days left"); //License expiry date: 2/5/2025 - expiring in 11 days
+        expect(await licenseExpiryDaysLeft()).toBeVisible(); //License expiry date: 2/5/2025 - expiring in 11 days
+        expect((await licenseExpiryDaysLeft()).textContent).toContain("days left"); //License expiry date: 2/5/2025 - expiring in 11 days
       });
     });
     test("EXAMPLE: Upgrade Protection license  expiring tomorrow should show 'expiring tomorrow'", async ({ driver }) => {
       await driver.setUp(precondition.serviceControlWithMonitoring);
       await driver.setUp(precondition.hasExpiringLicense(LicenseType.UpgradeProtection, 0));
       await driver.goTo("/configuration/license");
       await waitFor(async () => {
-        // expect(await licenseExpiryDaysLeft()).toBeVisible();
-        expect(await licenseExpiryDaysLeft()).toContain("1 day left");
+        expect(await licenseExpiryDaysLeft()).toBeVisible();
+        expect((await licenseExpiryDaysLeft()).textContent).toContain("1 day left");
       });
     });
     test("EXAMPLE: Upgrade Protection license  expiring today should show 'expired'", async ({ driver }) => {
       await driver.setUp(precondition.serviceControlWithMonitoring);
       await driver.setUp(precondition.hasExpiringLicense(LicenseType.UpgradeProtection, -1));
       await driver.goTo("/configuration/license");
       await waitFor(async () => {
-        //expect(await licenseExpiryDaysLeft()).toBeVisible();
-        expect(await licenseExpiryDaysLeft()).toContain("expired");
+        expect(await licenseExpiryDaysLeft()).toBeVisible();
+        expect((await licenseExpiryDaysLeft()).textContent).toContain("expired");
       });
     });
   });
-  describe("RULE: Non-license options should be hidden if license has expired", () => {
-    test.todo("EXAMPLE: Only 'LICENSE' tab is visible when license has expired");
-
-    /* SCENARIO
-          Given an expired license
-          Then "LICENSE" is the only visible tab in the Configuration screen
-        */
-  });
 });