Skip to content

Commit 6b72f7f

Browse files
committed
ensure loading only gets set to false once data is actually loaded
1 parent 7ed208b commit 6b72f7f

File tree

3 files changed

+16
-7
lines changed

3 files changed

+16
-7
lines changed

src/Frontend/src/components/failedmessages/DeletedMessages.vue

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script setup lang="ts">
2-
import { computed, onBeforeMount, onMounted, ref, watch } from "vue";
2+
import { computed, onBeforeMount, ref, watch } from "vue";
33
import { useShowToast } from "../../composables/toast";
44
import { onBeforeRouteLeave } from "vue-router";
55
import LicenseNotExpired from "../../components/LicenseNotExpired.vue";
@@ -78,9 +78,12 @@ watch(isRestoreInProgress, (restoreInProgress) => {
7878
7979
onBeforeMount(async () => {
8080
loading.value = true;
81+
//set status before mount to ensure no other controls/processes can cause extra refreshes during mount
8182
await store.setMessageStatus(FailedMessageStatus.Archived);
8283
});
83-
onMounted(() => (loading.value = false));
84+
watch(isRefreshing, () => {
85+
if (!isRefreshing.value && loading.value) loading.value = false;
86+
});
8487
</script>
8588

8689
<template>

src/Frontend/src/components/failedmessages/FailedMessages.vue

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script setup lang="ts">
2-
import { computed, onBeforeMount, onMounted, ref, useTemplateRef, watch } from "vue";
2+
import { computed, onBeforeMount, ref, useTemplateRef, watch } from "vue";
33
import { useShowToast } from "../../composables/toast";
44
import { downloadFileFromString } from "../../composables/fileDownloadCreator";
55
import { onBeforeRouteLeave } from "vue-router";
@@ -192,9 +192,12 @@ watch(isRetryOrDeleteOperationInProgress, (retryOrDeleteOperationInProgress) =>
192192
193193
onBeforeMount(async () => {
194194
loading.value = true;
195+
//set status before mount to ensure no other controls/processes can cause extra refreshes during mount
195196
await store.setMessageStatus(FailedMessageStatus.Unresolved);
196197
});
197-
onMounted(() => (loading.value = false));
198+
watch(isRefreshing, () => {
199+
if (!isRefreshing.value && loading.value) loading.value = false;
200+
});
198201
</script>
199202

200203
<template>

src/Frontend/src/components/failedmessages/PendingRetries.vue

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script setup lang="ts">
2-
import { onBeforeMount, onMounted, ref, useTemplateRef } from "vue";
2+
import { onBeforeMount, ref, useTemplateRef, watch } from "vue";
33
import { useShowToast } from "../../composables/toast";
44
import OrderBy from "@/components/OrderBy.vue";
55
import LicenseNotExpired from "../../components/LicenseNotExpired.vue";
@@ -21,7 +21,7 @@ import { useStoreAutoRefresh } from "@/composables/useAutoRefresh";
2121
import { RetryPeriodOption, useRecoverabilityStore } from "@/stores/RecoverabilityStore";
2222
2323
const loading = ref(false);
24-
const { autoRefresh } = useStoreAutoRefresh("messagesStore", useRecoverabilityStore, 5000);
24+
const { autoRefresh, isRefreshing } = useStoreAutoRefresh("messagesStore", useRecoverabilityStore, 5000);
2525
const { store } = autoRefresh();
2626
const { messages, totalCount, pageNumber, selectedPeriod, selectedQueue, endpoints } = storeToRefs(store);
2727
const configurationStore = useConfigurationStore();
@@ -124,9 +124,12 @@ async function periodChanged(period: RetryPeriodOption) {
124124
125125
onBeforeMount(async () => {
126126
loading.value = true;
127+
//set status before mount to ensure no other controls/processes can cause extra refreshes during mount
127128
await store.setMessageStatus(FailedMessageStatus.RetryIssued);
128129
});
129-
onMounted(() => (loading.value = false));
130+
watch(isRefreshing, () => {
131+
if (!isRefreshing.value && loading.value) loading.value = false;
132+
});
130133
</script>
131134

132135
<template>

0 commit comments

Comments
 (0)