Skip to content

Commit 9d201b4

Browse files
committed
A few updates based on feedback
1 parent a021c68 commit 9d201b4

File tree

3 files changed

+30
-25
lines changed

3 files changed

+30
-25
lines changed

.github/workflows/push-container-images.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,18 @@ jobs:
2222
with:
2323
version: ${{ inputs.version }}
2424
- name: Log in to GitHub container registry
25-
uses: docker/login-action@v3
25+
uses: docker/login-action@v3.3.0
2626
with:
2727
registry: ghcr.io
2828
username: ${{ github.actor }}
2929
password: ${{ secrets.GITHUB_TOKEN }}
3030
- name: Login to Docker Hub
31-
uses: docker/login-action@v3
31+
uses: docker/login-action@v3.3.0
3232
with:
3333
username: ${{ secrets.DOCKERHUB_USERNAME }}
3434
password: ${{ secrets.DOCKERHUB_TOKEN }}
3535
- name: Set up Docker Buildx
36-
uses: docker/setup-buildx-action@v3
36+
uses: docker/setup-buildx-action@v3.9.0
3737
- name: Publish to Docker Hub
3838
run: |
3939
$tags = "${{ steps.validate.outputs.container-tags }}" -Split ','

.github/workflows/release.yml

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,9 @@ jobs:
140140
with:
141141
version: ${{ env.MinVerVersion }}
142142
- name: Set up Docker Buildx
143-
uses: docker/setup-buildx-action@v3
143+
uses: docker/setup-buildx-action@v3.9.0
144144
- name: Log in to GitHub container registry
145-
uses: docker/login-action@v3
145+
uses: docker/login-action@v3.3.0
146146
with:
147147
registry: ghcr.io
148148
username: ${{ github.actor }}
@@ -151,16 +151,36 @@ jobs:
151151
id: date
152152
run: echo "date=$(date '+%FT%TZ')" >> $GITHUB_OUTPUT
153153
- name: Build and push image to GitHub container registry
154-
uses: docker/build-push-action@v6
154+
uses: docker/build-push-action@v6.14.0
155155
with:
156156
context: .
157157
push: true
158158
platforms: linux/amd64,linux/arm64
159159
sbom: true
160-
build-args: |
161-
VERSION=${{ env.MinVerVersion }}
162-
SHA=${{ github.sha }}
163-
CREATED=${{ steps.date.outputs.date }}
160+
labels: |
161+
org.opencontainers.image.source=https://github.com/Particular/ServicePulse/tree/${{ github.sha }}
162+
org.opencontainers.image.authors="Particular Software"
163+
org.opencontainers.image.vendor="Particular Software"
164+
org.opencontainers.image.url=https://hub.docker.com/r/particular/servicepulse
165+
org.opencontainers.image.documentation=https://docs.particular.net/servicepulse/
166+
org.opencontainers.image.version=${{ env.MinVerVersion }}
167+
org.opencontainers.image.revision=${{ github.sha }}
168+
org.opencontainers.image.created=${{ steps.date.outputs.date }}
169+
org.opencontainers.image.title=ServicePulse
170+
org.opencontainers.image.description=ServicePulse provides real-time production monitoring for distributed applications. It monitors the health of a system's endpoints, detects processing errors, sends failed messages for reprocessing, and ensures the specific environment's needs are met, all in one consolidated dashboard.
171+
org.opencontainers.image.base.name=mcr.microsoft.com/dotnet/aspnet:8.0-noble-chiseled-composite
172+
annotations: |
173+
index:org.opencontainers.image.source=https://github.com/Particular/ServicePulse/tree/${{ github.sha }}
174+
index:org.opencontainers.image.authors="Particular Software"
175+
index:org.opencontainers.image.vendor="Particular Software"
176+
index:org.opencontainers.image.url=https://hub.docker.com/r/particular/servicepulse
177+
index:org.opencontainers.image.documentation=https://docs.particular.net/servicepulse/
178+
index:org.opencontainers.image.version=${{ env.MinVerVersion }}
179+
index:org.opencontainers.image.revision=${{ github.sha }}
180+
index:org.opencontainers.image.created=${{ steps.date.outputs.date }}
181+
index:org.opencontainers.image.title=ServicePulse
182+
index:org.opencontainers.image.description=ServicePulse provides real-time production monitoring for distributed applications. It monitors the health of a system's endpoints, detects processing errors, sends failed messages for reprocessing, and ensures the specific environment's needs are met, all in one consolidated dashboard.
183+
index:org.opencontainers.image.base.name=mcr.microsoft.com/dotnet/aspnet:8.0-noble-chiseled-composite
164184
file: src/ServicePulse/Dockerfile
165185
tags: ghcr.io/particular/servicepulse:${{ github.event_name == 'pull_request' && format('pr-{0}', github.event.number) || env.MinVerVersion }}
166186

src/ServicePulse/Dockerfile

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,23 +16,8 @@ RUN dotnet publish src/ServicePulse/ServicePulse.csproj -a $TARGETARCH -o /app
1616

1717
# Host runtime image
1818
FROM mcr.microsoft.com/dotnet/aspnet:8.0-noble-chiseled-composite
19-
ARG VERSION
20-
ARG SHA=unknown
21-
ARG CREATED=2000-01-01T00:00:00Z
2219
WORKDIR /app
2320

24-
LABEL org.opencontainers.image.source=https://github.com/Particular/servicepulse/tree/$SHA
25-
LABEL org.opencontainers.image.authors="Particular Software"
26-
LABEL org.opencontainers.image.vendor="Particular Software"
27-
LABEL org.opencontainers.image.url=https://hub.docker.com/r/particular/servicepulse
28-
LABEL org.opencontainers.image.documentation=https://docs.particular.net/servicepulse/
29-
LABEL org.opencontainers.image.version=$VERSION
30-
LABEL org.opencontainers.image.revision=$SHA
31-
LABEL org.opencontainers.image.created=$CREATED
32-
LABEL org.opencontainers.image.title="ServicePulse"
33-
LABEL org.opencontainers.image.description="ServicePulse provides real-time production monitoring for distributed applications. It monitors the health of a system's endpoints, detects processing errors, sends failed messages for reprocessing, and ensures the specific environment's needs are met, all in one consolidated dashboard."
34-
LABEL org.opencontainers.image.base.name=mcr.microsoft.com/dotnet/aspnet:8.0-noble-chiseled-composite
35-
3621
ENV ASPNETCORE_HTTP_PORTS=9090
3722
EXPOSE 9090
3823
COPY --from=build /app .

0 commit comments

Comments
 (0)