Code analysis fixes (#2242)

* Code analysis fixes

* Overriding bash default here

* Set all shells correctly

Author: DavidBoike

.github/workflows/ci.yml

@@ -8,6 +8,9 @@ on:
   workflow_dispatch:
 env:
   DOTNET_NOLOGO: true
+defaults:
+  run:
+    shell: pwsh
 jobs:
   build:
     name: Windows

.github/workflows/release.yml

@@ -11,6 +11,9 @@ on:
   workflow_dispatch:
 env:
   DOTNET_NOLOGO: true
+defaults:
+  run:
+    shell: pwsh
 jobs:
   windows-standalone:
     if: ${{ github.actor != 'dependabot[bot]' }}
@@ -19,7 +22,6 @@ jobs:
       - name: Check for secrets
         env:
           SECRETS_AVAILABLE: ${{ secrets.SECRETS_AVAILABLE }}
-        shell: pwsh
         run: exit $(If ($env:SECRETS_AVAILABLE -eq 'true') { 0 } Else { 1 })
       - name: Checkout
         uses: actions/[email protected]
@@ -107,12 +109,11 @@ jobs:
     name: linux-container
     defaults:
       run:
-        shell: bash
+        shell: pwsh
     steps:
       - name: Check for secrets
         env:
           SECRETS_AVAILABLE: ${{ secrets.SECRETS_AVAILABLE }}
-        shell: pwsh
         run: exit $(If ($env:SECRETS_AVAILABLE -eq 'true') { 0 } Else { 1 })
       - name: Checkout
         uses: actions/[email protected]
@@ -121,7 +122,6 @@ jobs:
       - name: Install MinVer CLI
         run: dotnet tool install --global minver-cli
       - name: Determine version
-        shell: pwsh
         run: |
           # Read settings from Custom.Build.props
           [xml]$xml = Get-Content ./src/Custom.Build.props
@@ -131,7 +131,7 @@ jobs:
           if (-not ($minMajorMinor -and $autoIncrement)) {
             throw "Missing MinVer settings in Custom.Build.props"
           }
-          
+
           # Execute MinVer
           echo "MinVerVersion=$(minver --minimum-major-minor $minMajorMinor --auto-increment $autoIncrement)" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf-8 -Append
       - name: Validate build version
@@ -142,10 +142,12 @@ jobs:
       - name: Set up Docker Buildx
         uses: docker/[email protected]
       - name: Log in to GitHub container registry
+        shell: bash
         run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin
       - name: Build & inspect image
         env:
           TAG_NAME: ${{ github.event_name == 'pull_request' && format('pr-{0}', github.event.number) || env.MinVerVersion }}
+        shell: bash
         run: |
           docker buildx build --push --tag ghcr.io/particular/servicepulse:${{ env.TAG_NAME }} \
             --file src/ServicePulse/Dockerfile \

src/ServicePulse.Host/Properties/AssemblyInfo.cs

@@ -28,4 +28,8 @@
     <Content Include="app\js\app.constants.js" CopyToOutputDirectory="PreserveNewest" Condition="Exists('app\js\app.constants.js')" />
   </ItemGroup>
 
+  <ItemGroup>
+    <InternalsVisibleTo Include="ServicePulse.Host.Tests" />
+  </ItemGroup>
+
 </Project>