Skip to content

Commit d2c1edc

Browse files
committed
cleanup after review
1 parent 41a527f commit d2c1edc

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

src/Frontend/src/stores/ConnectionsAndStatsStore.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,7 @@ export const useConnectionsAndStatsStore = defineStore("ConnectionsAndStatsStore
1818

1919
const { count: requiresFullFailureDetailsSubscriberCount, inc, dec } = useCounter(0);
2020
function requiresFullFailureDetails() {
21-
onMounted(() => {
22-
inc();
23-
refresh();
24-
});
21+
onMounted(() => inc()); //NOTE: not forcing a refresh here since we expect the view utilising this store to also setup a refresh on mount
2522
onUnmounted(() => dec());
2623
}
2724

src/Frontend/src/stores/MessagesStore.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ export const useMessagesStore = defineStore("MessagesStore", () => {
176176

177177
async function setSort(sort: string, direction?: SortDirection) {
178178
if (controller) {
179-
// need to cancel any existing fetch which otherwise will set messages of the incorrect status
179+
// need to cancel any existing fetch which otherwise will set messages of the incorrect sort
180180
controller.abort();
181181
}
182182
sortBy.value = sort;
@@ -187,7 +187,7 @@ export const useMessagesStore = defineStore("MessagesStore", () => {
187187

188188
async function setPeriod(period: DeletedPeriodOption | RetryPeriodOption) {
189189
if (controller) {
190-
// need to cancel any existing fetch which otherwise will set messages of the incorrect status
190+
// need to cancel any existing fetch which otherwise will set messages of the incorrect period
191191
controller.abort();
192192
}
193193
selectedPeriod.value = period;

0 commit comments

Comments
 (0)