Skip to content

Commit e5ab108

Browse files
committed
switch to using full type name for internal identification of handlers/routes
1 parent 04127fc commit e5ab108

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

src/Frontend/src/components/messages2/SequenceDiagram/HandlerTooltip.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function formatTime(milliseconds: number) {
1818
<label>Processing Time:</label>
1919
<span>{{ formatTime(handler.processingTime ?? 0) }}</span>
2020
<label>Processing Of:</label>
21-
<span>{{ handler.name }}</span>
21+
<span>{{ handler.friendlyName }}</span>
2222
<label v-if="handler.partOfSaga">Sagas Invoked:</label>
2323
<span v-if="handler.partOfSaga">{{ handler.partOfSaga }}</span>
2424
</div>

src/Frontend/src/components/messages2/SequenceDiagram/HandlersComponent.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ const handlerItems = computed(() => {
6363
fill,
6464
icon,
6565
iconSize,
66-
messageType: handler.name,
66+
messageType: handler.friendlyName,
6767
messageTypeOffset,
6868
messageTypeHighlight: handler.route?.name === highlightId.value,
6969
messageTypeSelected: handler.route?.name === selectedId.value,

src/Frontend/src/resources/SequenceDiagram/Handler.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import { friendlyTypeName } from "./SequenceModel";
77
export interface Handler {
88
readonly id: string;
99
name?: string;
10+
friendlyName?: string;
1011
readonly endpoint: Endpoint;
1112
readonly isPartOfSaga: boolean;
1213
partOfSaga?: string;
@@ -61,7 +62,8 @@ export function updateProcessingHandler(handler: Handler, message: Message) {
6162
//TODO: extract logic since it's also currently used in AuditList
6263
const [hh, mm, ss] = message.processing_time.split(":");
6364
handler.processingTime = ((parseInt(hh) * 60 + parseInt(mm)) * 60 + parseFloat(ss)) * 1000;
64-
handler.name = friendlyTypeName(message.message_type);
65+
handler.name = message.message_type;
66+
handler.friendlyName = friendlyTypeName(message.message_type);
6567

6668
if ((message.invoked_sagas?.length ?? 0) > 0) {
6769
handler.partOfSaga = message.invoked_sagas!.map((saga) => friendlyTypeName(saga.saga_type)).join(", ");

src/Frontend/src/stores/SequenceDiagramStore.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { acceptHMRUpdate, defineStore, storeToRefs } from "pinia";
22
import { computed, ref, watch } from "vue";
3-
import { friendlyTypeName, ModelCreator } from "@/resources/SequenceDiagram/SequenceModel";
3+
import { ModelCreator } from "@/resources/SequenceDiagram/SequenceModel";
44
import { Endpoint } from "@/resources/SequenceDiagram/Endpoint";
55
import { Handler } from "@/resources/SequenceDiagram/Handler";
66
import { MessageProcessingRoute } from "@/resources/SequenceDiagram/RoutedMessage";
@@ -40,7 +40,7 @@ export const useSequenceDiagramStore = defineStore("SequenceDiagramStore", () =>
4040
const handlerLocations = ref<HandlerLocation[]>([]);
4141
const highlightId = ref<string>();
4242

43-
const selectedId = computed(() => `${friendlyTypeName(state.value.data.message_type ?? "")}(${state.value.data.id})`);
43+
const selectedId = computed(() => `${state.value.data.message_type ?? ""}(${state.value.data.id})`);
4444

4545
watch(
4646
() => messageStore.conversationData.data,

0 commit comments

Comments
 (0)