add test for no custom check data scenario

Author: soujay

src/Frontend/test/mocks/custom-checks-template.ts

@@ -106,3 +106,6 @@ export const customCheckItems: CustomCheck[] = [
     },
   },
 ];
+
+export const failedCustomCheckItems = customCheckItems.filter((check) => check.status === "Fail");
+export const passedCustomCheckItems = customCheckItems.filter((check) => check.status === "Pass");

src/Frontend/test/preconditions/customChecks.ts

@@ -1,43 +1,47 @@
 import { SetupFactoryOptions } from "../driver";
-import { customCheckItems } from "../mocks/custom-checks-template";
+import { passedCustomCheckItems, customCheckItems } from "../mocks/custom-checks-template";
 
-const content = JSON.stringify([]);
-const failedCustomCheckItems = customCheckItems.filter((check) => check.status === "Fail");
-const passedCustomCheckItems = customCheckItems.filter((check) => check.status === "Pass");
+const emptyContent = JSON.stringify([]);
 
 export const hasCustomChecksEmpty = ({ driver }: SetupFactoryOptions) => {
   const serviceControlInstanceUrl = window.defaultConfig.service_control_url;
   driver.mockEndpoint(`${serviceControlInstanceUrl}customchecks`, {
-    body: content,
+    body: emptyContent,
     headers: {
       "Total-Count": "0", //count of failing custom checks
     },
   });
 };
 
-export const hasCustomChecksFailing = ({ driver }: SetupFactoryOptions) => {
+export const hasCustomChecksPassing = ({ driver }: SetupFactoryOptions) => {
   const serviceControlInstanceUrl = window.defaultConfig.service_control_url;
   driver.mockEndpointDynamic(`${serviceControlInstanceUrl}customchecks`, (url) => {
     const status = url.searchParams.get("status");
+    let dataForCustomCheckItems = passedCustomCheckItems;
+
     if (status === "fail") {
-      return {
-        body: failedCustomCheckItems,
-        headers: { "Total-Count": failedCustomCheckItems.length.toString() },
-      };
+      dataForCustomCheckItems = dataForCustomCheckItems.filter((check) => check.status === "Fail");
     }
 
     return {
-      body: passedCustomCheckItems,
-      headers: { "Total-Count": passedCustomCheckItems.length.toString() },
+      body: dataForCustomCheckItems,
+      headers: { "Total-Count": dataForCustomCheckItems.length.toString() },
     };
   });
 };
-export const hasCustomChecksPassing = ({ driver }: SetupFactoryOptions) => {
+export const hasCustomChecks = ({ driver }: SetupFactoryOptions) => {
   const serviceControlInstanceUrl = window.defaultConfig.service_control_url;
-  driver.mockEndpoint(`${serviceControlInstanceUrl}customchecks`, {
-    body: passedCustomCheckItems,
-    headers: {
-      "Total-Count": passedCustomCheckItems.length.toString(), //count of passing custom checks
-    },
+  driver.mockEndpointDynamic(`${serviceControlInstanceUrl}customchecks`, (url) => {
+    const status = url.searchParams.get("status");
+    let dataForCustomCheckItems = customCheckItems;
+
+    if (status === "fail") {
+      dataForCustomCheckItems = dataForCustomCheckItems.filter((check) => check.status === "Fail");
+    }
+
+    return {
+      body: dataForCustomCheckItems,
+      headers: { "Total-Count": dataForCustomCheckItems.length.toString() },
+    };
   });
 };

src/Frontend/test/specs/customchecks/viewing-no-data.spec.ts

@@ -5,52 +5,26 @@ import { customChecksMessage } from "./questions/customChecksMessage";
 import { waitFor } from "@testing-library/vue";
 
 describe("FEATURE: No data", () => {
-  describe("RULE: When there is no data to show a message should be displayed ", () => {
-    /* SCENARIO
-          Given there are no custom checks
-          When navigating to the custom checks tab
-          Then a message is shown "No failed custom checks"
-        */
+  describe("RULE: When there is no data to show, a message should be displayed ", () => {
     test("EXAMPLE: There are no failed or passing custom checks", async ({ driver }) => {
-      //Arrange
       await driver.setUp(precondition.serviceControlWithMonitoring);
-      // given that the custom check list is empty
       await driver.setUp(precondition.hasCustomChecksEmpty);
 
-      //Act - When navigating to the custom checks tab
       await driver.goTo("/custom-checks");
-      //Expect
+
       await waitFor(async () => {
         expect(await customChecksMessage()).toBe("No failed custom checks");
       });
     });
-    /* SCENARIO
-          Given there are custom checks
-          And all custom checks are in a success state
-          When navigating to the custom checks tab
-          Then a message is shown "No failed custom checks"
-        */
     test("EXAMPLE: There are custom checks but none of them are failing", async ({ driver }) => {
-      //Arrange
-      // vi.useFakeTimers();
       await driver.setUp(precondition.serviceControlWithMonitoring);
-      console.log("test started now;");
-      // given that the custom check list is not empty and status of all checks are passing
       await driver.setUp(precondition.hasCustomChecksPassing);
 
-      //Act - When navigating to the custom checks tab
       await driver.goTo("/custom-checks");
-      console.log("navigating to the custom checks tab");
-      //vi.advanceTimersByTime(10000);
-      //setTimeout(async () => {
-      //Expect
-      waitFor(async () => {
-        console.log("expecting");
+
+      await waitFor(async () => {
         expect(await customChecksMessage()).toBe("No failed custom checks");
       });
-      //  }, 5500);
-
-      // vi.restoreAllMocks();
     });
   });
 });