Display saga messages body using CodeEditor #2402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquirosj
changed the title
cquirosj
changed the title
cquirosj
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
johnsimons
approved these changes
May 7, 2025
| <div class="editor-container"> | ||
| <!-- Maximize Button (shown on hover) --> | ||
| <button v-if="showMaximizeButton" @click="toggleMaximizeModal" class="maximize-button" title="Maximize view"> | ||
| <img :src="DiffMaximizeIcon" alt="Maximize" width="14" height="14" /> |
There was a problem hiding this comment.
it would be better to use the svg directly not via a img tag
johnsimons
approved these changes
May 7, 2025
johnsimons
reviewed
May 7, 2025
Comment on lines
+4
to
+5
| import DiffMaximizeIcon from "@/assets/diff-maximize.svg"; | ||
| import DiffCloseIcon from "@/assets/diff-close.svg"; |
There was a problem hiding this comment.
We should try to use fontawesome icons if available
johnsimons
reviewed
May 7, 2025
johnsimons
reviewed
May 7, 2025
PhilBastian
requested changes
May 7, 2025
src/Frontend/src/components/messages2/SagaDiagram/SagaUpdateNode.vue
Outdated
Show resolved
Hide resolved
| export interface SagaMessageData { | ||
| message_id: string; | ||
| data: SagaMessageDataItem[]; | ||
| body: DataContainer<{ value?: string; content_type?: string }>; |
There was a problem hiding this comment.
why content_type instead of contentType? It seems like this is not an API response object
| }; | ||
|
|
||
| result.body.loading = true; | ||
| result.body.failed_to_load = false; |
There was a problem hiding this comment.
why failed_to_load and not_found rather than failedToLoad and notFound?
johnsimons
reviewed
May 7, 2025
Inspired by the one in MessageStore. Potential removal of duplication a
Co-authored-by: John Simons <[email protected]>
…de.vue Co-authored-by: Phil Bastian <[email protected]>
PhilBastian
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Potential improvements: