Adding tippies to Saga Diagram #2412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquirosj
force-pushed
the
saga-missing-typpies
branch
from
f2ecc21 to
2517d8a
Compare
johnsimons
requested changes
May 12, 2025
src/Frontend/src/components/messages2/SagaDiagram/MessageDataBox.vue
Outdated
Show resolved
Hide resolved
src/Frontend/src/components/messages2/SagaDiagram/MessageDataBox.vue
Outdated
Show resolved
Hide resolved
src/Frontend/src/components/messages2/SagaDiagram/MessageDataBox.vue
Outdated
Show resolved
Hide resolved
src/Frontend/src/components/messages2/SagaDiagram/NoSagaData.vue
Outdated
Show resolved
Hide resolved
| alt="" | ||
| v-tippy="update.InitiatingMessage.IsSagaTimeoutMessage ? `Timeout Message` : update.InitiatingMessage.IsEventMessage ? `Event Message` : `Command Message`" | ||
| /> | ||
| <h2 class="message-title" aria-label="initiating message type" v-tippy="update.InitiatingMessage.FriendlyTypeName">{{ update.InitiatingMessage.FriendlyTypeName }}</h2> |
There was a problem hiding this comment.
Use EllipsesComponent instead.
| <a | ||
| v-if="update.InitiatingMessage.HasRelatedTimeoutRequest" | ||
| v-tippy="`Scroll to timeout request`" | ||
| v-tippy="`View original timeout request`" |
src/Frontend/src/components/messages2/SagaDiagram/SagaUpdateNode.vue
Outdated
Show resolved
Hide resolved
src/Frontend/src/components/messages2/SagaDiagram/SagaUpdateNode.vue
Outdated
Show resolved
Hide resolved
src/Frontend/src/components/messages2/SagaDiagram/SagaUpdateNode.vue
Outdated
Show resolved
Hide resolved
|
No need to reinterate on a tooltip what the context aready states. |
…ox.vue Co-authored-by: John Simons <[email protected]>
…ox.vue Co-authored-by: John Simons <[email protected]>
…ox.vue Co-authored-by: John Simons <[email protected]>
Co-authored-by: John Simons <[email protected]>
…de.vue Co-authored-by: John Simons <[email protected]>
…de.vue Co-authored-by: John Simons <[email protected]>
…de.vue Co-authored-by: John Simons <[email protected]>
…dNode.vue Co-authored-by: John Simons <[email protected]>
…TimeoutMessage.vue Co-authored-by: John Simons <[email protected]>
…eded.vue Co-authored-by: John Simons <[email protected]>
…eded.vue Co-authored-by: John Simons <[email protected]>
…eded.vue Co-authored-by: John Simons <[email protected]>
johnsimons
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.