From e8ba50f654f64dd2ca9c392e53a84535a072b1f8 Mon Sep 17 00:00:00 2001 From: Christian Date: Wed, 11 Jun 2025 00:08:19 -0600 Subject: [PATCH 1/5] User indicator update for transactional session --- .../src/views/throughputreport/EndpointsView.vue | 4 +++- .../endpoints/DetectedBrokerQueuesView.vue | 10 +++++++++- .../endpoints/DetectedEndpointsView.vue | 9 ++++++++- .../views/throughputreport/endpoints/userIndicator.ts | 4 +++- .../throughputreport/endpoints/userIndicatorMapper.ts | 4 +++- 5 files changed, 26 insertions(+), 5 deletions(-) diff --git a/src/Frontend/src/views/throughputreport/EndpointsView.vue b/src/Frontend/src/views/throughputreport/EndpointsView.vue index 81c7a4f89..e324e8920 100644 --- a/src/Frontend/src/views/throughputreport/EndpointsView.vue +++ b/src/Frontend/src/views/throughputreport/EndpointsView.vue @@ -12,7 +12,9 @@ const showLegend = ref(true); const legendOptions = new Map([ [UserIndicator.NServiceBusEndpoint, "Known NServiceBus Endpoint"], [UserIndicator.NServiceBusEndpointNoLongerInUse, "NServiceBus Endpoint that is no longer in use, usually this would have zero throughput"], - [UserIndicator.SendOnlyOrTransactionSessionEndpoint, "If the endpoint has no throughput or the endpoint has Transactional Session feature enabled"], + [UserIndicator.TransactionSessionEndpoint, "If the endpoint has Transactional Session feature enabled"], + [UserIndicator.TransactionalSessionProcessorEndpoint, "A processor endpoint that manages the outbox on behalf of send-only endpoints when using transactional sessions"], + [UserIndicator.SendOnlyEndpoint, "If the endpoint has no throughput (send-only endpoint)"], [UserIndicator.PlannedToDecommission, "If the endpoint is planned to no longer be used in the next 30 days"], [UserIndicator.NotNServiceBusEndpoint, "Not an NServiceBus Endpoint"], ]); diff --git a/src/Frontend/src/views/throughputreport/endpoints/DetectedBrokerQueuesView.vue b/src/Frontend/src/views/throughputreport/endpoints/DetectedBrokerQueuesView.vue index db093096d..d73375f1e 100644 --- a/src/Frontend/src/views/throughputreport/endpoints/DetectedBrokerQueuesView.vue +++ b/src/Frontend/src/views/throughputreport/endpoints/DetectedBrokerQueuesView.vue @@ -22,7 +22,15 @@ const { testResults } = storeToRefs(store); ([ [UserIndicator.NServiceBusEndpoint, "NServiceBus Endpoint"], [UserIndicator.NServiceBusEndpointNoLongerInUse, "No longer in use"], - [UserIndicator.SendOnlyOrTransactionSessionEndpoint, "SendOnly or Transactional Session Endpoint"], + [UserIndicator.TransactionSessionEndpoint, "Transaction Session Endpoint"], + [UserIndicator.TransactionalSessionProcessorEndpoint, "Transactional Session Processor Endpoint"], + [UserIndicator.SendOnlyEndpoint, "Send-Only Endpoint"], [UserIndicator.PlannedToDecommission, "Planned to be decommissioned"], [UserIndicator.NotNServiceBusEndpoint, "Not an NServiceBus Endpoint"], ]); From 9860e51f922963b39d2d67c6537cdbe2e25b7b26 Mon Sep 17 00:00:00 2001 From: Christian Date: Wed, 11 Jun 2025 19:27:21 -0600 Subject: [PATCH 2/5] links in legend options --- .../src/views/throughputreport/EndpointsView.vue | 10 ++++++---- .../endpoints/DetectedBrokerQueuesView.vue | 1 - .../endpoints/DetectedEndpointsView.vue | 9 +-------- .../views/throughputreport/endpoints/userIndicator.ts | 1 - .../throughputreport/endpoints/userIndicatorMapper.ts | 1 - 5 files changed, 7 insertions(+), 15 deletions(-) diff --git a/src/Frontend/src/views/throughputreport/EndpointsView.vue b/src/Frontend/src/views/throughputreport/EndpointsView.vue index e324e8920..f1ce46424 100644 --- a/src/Frontend/src/views/throughputreport/EndpointsView.vue +++ b/src/Frontend/src/views/throughputreport/EndpointsView.vue @@ -10,10 +10,12 @@ import { storeToRefs } from "pinia"; const { isBrokerTransport } = storeToRefs(useThroughputStore()); const showLegend = ref(true); const legendOptions = new Map([ - [UserIndicator.NServiceBusEndpoint, "Known NServiceBus Endpoint"], + [UserIndicator.NServiceBusEndpoint, 'Known NServiceBus Endpoint'], [UserIndicator.NServiceBusEndpointNoLongerInUse, "NServiceBus Endpoint that is no longer in use, usually this would have zero throughput"], - [UserIndicator.TransactionSessionEndpoint, "If the endpoint has Transactional Session feature enabled"], - [UserIndicator.TransactionalSessionProcessorEndpoint, "A processor endpoint that manages the outbox on behalf of send-only endpoints when using transactional sessions"], + [ + UserIndicator.TransactionalSessionProcessorEndpoint, + 'A processor endpoint that manages the outbox on behalf of send-only endpoints when using transactional session', + ], [UserIndicator.SendOnlyEndpoint, "If the endpoint has no throughput (send-only endpoint)"], [UserIndicator.PlannedToDecommission, "If the endpoint is planned to no longer be used in the next 30 days"], [UserIndicator.NotNServiceBusEndpoint, "Not an NServiceBus Endpoint"], @@ -35,7 +37,7 @@ function toggleOptionsLegendVisible() {

- {{ userIndicatorMapper.get(key) }} - {{ value }}. + {{ userIndicatorMapper.get(key) }} - .
diff --git a/src/Frontend/src/views/throughputreport/endpoints/DetectedBrokerQueuesView.vue b/src/Frontend/src/views/throughputreport/endpoints/DetectedBrokerQueuesView.vue index d73375f1e..7d01dc34f 100644 --- a/src/Frontend/src/views/throughputreport/endpoints/DetectedBrokerQueuesView.vue +++ b/src/Frontend/src/views/throughputreport/endpoints/DetectedBrokerQueuesView.vue @@ -25,7 +25,6 @@ const { testResults } = storeToRefs(store); :indicator-options="[ UserIndicator.NServiceBusEndpoint, UserIndicator.NotNServiceBusEndpoint, - UserIndicator.TransactionSessionEndpoint, UserIndicator.TransactionalSessionProcessorEndpoint, UserIndicator.SendOnlyEndpoint, UserIndicator.NServiceBusEndpointNoLongerInUse, diff --git a/src/Frontend/src/views/throughputreport/endpoints/DetectedEndpointsView.vue b/src/Frontend/src/views/throughputreport/endpoints/DetectedEndpointsView.vue index e35ccf397..a41d80315 100644 --- a/src/Frontend/src/views/throughputreport/endpoints/DetectedEndpointsView.vue +++ b/src/Frontend/src/views/throughputreport/endpoints/DetectedEndpointsView.vue @@ -23,14 +23,7 @@ const { isBrokerTransport, hasErrors } = storeToRefs(useThroughputStore()); ([ [UserIndicator.NServiceBusEndpoint, "NServiceBus Endpoint"], [UserIndicator.NServiceBusEndpointNoLongerInUse, "No longer in use"], - [UserIndicator.TransactionSessionEndpoint, "Transaction Session Endpoint"], [UserIndicator.TransactionalSessionProcessorEndpoint, "Transactional Session Processor Endpoint"], [UserIndicator.SendOnlyEndpoint, "Send-Only Endpoint"], [UserIndicator.PlannedToDecommission, "Planned to be decommissioned"], From 435be4a87362ecd7b6d145fce18f21b33fc3184b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20=C3=96hlund?= Date: Mon, 16 Jun 2025 19:54:37 +0200 Subject: [PATCH 3/5] Apply suggestions from code review Co-authored-by: Poornima Nayar --- src/Frontend/src/views/throughputreport/EndpointsView.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Frontend/src/views/throughputreport/EndpointsView.vue b/src/Frontend/src/views/throughputreport/EndpointsView.vue index f1ce46424..f62018ae7 100644 --- a/src/Frontend/src/views/throughputreport/EndpointsView.vue +++ b/src/Frontend/src/views/throughputreport/EndpointsView.vue @@ -14,9 +14,9 @@ const legendOptions = new Map([ [UserIndicator.NServiceBusEndpointNoLongerInUse, "NServiceBus Endpoint that is no longer in use, usually this would have zero throughput"], [ UserIndicator.TransactionalSessionProcessorEndpoint, - 'A processor endpoint that manages the outbox on behalf of send-only endpoints when using transactional session', + 'A [processor endpoint](https://docs.particular.net/nservicebus/transactional-session/#remote-processor) that manages the outbox on behalf of send-only endpoints when using transactional session', ], - [UserIndicator.SendOnlyEndpoint, "If the endpoint has no throughput (send-only endpoint)"], + [UserIndicator.SendOnlyEndpoint, "An endpoint that only sends messages and does not process any messages"], [UserIndicator.PlannedToDecommission, "If the endpoint is planned to no longer be used in the next 30 days"], [UserIndicator.NotNServiceBusEndpoint, "Not an NServiceBus Endpoint"], ]); From d3e3b8e64b1ad663df949a1e15b8a5747e2cac1d Mon Sep 17 00:00:00 2001 From: Christian Date: Mon, 16 Jun 2025 21:41:26 -0600 Subject: [PATCH 4/5] Individual legend components --- .../views/throughputreport/EndpointsView.vue | 30 +++++++++++-------- .../LegendNServiceBusEndpoint.vue | 6 ++++ ...LegendNServiceBusEndpointNoLongerInUse.vue | 3 ++ .../LegendNotNServiceBusEndpoint.vue | 3 ++ .../LegendPlannedToDecommission.vue | 3 ++ .../LegendSendOnlyEndpoint.vue | 3 ++ ...dTransactionalSessionProcessorEndpoint.vue | 7 +++++ 7 files changed, 42 insertions(+), 13 deletions(-) create mode 100644 src/Frontend/src/views/throughputreport/LegendNServiceBusEndpoint.vue create mode 100644 src/Frontend/src/views/throughputreport/LegendNServiceBusEndpointNoLongerInUse.vue create mode 100644 src/Frontend/src/views/throughputreport/LegendNotNServiceBusEndpoint.vue create mode 100644 src/Frontend/src/views/throughputreport/LegendPlannedToDecommission.vue create mode 100644 src/Frontend/src/views/throughputreport/LegendSendOnlyEndpoint.vue create mode 100644 src/Frontend/src/views/throughputreport/LegendTransactionalSessionProcessorEndpoint.vue diff --git a/src/Frontend/src/views/throughputreport/EndpointsView.vue b/src/Frontend/src/views/throughputreport/EndpointsView.vue index f62018ae7..54c594094 100644 --- a/src/Frontend/src/views/throughputreport/EndpointsView.vue +++ b/src/Frontend/src/views/throughputreport/EndpointsView.vue @@ -3,22 +3,26 @@ import routeLinks from "@/router/routeLinks"; import isRouteSelected from "@/composables/isRouteSelected"; import { UserIndicator } from "@/views/throughputreport/endpoints/userIndicator"; import { userIndicatorMapper } from "@/views/throughputreport/endpoints/userIndicatorMapper"; -import { ref } from "vue"; +import { ref, type Component } from "vue"; import { useThroughputStore } from "@/stores/ThroughputStore"; import { storeToRefs } from "pinia"; +import LegendNServiceBusEndpoint from "./LegendNServiceBusEndpoint.vue"; +import LegendNServiceBusEndpointNoLongerInUse from "./LegendNServiceBusEndpointNoLongerInUse.vue"; +import LegendTransactionalSessionProcessorEndpoint from "./LegendTransactionalSessionProcessorEndpoint.vue"; +import LegendSendOnlyEndpoint from "./LegendSendOnlyEndpoint.vue"; +import LegendPlannedToDecommission from "./LegendPlannedToDecommission.vue"; +import LegendNotNServiceBusEndpoint from "./LegendNotNServiceBusEndpoint.vue"; const { isBrokerTransport } = storeToRefs(useThroughputStore()); const showLegend = ref(true); -const legendOptions = new Map([ - [UserIndicator.NServiceBusEndpoint, 'Known NServiceBus Endpoint'], - [UserIndicator.NServiceBusEndpointNoLongerInUse, "NServiceBus Endpoint that is no longer in use, usually this would have zero throughput"], - [ - UserIndicator.TransactionalSessionProcessorEndpoint, - 'A [processor endpoint](https://docs.particular.net/nservicebus/transactional-session/#remote-processor) that manages the outbox on behalf of send-only endpoints when using transactional session', - ], - [UserIndicator.SendOnlyEndpoint, "An endpoint that only sends messages and does not process any messages"], - [UserIndicator.PlannedToDecommission, "If the endpoint is planned to no longer be used in the next 30 days"], - [UserIndicator.NotNServiceBusEndpoint, "Not an NServiceBus Endpoint"], + +const legendOptions = new Map([ + [UserIndicator.NServiceBusEndpoint, LegendNServiceBusEndpoint], + [UserIndicator.NServiceBusEndpointNoLongerInUse, LegendNServiceBusEndpointNoLongerInUse], + [UserIndicator.TransactionalSessionProcessorEndpoint, LegendTransactionalSessionProcessorEndpoint], + [UserIndicator.SendOnlyEndpoint, LegendSendOnlyEndpoint], + [UserIndicator.PlannedToDecommission, LegendPlannedToDecommission], + [UserIndicator.NotNServiceBusEndpoint, LegendNotNServiceBusEndpoint], ]); function toggleOptionsLegendVisible() { @@ -36,8 +40,8 @@ function toggleOptionsLegendVisible() { {{ showLegend ? "Hide" : "Show" }} Endpoint Types meaning.

-
- {{ userIndicatorMapper.get(key) }} - . +
+ {{ userIndicatorMapper.get(key) }} - .
diff --git a/src/Frontend/src/views/throughputreport/LegendNServiceBusEndpoint.vue b/src/Frontend/src/views/throughputreport/LegendNServiceBusEndpoint.vue new file mode 100644 index 000000000..b7c05df42 --- /dev/null +++ b/src/Frontend/src/views/throughputreport/LegendNServiceBusEndpoint.vue @@ -0,0 +1,6 @@ + diff --git a/src/Frontend/src/views/throughputreport/LegendNServiceBusEndpointNoLongerInUse.vue b/src/Frontend/src/views/throughputreport/LegendNServiceBusEndpointNoLongerInUse.vue new file mode 100644 index 000000000..742f3211b --- /dev/null +++ b/src/Frontend/src/views/throughputreport/LegendNServiceBusEndpointNoLongerInUse.vue @@ -0,0 +1,3 @@ + diff --git a/src/Frontend/src/views/throughputreport/LegendNotNServiceBusEndpoint.vue b/src/Frontend/src/views/throughputreport/LegendNotNServiceBusEndpoint.vue new file mode 100644 index 000000000..4ec904329 --- /dev/null +++ b/src/Frontend/src/views/throughputreport/LegendNotNServiceBusEndpoint.vue @@ -0,0 +1,3 @@ + diff --git a/src/Frontend/src/views/throughputreport/LegendPlannedToDecommission.vue b/src/Frontend/src/views/throughputreport/LegendPlannedToDecommission.vue new file mode 100644 index 000000000..02393eb69 --- /dev/null +++ b/src/Frontend/src/views/throughputreport/LegendPlannedToDecommission.vue @@ -0,0 +1,3 @@ + diff --git a/src/Frontend/src/views/throughputreport/LegendSendOnlyEndpoint.vue b/src/Frontend/src/views/throughputreport/LegendSendOnlyEndpoint.vue new file mode 100644 index 000000000..ca9b139fb --- /dev/null +++ b/src/Frontend/src/views/throughputreport/LegendSendOnlyEndpoint.vue @@ -0,0 +1,3 @@ + diff --git a/src/Frontend/src/views/throughputreport/LegendTransactionalSessionProcessorEndpoint.vue b/src/Frontend/src/views/throughputreport/LegendTransactionalSessionProcessorEndpoint.vue new file mode 100644 index 000000000..702740e5b --- /dev/null +++ b/src/Frontend/src/views/throughputreport/LegendTransactionalSessionProcessorEndpoint.vue @@ -0,0 +1,7 @@ + From 3f4daafed5fc0b317dab7345a62ee74fb7078b4c Mon Sep 17 00:00:00 2001 From: Christian Date: Tue, 17 Jun 2025 06:13:09 -0600 Subject: [PATCH 5/5] Updated legends --- .../src/views/throughputreport/LegendSendOnlyEndpoint.vue | 2 +- .../LegendTransactionalSessionProcessorEndpoint.vue | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/Frontend/src/views/throughputreport/LegendSendOnlyEndpoint.vue b/src/Frontend/src/views/throughputreport/LegendSendOnlyEndpoint.vue index ca9b139fb..020ee7650 100644 --- a/src/Frontend/src/views/throughputreport/LegendSendOnlyEndpoint.vue +++ b/src/Frontend/src/views/throughputreport/LegendSendOnlyEndpoint.vue @@ -1,3 +1,3 @@ diff --git a/src/Frontend/src/views/throughputreport/LegendTransactionalSessionProcessorEndpoint.vue b/src/Frontend/src/views/throughputreport/LegendTransactionalSessionProcessorEndpoint.vue index 702740e5b..1aad0b0b6 100644 --- a/src/Frontend/src/views/throughputreport/LegendTransactionalSessionProcessorEndpoint.vue +++ b/src/Frontend/src/views/throughputreport/LegendTransactionalSessionProcessorEndpoint.vue @@ -1,7 +1,3 @@