Legacy docs review

bording · bording · commit 003a1f49791b · 2025-03-18T14:05:34.000-04:00
diff --git a/persistence/azure-table/scripting.md b/persistence/azure-table/scripting.md
@@ -2,7 +2,7 @@
 title: Azure Table Persistence Scripts
 summary: Collection of scripts for managing Azure Table Persistence
 component: ASP
-reviewed: 2022-12-16
+reviewed: 2025-03-18
 related:
  - nservicebus/operations
 redirects:
diff --git a/persistence/sql/saga-concurrency.md b/persistence/sql/saga-concurrency.md
@@ -1,7 +1,7 @@
 ---
 title: SQL Persistence saga concurrency
 component: SqlPersistence
-reviewed: 2022-11-24
+reviewed: 2025-03-18
 related:
  - nservicebus/sagas/concurrency
 redirects:
@@ -10,7 +10,7 @@ redirects:
 
 ## Default behavior
 
-When simultaneously handling messages, conflicts may occur. See below for examples. _[Saga concurrency](/nservicebus/sagas/concurrency.md)_ explains how these conflicts are handled, and contains guidance for high-load scenarios.
+When simultaneously handling messages, conflicts may occur. See below for examples. [Saga concurrency](/nservicebus/sagas/concurrency.md) explains how these conflicts are handled and contains guidance for high-load scenarios.
 
 ### Starting a saga
 
@@ -43,4 +43,14 @@ values
 
 ### Updating or deleting saga data
 
-partial: updating-deleting
+Starting in version 4.1.1, conflicts cannot occur because the persistence uses pessimistic locking. Pessimistic locking is achieved by performing a `SELECT ... FOR UPDATE` or its dialect-specific equivalent.
+
+Up to and including version 4.1.0, SQL persistence uses [optimistic concurrency control](https://en.wikipedia.org/wiki/Optimistic_concurrency_control) when updating or deleting saga data.
+
+Example exception:
+
+```
+System.Exception: Optimistic concurrency violation when trying to complete saga OrderSaga 699d0b1a-e2bf-49fd-8f26-aadf01009eaf. Expected version 4.
+```
+
+include: saga-concurrency
diff --git a/persistence/sql/saga-concurrency_updating-deleting_sqlpersistence_[4,).partial.md b/persistence/sql/saga-concurrency_updating-deleting_sqlpersistence_[4,).partial.md
diff --git a/samples/web/blazor-server-application/Core_8/Server/CommandMessageHandler.cs b/samples/web/blazor-server-application/Core_8/Server/CommandMessageHandler.cs
@@ -1,18 +1,19 @@
-﻿using NServiceBus;
+﻿using System.Threading.Tasks;
+using NServiceBus;
 using NServiceBus.Logging;
-using System.Threading.Tasks;
 
 #region Handler
 
-public class CommandMessageHandler :
-    IHandleMessages<Command>
+public class CommandMessageHandler : IHandleMessages<Command>
 {
-    static ILog log = LogManager.GetLogger<CommandMessageHandler>();
+    static readonly ILog log = LogManager.GetLogger<CommandMessageHandler>();
 
     public Task Handle(Command message, IMessageHandlerContext context)
     {
         log.Info("Hello from CommandMessageHandler");
+
         Task reply;
+
         if (message.Id % 2 == 0)
         {
             reply = context.Reply(ErrorCodes.Fail);
@@ -21,6 +22,7 @@ public Task Handle(Command message, IMessageHandlerContext context)
         {
             reply = context.Reply(ErrorCodes.None);
         }
+
         return reply;
     }
 }
diff --git a/samples/web/blazor-server-application/Core_8/Server/Program.cs b/samples/web/blazor-server-application/Core_8/Server/Program.cs
@@ -1,12 +1,13 @@
-using NServiceBus;
 using System;
 using System.Threading.Tasks;
+using NServiceBus;
 
 class Program
 {
     public static async Task Main()
     {
-        var endpointConfiguration = new EndpointConfiguration(Console.Title = "BlazorServer");
+        Console.Title = "BlazorServer";
+        var endpointConfiguration = new EndpointConfiguration("Samples.Blazor.Server");
         endpointConfiguration.EnableCallbacks(makesRequests: false);
         endpointConfiguration.UseSerialization<SystemJsonSerializer>();
         endpointConfiguration.UseTransport(new LearningTransport());
diff --git a/samples/web/blazor-server-application/Core_8/Server/Server.csproj b/samples/web/blazor-server-application/Core_8/Server/Server.csproj
@@ -1,18 +1,17 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <OutputType>Exe</OutputType>
     <TargetFrameworks>net9.0;net8.0;net6.0</TargetFrameworks>
+    <OutputType>Exe</OutputType>
     <LangVersion>10.0</LangVersion>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="NServiceBus" Version="8.*" />
-    <PackageReference Include="NServiceBus.Callbacks" Version="4.*" />
+    <ProjectReference Include="..\Shared\Shared.csproj" />
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\Shared\Shared.csproj" />
+    <PackageReference Include="NServiceBus.Callbacks" Version="4.*" />
   </ItemGroup>
 
 </Project>
diff --git a/samples/web/blazor-server-application/Core_8/WebApp/WebApp.csproj b/samples/web/blazor-server-application/Core_8/WebApp/WebApp.csproj
@@ -7,13 +7,12 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="NServiceBus" Version="8.*" />
-    <PackageReference Include="NServiceBus.Callbacks" Version="4.*" />
-    <PackageReference Include="NServiceBus.Extensions.Hosting" Version="2.*" />
+    <ProjectReference Include="..\Shared\Shared.csproj" />
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\Shared\Shared.csproj" />
+    <PackageReference Include="NServiceBus.Callbacks" Version="4.*" />
+    <PackageReference Include="NServiceBus.Extensions.Hosting" Version="2.*" />
   </ItemGroup>
 
 </Project>
diff --git a/samples/web/blazor-server-application/Core_9/Server/CommandMessageHandler.cs b/samples/web/blazor-server-application/Core_9/Server/CommandMessageHandler.cs
@@ -1,18 +1,19 @@
-﻿using NServiceBus;
+﻿using System.Threading.Tasks;
+using NServiceBus;
 using NServiceBus.Logging;
-using System.Threading.Tasks;
 
 #region Handler
 
-public class CommandMessageHandler :
-    IHandleMessages<Command>
+public class CommandMessageHandler : IHandleMessages<Command>
 {
-    static ILog log = LogManager.GetLogger<CommandMessageHandler>();
+    static readonly ILog log = LogManager.GetLogger<CommandMessageHandler>();
 
     public Task Handle(Command message, IMessageHandlerContext context)
     {
         log.Info("Hello from CommandMessageHandler");
+
         Task reply;
+
         if (message.Id % 2 == 0)
         {
             reply = context.Reply(ErrorCodes.Fail);
@@ -21,6 +22,7 @@ public Task Handle(Command message, IMessageHandlerContext context)
         {
             reply = context.Reply(ErrorCodes.None);
         }
+
         return reply;
     }
 }
diff --git a/samples/web/blazor-server-application/Core_9/Server/Program.cs b/samples/web/blazor-server-application/Core_9/Server/Program.cs
@@ -1,12 +1,13 @@
-using NServiceBus;
 using System;
 using System.Threading.Tasks;
+using NServiceBus;
 
 class Program
 {
     public static async Task Main()
     {
-        var endpointConfiguration = new EndpointConfiguration(Console.Title = "BlazorServer");
+        Console.Title = "BlazorServer";
+        var endpointConfiguration = new EndpointConfiguration("Samples.Blazor.Server");
         endpointConfiguration.EnableCallbacks(makesRequests: false);
         endpointConfiguration.UseSerialization<SystemJsonSerializer>();
         endpointConfiguration.UseTransport(new LearningTransport());
diff --git a/samples/web/blazor-server-application/Core_9/Server/Server.csproj b/samples/web/blazor-server-application/Core_9/Server/Server.csproj
@@ -1,18 +1,17 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <OutputType>Exe</OutputType>
     <TargetFrameworks>net9.0;net8.0</TargetFrameworks>
+    <OutputType>Exe</OutputType>
     <LangVersion>12.0</LangVersion>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="NServiceBus" Version="9.*" />
-    <PackageReference Include="NServiceBus.Callbacks" Version="5.*" />
+    <ProjectReference Include="..\Shared\Shared.csproj" />
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\Shared\Shared.csproj" />
+    <PackageReference Include="NServiceBus.Callbacks" Version="5.*" />
   </ItemGroup>
 
 </Project>
diff --git a/samples/web/blazor-server-application/Core_9/WebApp/WebApp.csproj b/samples/web/blazor-server-application/Core_9/WebApp/WebApp.csproj
@@ -8,13 +8,12 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="NServiceBus" Version="9.*" />
-    <PackageReference Include="NServiceBus.Callbacks" Version="5.*" />
-    <PackageReference Include="NServiceBus.Extensions.Hosting" Version="3.*" />
+    <ProjectReference Include="..\Shared\Shared.csproj" />
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\Shared\Shared.csproj" />
+    <PackageReference Include="NServiceBus.Callbacks" Version="5.*" />
+    <PackageReference Include="NServiceBus.Extensions.Hosting" Version="3.*" />
   </ItemGroup>
 
 </Project>
diff --git a/samples/web/blazor-server-application/sample.md b/samples/web/blazor-server-application/sample.md
@@ -1,7 +1,7 @@
 ---
 title: Using NServiceBus in a Blazor server application
 summary: NServiceBus sample that demonstrates how to send messages with a Blazor server application
-reviewed: 2022-12-08
+reviewed: 2025-03-18
 component: Core
 related:
 - nservicebus/hosting
@@ -13,15 +13,15 @@ This sample shows how to send messages from a Blazor server application to an NS
 
 ## Run the sample
 
-When running the solution a new browser window/tab opens, as well as a console application.
+When running the solution, a console application and new browser window/tab opens.
 
 Enter the number "1" into the text box in the browser and click "Go". Notice the result "None" appears, as shown:
 
 ![Blazor server sample running](blazor-server-running.png "Blazor server sample running")
 
 Changing the number in the text box from even to odd numbers changes the result in the Server console.
 
-The web page renders synchronously; from the user's perspective, the interaction is synchronous and blocking, even though behind the scenes NServiceBus is implementing an asynchronous send-reply pattern using the [callbacks package](/nservicebus/messaging/callbacks.md).
+The web page renders synchronously. From the user's perspective, the interaction is synchronous and blocking, even though behind the scenes NServiceBus is implementing an asynchronous send-reply pattern using the [callbacks package](/nservicebus/messaging/callbacks.md).
 
 ## Configuration
 
@@ -39,7 +39,7 @@ Open `Index.razor` in `WebApp` to see the `HandleValidSubmit` method:
 
 snippet: ActionHandling
 
-The first line of code parses the text passed in by the user. The second line creates a new NServiceBus message of the type `Command`, and initializes its `Id` property with the value from the text box.
+The first line of code parses the text passed in by the user. The second line creates a new NServiceBus message of the type `Command` and initializes its `Id` property with the value from the text box.
 
 Open the class definition for the `Command` type in the `Shared` project:
 
@@ -53,14 +53,14 @@ In the `Server` project, find this code in the `CommandMessageHandler` class:
 
 snippet: Handler
 
-This class implements the NServiceBus interface `IHandleMessages<T>` where `T` is the specific message type being handled; in this case, the `Command` message. NServiceBus manages classes that implement this interface. When a message arrives in the input queue, it is deserialized and then, based on its type, NServiceBus instantiates the relevant message handler classes and calls their `Handle` method, passing in the message object.
+This class implements the NServiceBus interface `IHandleMessages<T>` where `T` is the specific message type being handled, which in this case is the `Command` message. NServiceBus manages classes that implement this interface. When a message arrives in the input queue, it is deserialized, and then, based on its type, NServiceBus instantiates the relevant message handler classes and calls their `Handle` method, passing in the message object.
 
-In the method body notice the response being returned to the originating endpoint. This will result in a message being added to the input queue for `MyWebClient` endpoint.
+In the method body, notice the response being returned to the originating endpoint. This will result in a message being added to the input queue for `MyWebClient` endpoint.
 
 ## Handling the response
 
 When the response arrives back at `WebApp`, NServiceBus invokes the callback that was registered when the request was sent.
 
-The `messageSession.Request` method takes the callback code and tells NServiceBus to invoke it when the response is received. There are several overloads of this method; the code above accepts a generic `Enum` parameter, effectively casting the return code from the server to the given enumeration type.
+The `messageSession.Request` method takes the callback code and tells NServiceBus to invoke it when the response is received. There are several overloads of this method. The code above accepts a generic `Enum` parameter, effectively casting the return code from the server to the given enumeration type.
 
 Finally, the code updates the `Text` property of a label on the web page, setting it to the string that represents the enumeration value: sometimes `None`, sometimes `Fail`.
diff --git a/security-advisories/servicepulse-directorytraversal.md b/security-advisories/servicepulse-directorytraversal.md
@@ -1,10 +1,10 @@
 ---
 title: Security Advisory 2020-03-11
 summary: ServicePulse directory traversal vulnerability
-reviewed: 2022-12-02
+reviewed: 2025-03-18
 ---
 
-This advisory discloses a security vulnerability that has been found in [ServicePulse](/servicepulse/) and fixed in a recently released version.
+This advisory discloses a security vulnerability that has been found in [ServicePulse](/servicepulse/) and fixed.
 
  * ServicePulse versions 1.24 or 1.24.1 should be upgraded to the latest version of ServicePulse to fix this vulnerability.
  * Users using [IIS to host ServicePulse](/servicepulse/install-servicepulse-in-iis.md) are not affected
@@ -39,7 +39,6 @@ This vulnerability can be fixed by upgrading ServicePulse to the latest version.
 
 [Download](https://particular.net/start-servicepulse-download) and run the latest version of the ServicePulse installer, following the online [installation instructions](/servicepulse/installation.md#installation)
 
-
 ### Contact info
 
 If there are any questions or concerns regarding this advisory, contact [security@particular.net](mailto://security@particular.net).

Original file line number	Diff line number	Diff line change
`@@ -1,18 +1,19 @@`
`1`		`-using NServiceBus;`
	`1`	`+using System.Threading.Tasks;`
	`2`	`+using NServiceBus;`
`2`	`3`	`using NServiceBus.Logging;`
`3`		`-using System.Threading.Tasks;`
`4`	`4`
`5`	`5`	`#region Handler`
`6`	`6`
`7`		`-public class CommandMessageHandler :`
`8`		`- IHandleMessages<Command>`
	`7`	`+public class CommandMessageHandler : IHandleMessages<Command>`
`9`	`8`	`{`
`10`		`- static ILog log = LogManager.GetLogger<CommandMessageHandler>();`
	`9`	`+ static readonly ILog log = LogManager.GetLogger<CommandMessageHandler>();`
`11`	`10`
`12`	`11`	`public Task Handle(Command message, IMessageHandlerContext context)`
`13`	`12`	`{`
`14`	`13`	`log.Info("Hello from CommandMessageHandler");`
	`14`	`+`
`15`	`15`	`Task reply;`
	`16`	`+`
`16`	`17`	`if (message.Id % 2 == 0)`
`17`	`18`	`{`
`18`	`19`	`reply = context.Reply(ErrorCodes.Fail);`
`@@ -21,6 +22,7 @@ public Task Handle(Command message, IMessageHandlerContext context)`
`21`	`22`	`{`
`22`	`23`	`reply = context.Reply(ErrorCodes.None);`
`23`	`24`	`}`
	`25`	`+`
`24`	`26`	`return reply;`
`25`	`27`	`}`
`26`	`28`	`}`