Update metrics related samples to NServiceBus 9.1 (#6777)

* Remove not needed using directive

* Use a wild card in the source name to include all possible meters

* Adjust the OTel AppInsights sample for 9.1

* Adjust the OTel Prometheus and Grafana sample for 9.1

* Mark as reviewed

* update the screenshots

* Add new metrics to the sample dashboard

* Add the shim as a dedicated sample

* fix links and add retries

* remove shim from app insights sample

* remove shim from grafana sample

* readd shim to v9

* link to the shim from the docs

* remove .net7

* Use new form of note

* address code issues

---------

Co-authored-by: Laila Bougria <[email protected]>
Co-authored-by: SzymonPobiega <[email protected]>

Author: 3 people

nservicebus/operations/opentelemetry_metrics_core_[8,9.1).partial.md

@@ -13,4 +13,16 @@ snippet: opentelemetry-enablemeters
 - `nservicebus.messaging.fetches` - Total number of messages fetched from the queue by the endpoint
 - `nservicebus.messaging.failures` - Total number of messages processed unsuccessfully by the endpoint
 
-See the [OpenTelemetry samples](/samples/open-telemetry/) for instructions on how to send metric information to different tools.
+See the [OpenTelemetry samples](/samples/open-telemetry/) for instructions on how to send metric information to different tools.
+
+### Additional metrics
+
+The NServiceBus.Metrics package provides additional metrics that are not yet exposed via OpenTelemetry.
+
+These metrics include:
+- Critical time
+- Processing time
+- Handler time
+- Retries
+
+To expose these metrics via OpenTelemetry, a shim can be used. The [OpenTelemetry shim sample](/samples/open-telemetry/metrics-shim/) demonstrates how to set up a shim that exposes NServiceBus.Metrics in an OpenTelemetry format and exports them to Azure Application Insights.

samples/open-telemetry/application-insights/Core_9/Endpoint/MetricsShim/Extensions.cs

@@ -26,7 +26,7 @@
 
 var traceProvider = Sdk.CreateTracerProviderBuilder()
     .SetResourceBuilder(resourceBuilder)
-    .AddSource("NServiceBus.Core")
+    .AddSource("NServiceBus.Core*")
     .AddAzureMonitorTraceExporter(o => o.ConnectionString = appInsightsConnectionString)
     .AddConsoleExporter()
     .Build();
@@ -37,7 +37,7 @@
 
 var meterProvider = Sdk.CreateMeterProviderBuilder()
     .SetResourceBuilder(resourceBuilder)
-    .AddMeter("NServiceBus.Core")
+    .AddMeter("NServiceBus.Core*")
     .AddAzureMonitorMetricExporter(o => o.ConnectionString = appInsightsConnectionString)
     .AddConsoleExporter()
     .Build();
@@ -72,4 +72,4 @@
     await endpointInstance.Stop(cancellation.Token);
     traceProvider?.Dispose();
     meterProvider?.Dispose();
-}
+}

samples/open-telemetry/application-insights/Core_9/Endpoint/Program.cs

@@ -1,7 +1,7 @@
 ---
 title: Monitoring NServiceBus endpoints with Application Insights
 summary: How to configure NServiceBus to export OpenTelemetry traces and meters to Application Insights
-reviewed: 2024-01-17
+reviewed: 2024-07-26
 component: Core
 previewImage: trace-timeline.png
 related:
@@ -58,19 +58,19 @@ To monitor the rate of messages being fetched from the queuing system, processed
 
 To monitor [recoverability](/nservicebus/recoverability/) metrics use:
 
-- `nservicebus.recoverability.immediate_retries`
-- `nservicebus.recoverability.delayed_retries`
-- `nservicebus.recoverability.retries`
-- `nservicebus.recoverability.sent_to_error`
+- `nservicebus.recoverability.immediate`
+- `nservicebus.recoverability.delayed`
+- `nservicebus.recoverability.error`
 
 ![Graph showing recoverability metrics in Application Insights](metrics-recoverability.png)
 
-#### Critical time and processing time
+#### Handler time, critical time, and processing time
 
-To monitor [critical time and processing time](/monitoring/metrics/definitions.md#metrics-captured) (in milliseconds) for successfully processed messages use:
+To monitor [handler time, processing time, and critical time](/monitoring/metrics/definitions.md#metrics-captured) (in seconds) for successfully processed messages use:
 
-- `nservicebus.messaging.processingtime`
-- `nservicebus.messaging.criticaltime`
+- `nservicebus.messaging.handler_time`
+- `nservicebus.messaging.processing_time`
+- `nservicebus.messaging.critical_time`
 
 ![Graph showing processing time and critical time metrics in Application Insights](metrics-timing.png)
 
@@ -92,11 +92,3 @@ The endpoint configures an OpenTelemetry meter provider that includes the `NServ
 
 snippet: enable-meters
 
-#### Critical time and processing time
-
-[Critical time and processing time captured by the metrics package](/monitoring/metrics/definitions.md#metrics-captured) are not yet supported in OpenTelemetry's native format (using System.Diagnostics), so a shim is required to expose them as OpenTelemetry metrics.
-
-snippet: metrics-shim
-
-> [!NOTE]
-> The shim passes `QueueName` as a custom dimension which allows filtering the graphs in Application Insights. Multi-dimensional metrics are not enabled by default. Check [the Azure Monitor documentation](https://docs.microsoft.com/en-us/azure/azure-monitor/app/get-metric#enable-multi-dimensional-metrics) for instructions on how to enable this feature.

samples/open-telemetry/application-insights/metrics-counters.png

@@ -17,7 +17,7 @@ public static async Task Main()
 
         var tracerProviderBuilder = Sdk.CreateTracerProviderBuilder()
             .SetResourceBuilder(resourceBuilder)
-            .AddSource("NServiceBus.Core")
+            .AddSource("NServiceBus.Core*")
             .AddSource(CustomActivitySources.Name)
             .AddProcessor(new NetHostProcessor())
             .AddConsoleExporter();

samples/open-telemetry/application-insights/metrics-recoverability.png

@@ -1,7 +1,7 @@
 ---
 title: Customizing OpenTelemetry tracing
 summary: Demonstrates how to add data to existing OpenTelemetry traces
-reviewed: 2022-07-15
+reviewed: 2024-07-26
 component: Core
 related:
 - nservicebus/operations/opentelemetry