Skip to content

Commit 48f4f57

Browse files
cquirosjcquirosj
authored
Migrate NUnit assertions to the constraint model in preparation of the NUnit 4 upgrade (#6810)
* Add Nunit.Analyzer to test projects * Autoformat of test projects for NUnit2002 * Autoformat of test projects for NUnit2003 * Autoformat of test projects for NUnit2005 * Autoformat of test projects for NUnit2010 * Autoformat of test projects for NUnit2011 * Autoformat of test projects for NUnit2038 * Autoformat of test projects for NUnit2045 * Autoformat of test projects for NUnit2046 * Autoformat of test projects for NUnit2048
1 parent 26f99db commit 48f4f57

File tree

85 files changed

+325
-206
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

85 files changed

+325
-206
lines changed

‎Snippets/Core/Core_7/Core_7.csproj‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
<PackageReference Include="NServiceBus.Metrics.ServiceControl" Version="3.*" />
1414
<PackageReference Include="Newtonsoft.Json" Version="13.*" />
1515
<PackageReference Include="NUnit" Version="3.*" />
16+
<PackageReference Include="NUnit.Analyzers" Version="4.3.0" />
1617
<PackageReference Include="System.Reactive" Version="3.*" />
1718
<Reference Include="System.ServiceProcess" />
1819
<Reference Include="System.Web" />

‎Snippets/Core/Core_8.1/Core_8.1.csproj‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
<PackageReference Include="NServiceBus.Metrics.ServiceControl" Version="4.*" />
1414
<PackageReference Include="Newtonsoft.Json" Version="13.*" />
1515
<PackageReference Include="NUnit" Version="3.*" />
16+
<PackageReference Include="NUnit.Analyzers" Version="4.3.0" />
1617
<PackageReference Include="NUnit3TestAdapter" Version="3.17.0" />
1718
<PackageReference Include="OpenTelemetry" Version="1.3.0" />
1819
<Reference Include="System.ServiceProcess" />

‎Snippets/Core/Core_8/Core_8.csproj‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.*" />
1515
<PackageReference Include="Newtonsoft.Json" Version="13.*" />
1616
<PackageReference Include="NUnit" Version="3.*" />
17+
<PackageReference Include="NUnit.Analyzers" Version="4.3.0" />
1718
<PackageReference Include="NUnit3TestAdapter" Version="3.17.0" />
1819
<PackageReference Include="OpenTelemetry" Version="1.*" />
1920
<Reference Include="System.ServiceProcess" />

‎Snippets/Core/Core_9.1/Core_9.1.csproj‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
<PackageReference Include="NServiceBus.Metrics.ServiceControl" Version="5.*" />
1717
<PackageReference Include="Newtonsoft.Json" Version="13.*" />
1818
<PackageReference Include="NUnit" Version="3.*" />
19+
<PackageReference Include="NUnit.Analyzers" Version="4.3.0" />
1920
<PackageReference Include="NUnit3TestAdapter" Version="3.17.0" />
2021
<PackageReference Include="OpenTelemetry" Version="1.3.0" />
2122
</ItemGroup>

‎Snippets/Core/Core_9/Core_9.csproj‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.*" />
1818
<PackageReference Include="Newtonsoft.Json" Version="13.*" />
1919
<PackageReference Include="NUnit" Version="3.*" />
20+
<PackageReference Include="NUnit.Analyzers" Version="4.3.0" />
2021
<PackageReference Include="NUnit3TestAdapter" Version="3.17.0" />
2122
<PackageReference Include="OpenTelemetry" Version="1.*" />
2223
</ItemGroup>

‎Snippets/MsmqTransport/MsmqTransport_All/MsmqTransport_All.csproj‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<PackageReference Include="Mono.Cecil" Version="0.*" />
88
<PackageReference Include="NServiceBus" Version="5.*" />
99
<PackageReference Include="NUnit" Version="3.*" />
10+
<PackageReference Include="NUnit.Analyzers" Version="4.3.0" />
1011
<PackageReference Include="System.Management.Automation" Version="6.1.*" />
1112
<Reference Include="System.Messaging" />
1213
<Reference Include="System.Transactions" />

‎Snippets/MsmqTransport/MsmqTransport_All/NativeSend/Tests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public MessageHandler(State state)
7272

7373
public void Handle(MessageToSend message)
7474
{
75-
Assert.AreEqual("Value", message.Property);
75+
Assert.That(message.Property, Is.EqualTo("Value"));
7676
state.ResetEvent.Set();
7777
}
7878
}

‎Snippets/MsmqTransport/MsmqTransport_All/QueueCreation/Tests.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,17 @@ public void CreateQueuesForEndpoint()
2626
endpointName: "myendpoint",
2727
account: Environment.UserName);
2828

29-
Assert.IsTrue(MessageQueue.Exists(@".\private$\myendpoint"));
29+
Assert.That(MessageQueue.Exists(@".\private$\myendpoint"), Is.True);
3030

3131
QueueCreationUtils.CreateQueue(
3232
queueName: "myerror",
3333
account: Environment.UserName);
34-
Assert.IsTrue(MessageQueue.Exists(@".\private$\myerror"));
34+
Assert.That(MessageQueue.Exists(@".\private$\myerror"), Is.True);
3535

3636
QueueCreationUtils.CreateQueue(
3737
queueName: "myaudit",
3838
account: Environment.UserName);
39-
Assert.IsTrue(MessageQueue.Exists(@".\private$\myaudit"));
39+
Assert.That(MessageQueue.Exists(@".\private$\myaudit"), Is.True);
4040
}
4141
}
4242
}

‎Snippets/MsmqTransport/MsmqTransport_All/QueueDeletion/Tests.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,19 @@ public void DeleteQueuesForEndpoint()
2323
endpointName: "myendpoint",
2424
account: Environment.UserName);
2525
DeleteEndpointQueues.DeleteQueuesForEndpoint("myendpoint");
26-
Assert.IsFalse(MessageQueue.Exists(@".\private$\myendpoint"));
26+
Assert.That(MessageQueue.Exists(@".\private$\myendpoint"), Is.False);
2727

2828
QueueCreationUtils.CreateQueue(
2929
queueName: "myerror",
3030
account: Environment.UserName);
3131
QueueDeletionUtils.DeleteQueue(queueName: "myerror");
32-
Assert.IsFalse(MessageQueue.Exists(@".\private$\myerror"));
32+
Assert.That(MessageQueue.Exists(@".\private$\myerror"), Is.False);
3333

3434
QueueCreationUtils.CreateQueue(
3535
queueName: "myaudit",
3636
account: Environment.UserName);
3737
QueueDeletionUtils.DeleteQueue(queueName: "myaudit");
38-
Assert.IsFalse(MessageQueue.Exists(@".\private$\myaudit"));
38+
Assert.That(MessageQueue.Exists(@".\private$\myaudit"), Is.False);
3939
}
4040
}
4141

‎Snippets/PostgreSqlTransport/PostgreSqlTransport_8/PostgreSqlTransport_8.csproj‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<PackageReference Include="Azure.Identity" Version="1.12.0" />
99
<PackageReference Include="NServiceBus.Transport.PostgreSql" Version="8.*" />
1010
<PackageReference Include="NUnit" Version="3.*" />
11+
<PackageReference Include="NUnit.Analyzers" Version="4.3.0" />
1112
<PackageReference Include="NUnit3TestAdapter" Version="4.*" />
1213
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.*" />
1314
</ItemGroup>

0 commit comments

Comments
 (0)