ADD: proper sound handling as requested by PR 12 from zverinapavel

Author: PascalCorpsman

server/uatomic_server.pas

@@ -832,7 +832,7 @@
   a: Array Of Integer;
   b: Boolean;
 Begin
-  log('TServer.HandleSwitchToMapProperties', llTrace);
+  log(format('TServer.HandleSwitchToMapProperties (UID=%d)', [UID]), llInfo);
   aicnt := 0;
   pcnt := 0;
   t1 := 0;
@@ -1214,16 +1214,79 @@
 Procedure TServer.HandlePlaySoundEffect(PlayerIndex: integer;
   Effect: TSoundEffect);
 Var
-  m: TMemoryStream;
+  m, m2: TMemoryStream;
+  targetUID: Integer;
+  i: Integer;
+  playerUID: Integer;
 Begin
   log('TServer.HandlePlaySoundEffect', llTrace);
+  // Check if player is valid
+  If (PlayerIndex < 0) Or (PlayerIndex > high(fPLayer)) Then Begin
+    log('Invalid PlayerIndex: ' + inttostr(PlayerIndex), llError);
+    LogLeave;
+    exit;
+  End;
+  
+  playerUID := fPLayer[PlayerIndex].UID;
+  
+  // Skip inactive slots (UID = NoPlayer = 0)
+  If playerUID = NoPlayer Then Begin
+    log('Skipping sound for inactive player slot: ' + inttostr(PlayerIndex), llTrace);
+    LogLeave;
+    exit;
+  End;
+  
   m := TMemoryStream.Create;
   m.Write(Effect, sizeof(Effect));
-  If Effect = seOtherPlayerDied Then Begin
-    SendChunk(miPlaySoundEffekt, m, -fPLayer[PlayerIndex].UID);
+  
+  // Handle AI players (UID = AIPlayer = -1) - send sounds to all other players
+  If playerUID = AIPlayer Then Begin
+    // For AI players, send sounds to all connected players (broadcast)
+    // Use negative UID to indicate broadcast to all except sender (but sender is AI, so send to all)
+    If GetActivePlayerCount() > 0 Then Begin
+      // Send to all connected players (UID > 0)
+      targetUID := 0; // 0 means broadcast to all connected players
+      // Actually, we need to send to each connected player individually
+      // because SendChunk with negative UID excludes the sender, but we want to include all
+      For i := 0 To high(fPLayer) Do Begin
+        If fPLayer[i].UID > 0 Then Begin
+          // Create a new stream for each player
+          m2 := TMemoryStream.Create;
+          m2.Write(Effect, sizeof(Effect));
+          SendChunk(miPlaySoundEffekt, m2, fPLayer[i].UID);
+        End;
+      End;
+      m.Free; // Free the original stream
+    End
+    Else Begin
+      log('Skipping AI sound - no connected players', llInfo);
+      m.Free;
+    End;
+  End
+  Else If playerUID > 0 Then Begin
+    // Normal player (UID > 0)
+    If Effect = seOtherPlayerDied Then Begin
+      // Send to all players except this one (broadcast with negative UID)
+      // Only send if there are at least 2 active players
+      If GetActivePlayerCount() > 1 Then Begin
+        targetUID := -playerUID;
+        SendChunk(miPlaySoundEffekt, m, targetUID);
+      End
+      Else Begin
+        log('Skipping seOtherPlayerDied sound - only one player connected', llInfo);
+        m.Free;
+      End;
+    End
+    Else Begin
+      // Send to this specific player
+      targetUID := playerUID;
+      SendChunk(miPlaySoundEffekt, m, targetUID);
+    End;
   End
   Else Begin
-    SendChunk(miPlaySoundEffekt, m, fPLayer[PlayerIndex].UID);
+    // Unknown UID value
+    log('Unknown player UID: ' + inttostr(playerUID) + ' for player index: ' + inttostr(PlayerIndex), llWarning);
+    m.Free;
   End;
   LogLeave;
 End;
@@ -1372,7 +1435,6 @@
   j, i: Integer;
   k: TKeySet;
 Begin
-  log('TServer.RefreshAllPlayerStats', llTrace);
   m := TMemoryStream.Create;
   // Einfügen aller Spielerinformationen, dass diese übernommen werden können (z.B. nach Load Game)
   j := length(fPLayer);
@@ -1389,7 +1451,6 @@
     m.WriteAnsiString(fPLayer[i].UserName);
   End;
   SendChunk(miRefreshPlayerStats, m, UID);
-  LogLeave;
 End;
 
 Procedure TServer.PlayerLeaves(PlayerUid: integer);
@@ -2012,10 +2073,10 @@
     exit;
   End;
   If AiInit() Then Begin
-    log(format('Ai "%s" loaded..', [AiVersion()]), llInfo);
+    logshow(format('Ai "%s" loaded successfully!', [AiVersion()]), llInfo);
   End
   Else Begin
-    log('Failure on Ai load.', llInfo);
+    logshow('Failure on Ai load (AiInit returned false).', llError);
     UnLoadAiLib;
   End;
   If fGameState = gsPlaying Then Begin
@@ -2096,7 +2157,10 @@
         // Egal, welcher Speedup, das Spiel wird mit konstanter Rate Aktualisiert
         If fLastClientUpdateTimestamp + UpdateRate <= n Then Begin
           fLastClientUpdateTimestamp := n; // fLastClientUpdateTimestamp + UpdateRate; Verhindern von oben beschriebener Situation
-          UpdateAllClients;
+          // Only send updates if there are connected clients
+          If GetActivePlayerCount() > 0 Then Begin
+            UpdateAllClients;
+          End;
         End;
       End;
     End;