Try to fix issue with IP address look-up

Author: PascalMinder

.golangci.yml

@@ -1,21 +1,19 @@
 # inspired by: https://github.com/golangci/golangci-lint/blob/master/.golangci.yml
 
 run:
-  go: "1.18"
+  go: "1.19"
 
 linters-settings:
   # dupl:
   #   threshold: 100
   funlen:
     lines: 100
     statements: 50
-  golint:
-    min-confidence: 0
   lll:
     line-length: 125
   goconst:
     min-len: 2
-    min-occurences: 2
+    min-occurrences: 3
   misspell:
     locale: US
 
@@ -26,14 +24,12 @@ linters:
     # - bidichk
     # - bodyclose
     # - contextcheck
-    - deadcode
     - depguard
     - dogsled
     # - dupl
     # - durationcheck
     - errcheck
     # - errname
-    - exportloopref
     - funlen
     - gochecknoinits
     - goconst
@@ -60,15 +56,13 @@ linters:
     # - predeclared
     # - revive
     - staticcheck
-    - structcheck
     - stylecheck
     # - tagliatelle
     # - thelper
     - typecheck
     - unconvert
     - unparam
     - unused
-    - varcheck
     # - wastedassign
     - whitespace
 

geoblock_test.go

@@ -207,11 +207,28 @@ func TestMultipleIpAddressesReverse(t *testing.T) {
 	assertStatusCode(t, recorder.Result(), http.StatusForbidden)
 }
 
+func createMockAPIServer(t *testing.T, expectedRequestIP string, response []byte) *httptest.Server {
+	return httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
+		t.Logf("Intercepted request: %s %s", req.Method, req.URL.String())
+		t.Logf("Headers: %v", req.Header)
+
+		if !strings.Contains(req.URL.String(), expectedRequestIP) {
+			t.Errorf("Unexpected IP: %s", req.URL.String()[1:])
+		}
+		rw.WriteHeader(http.StatusOK)
+		_, _ = rw.Write(response)
+	}))
+}
+
 func TestMultipleIpAddressesProxy(t *testing.T) {
+	mockServer := createMockAPIServer(t, caExampleIP, []byte(`CA`))
+	defer mockServer.Close()
+
 	cfg := createTesterConfig()
 
 	cfg.Countries = append(cfg.Countries, "CA")
 	cfg.XForwardedForReverseProxy = true
+	cfg.API = mockServer.URL + "/{ip}"
 
 	ctx := context.Background()
 	next := http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {})
@@ -236,10 +253,14 @@ func TestMultipleIpAddressesProxy(t *testing.T) {
 }
 
 func TestMultipleIpAddressesProxyReverse(t *testing.T) {
+	mockServer := createMockAPIServer(t, chExampleIP, []byte(`CH`))
+	defer mockServer.Close()
+
 	cfg := createTesterConfig()
 
 	cfg.Countries = append(cfg.Countries, "CA")
 	cfg.XForwardedForReverseProxy = true
+	cfg.API = mockServer.URL + "/{ip}"
 
 	ctx := context.Background()
 	next := http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {})