chore: golangci-lint update to v2.8.0

Author: jentfoo

.github/workflows/test.yml

@@ -22,7 +22,7 @@ jobs:
 
       - name: Set up golangci-lint
         run: |
-          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/v2.7.1/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.7.1
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/v2.8.0/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.8.0
 
       - name: Run lint check
         run: make lint

lens/benchmark_test.go

@@ -132,7 +132,11 @@ func BenchmarkASTClientServer(b *testing.B) {
 	fSlice := []float64{-128.128, -128, -64.64, -64, -32.32, -32, -16.16, -16, -8.8, -8, -4.4, -4, -2.2, -2,
 		0, 0.0, 2, 2.2, 8, 8.8, 16, 16.16, 32, 32.32, 64, 64.64, 128, 128.128}
 	sSlice := []string{"foo", "bar", "hello world", "strings"}
-	var bSlice []byte
+	var bSliceSize int
+	for _, s := range sSlice {
+		bSliceSize += len(s)
+	}
+	bSlice := make([]byte, 0, bSliceSize)
 	for _, s := range sSlice {
 		bSlice = append(bSlice, s...)
 	}

lens/static_test.go

@@ -57,15 +57,15 @@ func TestReverseDFS(t *testing.T) {
 			errAt:     -1,
 			wantErr:   false,
 			wantChainsFn: func(start *callgraph.Node) [][]*callgraph.Node {
-				var chains [][]*callgraph.Node
+				chains := make([][]*callgraph.Node, 4)
 				// traverse depth-first: start, n1, n2, n3
-				chains = append(chains, []*callgraph.Node{start})
+				chains[0] = []*callgraph.Node{start}
 				n1 := start.In[0].Caller
-				chains = append(chains, []*callgraph.Node{start, n1})
+				chains[1] = []*callgraph.Node{start, n1}
 				n2 := n1.In[0].Caller
-				chains = append(chains, []*callgraph.Node{start, n1, n2})
+				chains[2] = []*callgraph.Node{start, n1, n2}
 				n3 := n2.In[0].Caller
-				chains = append(chains, []*callgraph.Node{start, n1, n2, n3})
+				chains[3] = []*callgraph.Node{start, n1, n2, n3}
 				return chains
 			},
 		},
@@ -76,13 +76,13 @@ func TestReverseDFS(t *testing.T) {
 			errAt:     -1,
 			wantErr:   false,
 			wantChainsFn: func(start *callgraph.Node) [][]*callgraph.Node {
-				var chains [][]*callgraph.Node
+				chains := make([][]*callgraph.Node, 3)
 				// stop traversal when reaching depth-2
-				chains = append(chains, []*callgraph.Node{start})
+				chains[0] = []*callgraph.Node{start}
 				n1 := start.In[0].Caller
-				chains = append(chains, []*callgraph.Node{start, n1})
+				chains[1] = []*callgraph.Node{start, n1}
 				n2 := n1.In[0].Caller
-				chains = append(chains, []*callgraph.Node{start, n1, n2})
+				chains[2] = []*callgraph.Node{start, n1, n2}
 				return chains
 			},
 		},
@@ -93,12 +93,12 @@ func TestReverseDFS(t *testing.T) {
 			errAt:     2,
 			wantErr:   true,
 			wantChainsFn: func(start *callgraph.Node) [][]*callgraph.Node {
-				var chains [][]*callgraph.Node
+				chains := make([][]*callgraph.Node, 2)
 				// expect start, then first caller popped (index 1)
-				chains = append(chains, []*callgraph.Node{start})
+				chains[0] = []*callgraph.Node{start}
 				// callers reversed: start.In[1] is popped first
 				caller := start.In[1].Caller
-				chains = append(chains, []*callgraph.Node{start, caller})
+				chains[1] = []*callgraph.Node{start, caller}
 				return chains
 			},
 		},
@@ -165,15 +165,15 @@ func TestReverseDFS(t *testing.T) {
 			errAt:     -1,
 			wantErr:   false,
 			wantChainsFn: func(start *callgraph.Node) [][]*callgraph.Node {
-				var chains [][]*callgraph.Node
-				chains = append(chains, []*callgraph.Node{start})
+				chains := make([][]*callgraph.Node, 4)
+				chains[0] = []*callgraph.Node{start}
 				// LIFO: second edge (c2) first
-				chains = append(chains, []*callgraph.Node{start, start.In[1].Caller})
+				chains[1] = []*callgraph.Node{start, start.In[1].Caller}
 				// then first edge (c1)
 				c1 := start.In[0].Caller
-				chains = append(chains, []*callgraph.Node{start, c1})
+				chains[2] = []*callgraph.Node{start, c1}
 				// and finally its child
-				chains = append(chains, []*callgraph.Node{start, c1, c1.In[0].Caller})
+				chains[3] = []*callgraph.Node{start, c1, c1.In[0].Caller}
 				return chains
 			},
 		},
@@ -195,11 +195,11 @@ func TestReverseDFS(t *testing.T) {
 			errAt:     -1,
 			wantErr:   false,
 			wantChainsFn: func(start *callgraph.Node) [][]*callgraph.Node {
-				var chains [][]*callgraph.Node
-				chains = append(chains, []*callgraph.Node{start})
+				chains := make([][]*callgraph.Node, 3)
+				chains[0] = []*callgraph.Node{start}
 				// still get both branches, but do NOT descend into c1a
-				chains = append(chains, []*callgraph.Node{start, start.In[1].Caller})
-				chains = append(chains, []*callgraph.Node{start, start.In[0].Caller})
+				chains[1] = []*callgraph.Node{start, start.In[1].Caller}
+				chains[2] = []*callgraph.Node{start, start.In[0].Caller}
 				return chains
 			},
 		},

lens/storage_test.go

@@ -272,9 +272,9 @@ func TestKeyPrefixStorage(t *testing.T) {
 				assert.Equal(t, []byte(k), got)
 			}
 
-			var wantBase []string
-			for _, k := range tc.keys {
-				wantBase = append(wantBase, tc.prefix+";"+k)
+			wantBase := make([]string, len(tc.keys))
+			for i, k := range tc.keys {
+				wantBase[i] = tc.prefix + ";" + k
 			}
 			keys, err := base.ListKeys()
 			require.NoError(t, err)