Skip to content

Commit 0d5ff76

Browse files
authored
Merge pull request #761 from Path-of-Modifiers/12-add-unique-modifiers-data
12 add unique modifiers data
2 parents b652e65 + 43dc52a commit 0d5ff76

File tree

4 files changed

+54
-3
lines changed

4 files changed

+54
-3
lines changed
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# Source: NA
22
# Note: Only contains bases relevant to the uniques we are tracking
33
baseType,category,subCategory,relatedUniques
4-
"Vaal Rapier","weapon","one-handed sword","Paradoxica"
4+
"Vaal Rapier","weapon","one-handed sword","Paradoxica"
5+
"Serpentine Staff","weapon","warstaff","Cane of Kulemak"
Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
# Unique Name: Cane of Kulemak
2+
# Base Types: Serpentine Staff
3+
# Total modifiers: 4|5
4+
# Can have duplicate modifiers: False|False|False|False
5+
# Modifier distrubution: 1:1,6:1,25:1|2,"rest":0|1
6+
# Source: https://poedb.tw/us/Cane_of_Kulemak
7+
minRoll,maxRoll,textRolls,position,effect,static,unique,veiled
8+
60,90,,0,"#% increased Unveiled Modifier magnitudes",,True,True
9+
2,3,,0,"+# to Level of Socketed Support Gems",,True,True
10+
5,8,,0,"+#% to Quality of Socketed Support Gems",,True,True
11+
20,30,,0,"Enemies you Kill have a #% chance to Explode, dealing a quarter of their maximum Life as Chaos Damage",,True,True
12+
1,1,,0,"Socketed Gems are Supported by Level # #",,True,True
13+
,,"Cast While Channelling|Cast On Critical Strike",1,"Socketed Gems are Supported by Level # #",,True,True
14+
12,14,,0,"#% chance to deal Double Damage",,True,True
15+
34,38,,0,"Minions have #% increased # Speed",,True,True
16+
,,"Attack|Cast",1,"Minions have #% increased Ca#st Speed",,True,True
17+
44,48,,0,"#% to # Damage over Time Multiplier",,True,True
18+
,,"Chaos|Physical|Cold|Fire",1,"#% to # Damage over Time Multiplier",,True,True
19+
7,8,,0,"#% increased Damage per # Charge",,True,True
20+
,,"Endurance|Frenzy|Power",1,"#% increased Damage per # Charge",,True,True
21+
54,60,,0,"+#% Critical Strike Multiplier while a Rare or Unique Enemy is Nearby",,True,True
22+
27,30,,0,"#% increased Attack Speed while a Rare or Unique Enemy is Nearby",,True,True
23+
36,40,,0,"#% chance to deal Double Damage while Focused",,True,True
24+
25,28,,0,"+# to Dexterity and Intelligence",,True,True
25+
25,28,,0,"+# to Strength and Dexterity",,True,True
26+
25,28,,0,"+# to Strength and Intelligence",,True,True
27+
18,22,,0,"#% increased Attack Speed",,True,True
28+
15,15,,0,"#% chance to Trigger Level # Blood Rage when you Kill an Enemy",,True,True
29+
28,32,,0,"#% increased Critical Strike Chance",,True,True
30+
311,350,,0,"+# to Accuracy Rating",,True,True
31+
26,31,,0,"#% increased Cast Speed",,True,True
32+
15,15,,0,"#% chance to gain Arcane Surge when you Kill an Enemy",,True,True
33+
120,139,,0,"#% increased Physical Damage",,True,True
34+
21,25,,0,"#% chance to Impale Enemies on Hit with Attacks",,True,True
35+
21,25,,0,"#% chance to cause Bleeding on Hit",,True,True
36+
21,25,,0,"#% chance to Blind Enemies on hit",,True,True
37+
21,25,,0,"#% chance to Poison on Hit",,True,True
38+
14,16,,0,"Attacks with this Weapon Penetrate #% Elemental Resistances",,True,True
39+
14,16,,0,"Attacks with this Weapon Penetrate #% Chaos Resistance",,True,True
40+
100,109,,0,"#% increased # Damage",,True,True
41+
,,"Fire|Cold|Lightning|Chaos|Spell",1,"#% increased # Damage",,True,True
42+
35,40,,0,"#% chance to #",,True,True
43+
,,"Ignite|Freeze|Shock",1,"#% chance to #",,True,True
44+
26,30,,0,"Chaos Skills have #% increased Skill Effect Duration",,True,True
45+
36,40,,0,"#% increased Mana Regeneration Rate",,True,True
46+
9,10,,0,"Gain #% of Non-Chaos Damage as extra Chaos Damage",,True,True
47+
50,59,,0,"Minions have #% increased maximum Life",,True,True
48+
50,59,,0,"Minions deal #% increased Damage",,True,True

src/backend_data_retrieval/data_retrieval_app/data_deposit/modifier/modifier_processing_modules.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,8 @@ def _add_regex(self, dynamic_modifier_df: pd.DataFrame) -> pd.DataFrame:
160160
)
161161
failed_df = dynamic_modifier_df.loc[dynamic_modifier_df["regex"].isna()]
162162
if not failed_df.empty:
163-
logger.critical("Some modifiers did not get a regex.")
163+
logger.critical("Some modifiers did not get a regex:")
164+
logger.critical(failed_df["effect"])
164165
raise AssertionError("Some modifiers did not get a regex.")
165166
logger.debug("Successfully added regex row by row")
166167

src/backend_data_retrieval/data_retrieval_app/external_data_retrieval/detectors/unique_detector.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ class UniqueUnidentifiedDetector(UniqueDetector):
7373
"ElderJewel.png": "Watcher's Eye",
7474
"SublimeVision.png": "Sublime Vision",
7575
"AfflictionJewel.png": "The Light of Meaning",
76+
"BoundByDestiny.png": "Bound By Destiny",
7677
"VaalCivilization.png": "Glorious Vanity",
7778
"KaruiCivilization.png": "Lethal Pride",
7879
"TemplarCivilization.png": "Militant Faith",
@@ -163,7 +164,7 @@ def __str__(self):
163164

164165

165166
class UniqueWeaponDetector(UniqueDetector):
166-
wanted_items = ["Paradoxica"]
167+
wanted_items = ["Paradoxica", "Cane of Kulemak"]
167168

168169
def __str__(self):
169170
return "Unique Weapon Detector"

0 commit comments

Comments
 (0)