Skip to content
This repository was archived by the owner on Oct 21, 2025. It is now read-only.

Commit bcbe7b6

Browse files
author
LocalIdentity
committed
Fix Explosion damage for Frozen Locus and Shattering Palm
The skills deal attack damage are not attacks that take stats from your weapon Herald of Thunder's bolt is also like this
1 parent d2b768c commit bcbe7b6

File tree

8 files changed

+70
-50
lines changed

8 files changed

+70
-50
lines changed

src/Data/Skills/act_dex.lua

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1471,7 +1471,8 @@ skills["HeraldOfThunderPlayer"] = {
14711471
incrementalEffectiveness = 0.054999999701977,
14721472
statDescriptionScope = "herald_of_thunder_statset_1",
14731473
baseFlags = {
1474-
attack = true,
1474+
nonWeaponAttack = true,
1475+
hit = true,
14751476
},
14761477
constantStats = {
14771478
{ "active_skill_base_physical_damage_%_to_convert_to_lightning", 100 },

src/Data/Skills/act_int.lua

Lines changed: 52 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -8413,9 +8413,18 @@ skills["FrozenLocusExplodePlayer"] = {
84138413
incrementalEffectiveness = 0.034650001674891,
84148414
damageIncrementalEffectiveness = 0.012719999998808,
84158415
statDescriptionScope = "ice_ambush_explode",
8416+
statMap = {
8417+
["main_hand_weapon_minimum_cold_damage"] = {
8418+
mod("ColdMin", "BASE", nil),
8419+
},
8420+
["main_hand_weapon_maximum_cold_damage"] = {
8421+
mod("ColdMax", "BASE", nil),
8422+
},
8423+
},
84168424
baseFlags = {
8417-
attack = true,
84188425
area = true,
8426+
nonWeaponAttack = true,
8427+
hit = true,
84198428
},
84208429
constantStats = {
84218430
{ "active_skill_base_area_of_effect_radius", 20 },
@@ -13403,46 +13412,46 @@ skills["ShatteringPalmExplosionPlayer"] = {
1340313412
{ "additional_base_critical_strike_chance", 10 },
1340413413
},
1340513414
levels = {
13406-
[1] = { levelRequirement = 0, },
13407-
[2] = { levelRequirement = 0, },
13408-
[3] = { levelRequirement = 0, },
13409-
[4] = { levelRequirement = 0, },
13410-
[5] = { levelRequirement = 0, },
13411-
[6] = { levelRequirement = 0, },
13412-
[7] = { levelRequirement = 0, },
13413-
[8] = { levelRequirement = 0, },
13414-
[9] = { levelRequirement = 0, },
13415-
[10] = { levelRequirement = 0, },
13416-
[11] = { levelRequirement = 0, },
13417-
[12] = { levelRequirement = 0, },
13418-
[13] = { levelRequirement = 0, },
13419-
[14] = { levelRequirement = 0, },
13420-
[15] = { levelRequirement = 0, },
13421-
[16] = { levelRequirement = 0, },
13422-
[17] = { levelRequirement = 0, },
13423-
[18] = { levelRequirement = 0, },
13424-
[19] = { levelRequirement = 0, },
13425-
[20] = { levelRequirement = 0, },
13426-
[21] = { levelRequirement = 0, },
13427-
[22] = { levelRequirement = 0, },
13428-
[23] = { levelRequirement = 0, },
13429-
[24] = { levelRequirement = 0, },
13430-
[25] = { levelRequirement = 0, },
13431-
[26] = { levelRequirement = 0, },
13432-
[27] = { levelRequirement = 0, },
13433-
[28] = { levelRequirement = 0, },
13434-
[29] = { levelRequirement = 0, },
13435-
[30] = { levelRequirement = 0, },
13436-
[31] = { levelRequirement = 0, },
13437-
[32] = { levelRequirement = 0, },
13438-
[33] = { levelRequirement = 0, },
13439-
[34] = { levelRequirement = 0, },
13440-
[35] = { levelRequirement = 0, },
13441-
[36] = { levelRequirement = 0, },
13442-
[37] = { levelRequirement = 0, },
13443-
[38] = { levelRequirement = 0, },
13444-
[39] = { levelRequirement = 0, },
13445-
[40] = { levelRequirement = 0, },
13415+
[1] = { baseMultiplier = 1.3, levelRequirement = 0, },
13416+
[2] = { baseMultiplier = 1.43, levelRequirement = 0, },
13417+
[3] = { baseMultiplier = 1.57, levelRequirement = 0, },
13418+
[4] = { baseMultiplier = 1.71, levelRequirement = 0, },
13419+
[5] = { baseMultiplier = 1.85, levelRequirement = 0, },
13420+
[6] = { baseMultiplier = 1.99, levelRequirement = 0, },
13421+
[7] = { baseMultiplier = 2.13, levelRequirement = 0, },
13422+
[8] = { baseMultiplier = 2.26, levelRequirement = 0, },
13423+
[9] = { baseMultiplier = 2.37, levelRequirement = 0, },
13424+
[10] = { baseMultiplier = 2.49, levelRequirement = 0, },
13425+
[11] = { baseMultiplier = 2.61, levelRequirement = 0, },
13426+
[12] = { baseMultiplier = 2.74, levelRequirement = 0, },
13427+
[13] = { baseMultiplier = 2.88, levelRequirement = 0, },
13428+
[14] = { baseMultiplier = 3.03, levelRequirement = 0, },
13429+
[15] = { baseMultiplier = 3.18, levelRequirement = 0, },
13430+
[16] = { baseMultiplier = 3.34, levelRequirement = 0, },
13431+
[17] = { baseMultiplier = 3.5, levelRequirement = 0, },
13432+
[18] = { baseMultiplier = 3.68, levelRequirement = 0, },
13433+
[19] = { baseMultiplier = 3.86, levelRequirement = 0, },
13434+
[20] = { baseMultiplier = 4.05, levelRequirement = 0, },
13435+
[21] = { baseMultiplier = 4.26, levelRequirement = 0, },
13436+
[22] = { baseMultiplier = 4.47, levelRequirement = 0, },
13437+
[23] = { baseMultiplier = 4.69, levelRequirement = 0, },
13438+
[24] = { baseMultiplier = 4.93, levelRequirement = 0, },
13439+
[25] = { baseMultiplier = 5.17, levelRequirement = 0, },
13440+
[26] = { baseMultiplier = 5.43, levelRequirement = 0, },
13441+
[27] = { baseMultiplier = 5.71, levelRequirement = 0, },
13442+
[28] = { baseMultiplier = 5.99, levelRequirement = 0, },
13443+
[29] = { baseMultiplier = 6.29, levelRequirement = 0, },
13444+
[30] = { baseMultiplier = 6.6, levelRequirement = 0, },
13445+
[31] = { baseMultiplier = 6.93, levelRequirement = 0, },
13446+
[32] = { baseMultiplier = 7.28, levelRequirement = 0, },
13447+
[33] = { baseMultiplier = 7.65, levelRequirement = 0, },
13448+
[34] = { baseMultiplier = 8.03, levelRequirement = 0, },
13449+
[35] = { baseMultiplier = 8.43, levelRequirement = 0, },
13450+
[36] = { baseMultiplier = 8.85, levelRequirement = 0, },
13451+
[37] = { baseMultiplier = 9.29, levelRequirement = 0, },
13452+
[38] = { baseMultiplier = 9.76, levelRequirement = 0, },
13453+
[39] = { baseMultiplier = 10.25, levelRequirement = 0, },
13454+
[40] = { baseMultiplier = 10.76, levelRequirement = 0, },
1344613455
},
1344713456
statSets = {
1344813457
[1] = {
@@ -13452,8 +13461,9 @@ skills["ShatteringPalmExplosionPlayer"] = {
1345213461
damageIncrementalEffectiveness = 0.012719999998808,
1345313462
statDescriptionScope = "triggered_freezing_word_explosion",
1345413463
baseFlags = {
13455-
attack = true,
1345613464
area = true,
13465+
nonWeaponAttack = true,
13466+
hit = true,
1345713467
},
1345813468
constantStats = {
1345913469
{ "active_skill_base_area_of_effect_radius", 16 },

src/Data/Skills/sup_int.lua

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1104,7 +1104,8 @@ skills["SupportElementalDischargePlayer"] = {
11041104
},
11051105
},
11061106
}
1107-
}skills["TriggeredElementalDischargePlayer"] = {
1107+
}
1108+
skills["TriggeredElementalDischargePlayer"] = {
11081109
name = "Elemental Discharge",
11091110
hidden = true,
11101111
skillTypes = { [SkillType.Spell] = true, [SkillType.Damage] = true, [SkillType.SkillGrantedBySupport] = true, [SkillType.Triggerable] = true, [SkillType.Cooldown] = true, [SkillType.Triggered] = true, },

src/Export/Scripts/skills.lua

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,7 @@ directiveTable.skill = function(state, args, out)
331331
end
332332
local nextGemLevelReqValue = 0
333333
local perLevel = dat("GrantedEffectsPerLevel"):GetRowList("GrantedEffect", granted)
334-
local grantedEffectStatSet = dat("GrantedEffectStatSets"):GetRow("Id", grantedId)
335-
local statsPerLevel = dat("GrantedEffectStatSetsPerLevel"):GetRowList("GrantedEffectStatSets", grantedEffectStatSet)
334+
local statsPerLevel = dat("GrantedEffectStatSetsPerLevel"):GetRowList("GrantedEffect", granted)
336335
local gemLevelProgression = nil
337336
if skillGem and not state.noGem then
338337
gemLevelProgression = dat("ItemExperiencePerLevel"):GetRowList("ItemExperienceType", skillGem.GemLevelProgression)

src/Export/Skills/act_dex.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ statMap = {
149149
},
150150
#mods
151151
#set HeraldOfThunderOnKillPlayer
152-
#flags attack
152+
#flags nonWeaponAttack hit
153153
#mods
154154
#skillEnd
155155

src/Export/Skills/act_int.txt

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,15 @@ statMap = {
557557
#skill FrozenLocusExplodePlayer
558558
#startSets
559559
#set FrozenLocusExplodePlayer
560-
#flags attack area
560+
#flags area nonWeaponAttack hit
561+
statMap = {
562+
["main_hand_weapon_minimum_cold_damage"] = {
563+
mod("ColdMin", "BASE", nil),
564+
},
565+
["main_hand_weapon_maximum_cold_damage"] = {
566+
mod("ColdMax", "BASE", nil),
567+
},
568+
},
561569
#mods
562570
#skillEnd
563571

@@ -877,7 +885,7 @@ statMap = {
877885
#skill ShatteringPalmExplosionPlayer
878886
#startSets
879887
#set TriggeredFreezingWordExplosionPlayer
880-
#flags attack area
888+
#flags area nonWeaponAttack hit
881889
#mods
882890
#skillEnd
883891

src/Export/Skills/sup_int.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,7 @@ statMap = {
276276
#set SupportElementalDischargePlayer
277277
#mods
278278
#skillEnd
279+
279280
#skill TriggeredElementalDischargePlayer
280281
#startSets
281282
#set TriggeredElementalDischargePlayer

src/Modules/CalcActiveSkill.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ function calcs.buildActiveSkillModList(env, activeSkill)
355355
if skillFlags.hit then
356356
skillModFlags = bor(skillModFlags, ModFlag.Hit)
357357
end
358-
if skillFlags.attack then
358+
if skillFlags.attack or skillFlags.nonWeaponAttack then
359359
skillModFlags = bor(skillModFlags, ModFlag.Attack)
360360
else
361361
skillModFlags = bor(skillModFlags, ModFlag.Cast)

0 commit comments

Comments
 (0)