Fix gems not showing the correct stats on some parts (#661)

* Fix gems not showing the correct stats on some parts

We can no longer use the unresolved values for skills with multiple levels as some skills grab the base value from the first set and add it to the second/third and this doesn't work correctly with the previous method
This also removes a bunch of duplicate stats that appeared on some skills
I made it so that skills with only 1 level keep the previous method of only using the statInterpolation formula as otherwise it would break minion skills that work this way

There is still an issue where running the export script multiple times without restarting the exporter will duplicate the constant stat entries but I was running out of time to fix it

The only actual issue with a gem now is the ShieldCharge gem which has too many statInterpolation entries. It doesn't cause any issues in the program but would be nice to fix as it may cause an issue in the future on another gem

* Spelling mistake

* Fix stat sets (#695)

* Updated skills.lua to not duplicate stats

* AdditionalStats are being set as resolved values now

* Default empty stat sets

---------

Co-authored-by: LocalIdentity <[email protected]>
Co-authored-by: Wires77 <[email protected]>

Author: 3 people

src/Data/Skills/act_dex.lua

@@ -192,19 +192,14 @@ skills["GasShotSkeletonSniperMinion"] = {
 				duration = true,
 			},
 			constantStats = {
-				{ "base_skill_effect_duration", 8000 },
-				{ "active_skill_ground_effect_area_of_effect_+%_final_per_second", 40 },
-				{ "active_skill_ground_effect_area_of_effect_+%_final_per_second_max", 200 },
 				{ "active_skill_base_area_of_effect_radius", 14 },
 				{ "active_skill_base_secondary_area_of_effect_radius", 20 },
 				{ "command_minion_marker_additional_time_ms", 300 },
+				{ "base_skill_effect_duration", 8000 },
+				{ "active_skill_ground_effect_area_of_effect_+%_final_per_second", 40 },
+				{ "active_skill_ground_effect_area_of_effect_+%_final_per_second_max", 200 },
 			},
 			stats = {
-				"is_area_damage",
-				"display_statset_no_hit_damage",
-				"display_statset_hide_usage_stats",
-				"display_fake_attack_hit_poison",
-				"display_skill_poisons_without_hit",
 				"is_commandable_skill",
 				"base_is_projectile",
 				"is_area_damage",
@@ -213,6 +208,10 @@ skills["GasShotSkeletonSniperMinion"] = {
 				"skill_cannot_be_electrocuted",
 				"skill_cannot_be_knocked_back",
 				"skill_cannot_be_stunned",
+				"display_statset_no_hit_damage",
+				"display_statset_hide_usage_stats",
+				"display_fake_attack_hit_poison",
+				"display_skill_poisons_without_hit",
 			},
 			levels = {
 				[1] = { baseMultiplier = 2.2, actorLevel = 1, },
@@ -227,10 +226,10 @@ skills["GasShotSkeletonSniperMinion"] = {
 				area = true,
 			},
 			constantStats = {
-				{ "active_skill_base_physical_damage_%_to_convert_to_fire", 100 },
 				{ "active_skill_base_area_of_effect_radius", 14 },
 				{ "active_skill_base_secondary_area_of_effect_radius", 20 },
 				{ "command_minion_marker_additional_time_ms", 300 },
+				{ "active_skill_base_physical_damage_%_to_convert_to_fire", 100 },
 			},
 			stats = {
 				"is_commandable_skill",
@@ -292,14 +291,14 @@ skills["BoneshatterBruteMinion"] = {
 				area = true,
 			},
 			constantStats = {
-				{ "active_skill_base_area_of_effect_radius", 20 },
-				{ "active_skill_damage_+%_final", 300 },
 				{ "melee_range_+", 2 },
 				{ "melee_conditional_step_distance", 3 },
+				{ "active_skill_base_area_of_effect_radius", 20 },
+				{ "active_skill_damage_+%_final", 300 },
 			},
 			stats = {
-				"is_area_damage",
 				"crushing_blow",
+				"is_area_damage",
 			},
 			levels = {
 				[1] = { actorLevel = 1, },
@@ -438,24 +437,24 @@ skills["FrostBoltSkeletonMageMinion"] = {
 				hit = true,
 			},
 			constantStats = {
-				{ "active_skill_base_area_of_effect_radius", 8 },
 				{ "monster_projectile_variation", 1064 },
 				{ "base_chance_to_freeze_%", 100 },
 				{ "active_skill_hit_damage_freeze_multiplier_+%_final", 100 },
 				{ "projectile_maximum_duration_override_ms", 180 },
+				{ "active_skill_base_area_of_effect_radius", 8 },
 			},
 			stats = {
-				"is_area_damage",
-				"display_statset_hide_usage_stats",
 				"spell_minimum_base_cold_damage",
 				"spell_maximum_base_cold_damage",
 				"base_is_projectile",
 				"projectile_uses_contact_position",
 				"check_for_targets_between_initiator_and_projectile_source",
 				"maintain_projectile_direction_when_using_contact_position",
+				"is_area_damage",
+				"display_statset_hide_usage_stats",
 			},
 			levels = {
-				[1] = { actorLevel = 1, },
+				[1] = { 0.80000001192093, 1.2000000476837, statInterpolation = { 3, 3, }, actorLevel = 1, },
 			},
 		},
 	}
@@ -615,10 +614,10 @@ skills["FireBombSkeletonMinion"] = {
 			baseFlags = {
 			},
 			constantStats = {
-				{ "base_secondary_skill_effect_duration", 0 },
 				{ "base_skill_effect_duration", 2000 },
 				{ "active_skill_base_physical_damage_%_to_convert_to_fire", 70 },
 				{ "active_skill_base_area_of_effect_radius", 16 },
+				{ "base_secondary_skill_effect_duration", 0 },
 			},
 			stats = {
 				"base_fire_damage_to_deal_per_minute",
@@ -713,46 +712,46 @@ skills["DestructiveLinkSkeletonBombadierMinion"] = {
 				"skill_cannot_be_stunned",
 			},
 			levels = {
-				[1] = { 0.80000001192093, 1.2000000476837, 27, statInterpolation = { 3, 3, 1, }, actorLevel = 1, },
-				[2] = { 0.80000001192093, 1.2000000476837, 49, statInterpolation = { 3, 3, 1, }, actorLevel = 3, },
-				[3] = { 0.80000001192093, 1.2000000476837, 73, statInterpolation = { 3, 3, 1, }, actorLevel = 5, },
-				[4] = { 0.80000001192093, 1.2000000476837, 100, statInterpolation = { 3, 3, 1, }, actorLevel = 7, },
-				[5] = { 0.80000001192093, 1.2000000476837, 130, statInterpolation = { 3, 3, 1, }, actorLevel = 9, },
-				[6] = { 0.80000001192093, 1.2000000476837, 164, statInterpolation = { 3, 3, 1, }, actorLevel = 11, },
-				[7] = { 0.80000001192093, 1.2000000476837, 201, statInterpolation = { 3, 3, 1, }, actorLevel = 13, },
-				[8] = { 0.80000001192093, 1.2000000476837, 243, statInterpolation = { 3, 3, 1, }, actorLevel = 15, },
-				[9] = { 0.80000001192093, 1.2000000476837, 289, statInterpolation = { 3, 3, 1, }, actorLevel = 17, },
-				[10] = { 0.80000001192093, 1.2000000476837, 340, statInterpolation = { 3, 3, 1, }, actorLevel = 19, },
-				[11] = { 0.80000001192093, 1.2000000476837, 396, statInterpolation = { 3, 3, 1, }, actorLevel = 21, },
-				[12] = { 0.80000001192093, 1.2000000476837, 459, statInterpolation = { 3, 3, 1, }, actorLevel = 23, },
-				[13] = { 0.80000001192093, 1.2000000476837, 528, statInterpolation = { 3, 3, 1, }, actorLevel = 25, },
-				[14] = { 0.80000001192093, 1.2000000476837, 603, statInterpolation = { 3, 3, 1, }, actorLevel = 27, },
-				[15] = { 0.80000001192093, 1.2000000476837, 688, statInterpolation = { 3, 3, 1, }, actorLevel = 29, },
-				[16] = { 0.80000001192093, 1.2000000476837, 780, statInterpolation = { 3, 3, 1, }, actorLevel = 31, },
-				[17] = { 0.80000001192093, 1.2000000476837, 883, statInterpolation = { 3, 3, 1, }, actorLevel = 33, },
-				[18] = { 0.80000001192093, 1.2000000476837, 994, statInterpolation = { 3, 3, 1, }, actorLevel = 35, },
-				[19] = { 0.80000001192093, 1.2000000476837, 1118, statInterpolation = { 3, 3, 1, }, actorLevel = 37, },
-				[20] = { 0.80000001192093, 1.2000000476837, 1253, statInterpolation = { 3, 3, 1, }, actorLevel = 39, },
-				[21] = { 0.80000001192093, 1.2000000476837, 1403, statInterpolation = { 3, 3, 1, }, actorLevel = 41, },
-				[22] = { 0.80000001192093, 1.2000000476837, 1566, statInterpolation = { 3, 3, 1, }, actorLevel = 43, },
-				[23] = { 0.80000001192093, 1.2000000476837, 1744, statInterpolation = { 3, 3, 1, }, actorLevel = 45, },
-				[24] = { 0.80000001192093, 1.2000000476837, 1940, statInterpolation = { 3, 3, 1, }, actorLevel = 47, },
-				[25] = { 0.80000001192093, 1.2000000476837, 2156, statInterpolation = { 3, 3, 1, }, actorLevel = 49, },
-				[26] = { 0.80000001192093, 1.2000000476837, 2391, statInterpolation = { 3, 3, 1, }, actorLevel = 51, },
-				[27] = { 0.80000001192093, 1.2000000476837, 2649, statInterpolation = { 3, 3, 1, }, actorLevel = 53, },
-				[28] = { 0.80000001192093, 1.2000000476837, 2932, statInterpolation = { 3, 3, 1, }, actorLevel = 55, },
-				[29] = { 0.80000001192093, 1.2000000476837, 3241, statInterpolation = { 3, 3, 1, }, actorLevel = 57, },
-				[30] = { 0.80000001192093, 1.2000000476837, 3578, statInterpolation = { 3, 3, 1, }, actorLevel = 59, },
-				[31] = { 0.80000001192093, 1.2000000476837, 3948, statInterpolation = { 3, 3, 1, }, actorLevel = 61, },
-				[32] = { 0.80000001192093, 1.2000000476837, 4352, statInterpolation = { 3, 3, 1, }, actorLevel = 63, },
-				[33] = { 0.80000001192093, 1.2000000476837, 4793, statInterpolation = { 3, 3, 1, }, actorLevel = 65, },
-				[34] = { 0.80000001192093, 1.2000000476837, 5275, statInterpolation = { 3, 3, 1, }, actorLevel = 67, },
-				[35] = { 0.80000001192093, 1.2000000476837, 5801, statInterpolation = { 3, 3, 1, }, actorLevel = 69, },
-				[36] = { 0.80000001192093, 1.2000000476837, 6375, statInterpolation = { 3, 3, 1, }, actorLevel = 71, },
-				[37] = { 0.80000001192093, 1.2000000476837, 7003, statInterpolation = { 3, 3, 1, }, actorLevel = 73, },
-				[38] = { 0.80000001192093, 1.2000000476837, 7688, statInterpolation = { 3, 3, 1, }, actorLevel = 75, },
-				[39] = { 0.80000001192093, 1.2000000476837, 8434, statInterpolation = { 3, 3, 1, }, actorLevel = 77, },
-				[40] = { 0.80000001192093, 1.2000000476837, 9249, statInterpolation = { 3, 3, 1, }, actorLevel = 79, },
+				[1] = { 7, 11, 27, statInterpolation = { 1, 1, 1, }, actorLevel = 1, },
+				[2] = { 9, 14, 49, statInterpolation = { 1, 1, 1, }, actorLevel = 3, },
+				[3] = { 12, 18, 73, statInterpolation = { 1, 1, 1, }, actorLevel = 5, },
+				[4] = { 15, 22, 100, statInterpolation = { 1, 1, 1, }, actorLevel = 7, },
+				[5] = { 18, 28, 130, statInterpolation = { 1, 1, 1, }, actorLevel = 9, },
+				[6] = { 22, 34, 164, statInterpolation = { 1, 1, 1, }, actorLevel = 11, },
+				[7] = { 27, 41, 201, statInterpolation = { 1, 1, 1, }, actorLevel = 13, },
+				[8] = { 33, 50, 243, statInterpolation = { 1, 1, 1, }, actorLevel = 15, },
+				[9] = { 40, 60, 289, statInterpolation = { 1, 1, 1, }, actorLevel = 17, },
+				[10] = { 48, 73, 340, statInterpolation = { 1, 1, 1, }, actorLevel = 19, },
+				[11] = { 58, 87, 396, statInterpolation = { 1, 1, 1, }, actorLevel = 21, },
+				[12] = { 69, 104, 459, statInterpolation = { 1, 1, 1, }, actorLevel = 23, },
+				[13] = { 83, 124, 528, statInterpolation = { 1, 1, 1, }, actorLevel = 25, },
+				[14] = { 98, 148, 603, statInterpolation = { 1, 1, 1, }, actorLevel = 27, },
+				[15] = { 117, 175, 688, statInterpolation = { 1, 1, 1, }, actorLevel = 29, },
+				[16] = { 138, 207, 780, statInterpolation = { 1, 1, 1, }, actorLevel = 31, },
+				[17] = { 163, 245, 883, statInterpolation = { 1, 1, 1, }, actorLevel = 33, },
+				[18] = { 193, 289, 994, statInterpolation = { 1, 1, 1, }, actorLevel = 35, },
+				[19] = { 227, 341, 1118, statInterpolation = { 1, 1, 1, }, actorLevel = 37, },
+				[20] = { 267, 401, 1253, statInterpolation = { 1, 1, 1, }, actorLevel = 39, },
+				[21] = { 314, 471, 1403, statInterpolation = { 1, 1, 1, }, actorLevel = 41, },
+				[22] = { 368, 553, 1566, statInterpolation = { 1, 1, 1, }, actorLevel = 43, },
+				[23] = { 432, 648, 1744, statInterpolation = { 1, 1, 1, }, actorLevel = 45, },
+				[24] = { 506, 758, 1940, statInterpolation = { 1, 1, 1, }, actorLevel = 47, },
+				[25] = { 591, 887, 2156, statInterpolation = { 1, 1, 1, }, actorLevel = 49, },
+				[26] = { 691, 1036, 2391, statInterpolation = { 1, 1, 1, }, actorLevel = 51, },
+				[27] = { 806, 1210, 2649, statInterpolation = { 1, 1, 1, }, actorLevel = 53, },
+				[28] = { 941, 1411, 2932, statInterpolation = { 1, 1, 1, }, actorLevel = 55, },
+				[29] = { 1096, 1644, 3241, statInterpolation = { 1, 1, 1, }, actorLevel = 57, },
+				[30] = { 1276, 1915, 3578, statInterpolation = { 1, 1, 1, }, actorLevel = 59, },
+				[31] = { 1485, 2228, 3948, statInterpolation = { 1, 1, 1, }, actorLevel = 61, },
+				[32] = { 1727, 2591, 4352, statInterpolation = { 1, 1, 1, }, actorLevel = 63, },
+				[33] = { 2007, 3011, 4793, statInterpolation = { 1, 1, 1, }, actorLevel = 65, },
+				[34] = { 2331, 3497, 5275, statInterpolation = { 1, 1, 1, }, actorLevel = 67, },
+				[35] = { 2706, 4058, 5801, statInterpolation = { 1, 1, 1, }, actorLevel = 69, },
+				[36] = { 3139, 4708, 6375, statInterpolation = { 1, 1, 1, }, actorLevel = 71, },
+				[37] = { 3639, 5458, 7003, statInterpolation = { 1, 1, 1, }, actorLevel = 73, },
+				[38] = { 4217, 6325, 7688, statInterpolation = { 1, 1, 1, }, actorLevel = 75, },
+				[39] = { 4884, 7326, 8434, statInterpolation = { 1, 1, 1, }, actorLevel = 77, },
+				[40] = { 5654, 8481, 9249, statInterpolation = { 1, 1, 1, }, actorLevel = 79, },
 			},
 		},
 	}