Skip to content

Commit bfb2f93

Browse files
author
LocalIdentity
committed
Fix tests and changelog generation
The gemling node had its wording changed so mod parser was treating it incorrectly The changelog change should remove the auto generated line from the changelogs now I hope
1 parent 3dbc13b commit bfb2f93

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.github/tweak_changelogs.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
RELEASE_VERSION="$1"
44

5-
# Delete until the first line containing "--"
6-
sed -i '1,/--/d' temp_change.md
5+
# Delete until and including the first line containing "<!-- Release notes generated"
6+
sed -i '1,/^<!-- Release notes generated/d' temp_change.md
77
# Reverse the order of lines in the file (last line becomes first, etc.)
88
sed -i '1h;1d;$!H;$!d;G' temp_change.md
99
# Convert "**Full Changelog**: URL" format to markdown link format "[Full Changelog](URL)"

spec/System/TestAttacks_spec.lua

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,19 +83,19 @@ describe("TestAttacks", function()
8383
runCallback("OnFrame")
8484
end
8585
it("correctly calculates increased damage with gemling integrated efficiency", function()
86-
integratedEfficiencyLoadout("skills gain 99% increased damage per socketed red support gem")
86+
integratedEfficiencyLoadout("skills deal 99% increased damage per connected red support gem")
8787
local incDmg = build.calcsTab.mainEnv.player.activeSkillList[1].skillModList:Sum("INC", nil, "Damage")
8888
assert.are.equals(incDmg, 99)
8989
end)
9090

9191
it("correctly calculates crit chance with gemling integrated efficiency", function()
92-
integratedEfficiencyLoadout("skills gain 99% increased critical hit chance per socketed blue support gem")
92+
integratedEfficiencyLoadout("skills have 99% increased critical hit chance per connected blue support gem")
9393
local incCritChance = build.calcsTab.mainEnv.player.activeSkillList[1].skillModList:Sum("INC", nil, "CritChance")
9494
assert.are.equals(incCritChance, 99)
9595
end)
9696

9797
it("correctly calculates increased skill speed with gemling integrated efficiency", function()
98-
integratedEfficiencyLoadout("skills gain 99% increased skill speed per socketed green support gem")
98+
integratedEfficiencyLoadout("skills have 99% increased skill speed per connected green support gem")
9999
local incSpeed = build.calcsTab.mainEnv.player.activeSkillList[1].skillModList:Sum("INC", nil, "Speed")
100100
assert.are.equals(incSpeed, 99)
101101
end)

0 commit comments

Comments
 (0)