FIX(tests): inital pass on updating tests for POB2 (#195)

Author: Paliak

.busted

@@ -9,11 +9,5 @@ return {
         helper = "HeadlessWrapper.lua",
         ROOT = { "../spec" },
        	["exclude-tags"] = "builds",
-    },
-    generate = {
-        directory = "src",
-        lpath = "../runtime/lua/?.lua;../runtime/lua/?/init.lua",
-        helper = "HeadlessWrapper.lua",
-        ROOT = { "../spec/GenerateBuilds.lua" },
     }
 }

spec/GenerateBuilds.lua

@@ -7,36 +7,11 @@ describe("TestAilments", function()
 		-- newBuild() takes care of resetting everything in setup()
 	end)
 
-	it("maximum shock value", function()
-		-- Shock Nova
-		build.skillsTab:PasteSocketGroup("Slot: Weapon 1\nShock Nova 4/0 Default  1\n")
-		runCallback("OnFrame")
-		assert.are.equals(round(50 + 10), build.calcsTab.mainOutput.MaximumShock)
+	--TODO: Shock not supported currently
+	--it("maximum shock value", function()
+	--end)
 
-		-- Voltaxic Rift
-		build.itemsTab:CreateDisplayItemFromRaw("New Item\nAssassin Bow\n+40% to Maximum Effect of Shock")
-		build.itemsTab:AddDisplayItem()
-		runCallback("OnFrame")
-		assert.are.equals(round(50 + 10 + 40), build.calcsTab.mainOutput.MaximumShock)
-	end)
-
-	it("bleed is buffed by bleed chance", function()
-		build.itemsTab:CreateDisplayItemFromRaw("New Item\nKarui Chopper")
-		build.itemsTab:AddDisplayItem()
-		build.skillsTab:PasteSocketGroup("Slot: Weapon 1\nHeavy Strike 1/0 Default  1\n")
-		build.configTab.input.customMods = "\z
-		attacks have 10% chance to cause bleeding\n\z
-		"
-		build.configTab:BuildModList()
-		runCallback("OnFrame")
-		local badDps = build.calcsTab.mainOutput.BleedDPS
-
-		build.configTab.input.customMods = "\z
-		attacks have 100% chance to cause bleeding\n\z
-		"
-		build.configTab:BuildModList()
-		runCallback("OnFrame")
-		local goodDps = build.calcsTab.mainOutput.BleedDPS
-		assert.True(goodDps > badDps)
-	end)
+	--TODO: Shock not supported currently
+	--it("bleed is buffed by bleed chance", function()
+	--end)
 end)

spec/System/TestAilments_spec.lua

@@ -9,27 +9,35 @@ describe("TestAttacks", function()
 
 	it("creates an item and has the correct crit chance", function()
 		assert.are.equals(build.calcsTab.mainOutput.CritChance, 0)
-		build.itemsTab:CreateDisplayItemFromRaw("New Item\nMaraketh Bow\nCrafted: true\nPrefix: None\nPrefix: None\nPrefix: None\nSuffix: None\nSuffix: None\nSuffix: None\nQuality: 20\nSockets: G-G-G-G-G-G\nLevelReq: 71\nImplicits: 1\n{tags:speed}10% increased Movement Speed")
+		build.itemsTab:CreateDisplayItemFromRaw([[
+        	New Item
+        	Heavy Bow
+        ]])
 		build.itemsTab:AddDisplayItem()
 		runCallback("OnFrame")
-		assert.are.equals(build.calcsTab.mainOutput.CritChance, 5.5 * build.calcsTab.mainOutput.HitChance / 100)
+		assert.are.equals(build.calcsTab.mainOutput.CritChance, 5 * build.calcsTab.mainOutput.HitChance / 100)
 	end)
 
 	it("creates an item and has the correct crit multi", function()
-		assert.are.equals(1.5, build.calcsTab.mainOutput.CritMultiplier)
-		build.itemsTab:CreateDisplayItemFromRaw("New Item\nAssassin Bow\nCrafted: true\nPrefix: None\nPrefix: None\nPrefix: None\nSuffix: None\nSuffix: None\nSuffix: None\nQuality: 20\nSockets: G-G-G-G-G-G\nLevelReq: 62\nImplicits: 1\n{tags:damage,critical}{range:0.5}+(15-25)% to Global Critical Strike Multiplier")
+		assert.are.equals(2, build.calcsTab.mainOutput.CritMultiplier)
+		build.itemsTab:CreateDisplayItemFromRaw([[
+        	New Item
+			Heavy Bow
+			25% increased Critical Damage Bonus
+        ]])
 		build.itemsTab:AddDisplayItem()
 		runCallback("OnFrame")
-		assert.are.equals(1.5 + 0.2, build.calcsTab.mainOutput.CritMultiplier)
+		assert.are.equals(2 + 0.25, build.calcsTab.mainOutput.CritMultiplier)
 	end)
 
 	it("correctly converts spell damage per stat to attack damage", function()
 		assert.are.equals(0, build.calcsTab.mainEnv.player.modDB:Sum("INC", { flags = ModFlag.Attack }, "Damage"))
 		build.itemsTab:CreateDisplayItemFromRaw([[
 		New Item
-		Coral Amulet
+		Ring
 		10% increased attack damage
 		10% increased spell damage
+		+20 to Intelligence
 		1% increased spell damage per 10 intelligence
 		]])
 		build.itemsTab:AddDisplayItem()
@@ -40,12 +48,11 @@ describe("TestAttacks", function()
 
 		build.itemsTab:CreateDisplayItemFromRaw([[
 		New Item
-		Coral Ring
+		Ring
 		increases and reductions to spell damage also apply to attacks
 		]])
 		build.itemsTab:AddDisplayItem()
 		runCallback("OnFrame")
 		assert.are.equals(22, build.calcsTab.mainEnv.player.mainSkill.skillModList:Sum("INC", { flags = ModFlag.Attack }, "Damage"))
-
 	end)
 end)