Fix Voltaic Nova and Freezing Nova damage scaling (#663)

Both skills scale with non weapon attack damage

Co-authored-by: LocalIdentity <[email protected]>

Author: LocalIdentity

src/Data/SkillStatMap.lua

@@ -82,10 +82,10 @@ return {
 	skill("ChaosMax", nil),
 },
 ["main_hand_weapon_minimum_lightning_damage"] = {
-	skill("LightningMin", nil, { type = "Condition", var = "MainHandAttack" })
+	skill("LightningMin", nil)
 },
 ["main_hand_weapon_maximum_lightning_damage"] = {
-	skill("LightningMax", nil, { type = "Condition", var = "MainHandAttack" })
+	skill("LightningMax", nil)
 },
 ["spell_minimum_base_lightning_damage_per_removable_power_charge"] = {
 	skill("LightningMin", nil, { type = "Multiplier", var = "RemovablePowerCharge" }),
@@ -108,6 +108,12 @@ return {
 ["spell_minimum_base_cold_damage_+_per_10_intelligence"] = {
 	skill("ColdMin", nil, { type = "PerStat", stat = "Int", div = 10 }),
 },
+["main_hand_weapon_minimum_cold_damage"] = {
+	skill("ColdMin", "BASE", nil),
+},
+["main_hand_weapon_maximum_cold_damage"] = {
+	skill("ColdMax", "BASE", nil),
+},
 ["spell_maximum_base_cold_damage_+_per_10_intelligence"] = {
 	skill("ColdMax", nil, { type = "PerStat", stat = "Int", div = 10 }),
 },

src/Data/Skills/act_dex.lua

@@ -4451,8 +4451,7 @@ skills["TriggeredVoltaicMarkNovaPlayer"] = {
 			damageIncrementalEffectiveness = 0.006699999794364,
 			statDescriptionScope = "thaumaturgist_mark_nova",
 			baseFlags = {
-				attack = true,
-				area = true,
+				nonWeaponAttack = true,
 			},
 			constantStats = {
 				{ "active_skill_base_area_of_effect_radius", 26 },

src/Data/Skills/act_int.lua

@@ -7458,8 +7458,7 @@ skills["TriggeredFreezingMarkNovaPlayer"] = {
 			damageIncrementalEffectiveness = 0.006699999794364,
 			statDescriptionScope = "freezing_mark_nova",
 			baseFlags = {
-				spell = true,
-				area = true,
+				nonWeaponAttack = true,
 			},
 			constantStats = {
 				{ "active_skill_base_area_of_effect_radius", 26 },
@@ -8440,14 +8439,6 @@ skills["FrozenLocusExplodePlayer"] = {
 			incrementalEffectiveness = 0.034650001674891,
 			damageIncrementalEffectiveness = 0.012719999998808,
 			statDescriptionScope = "ice_ambush_explode",
-			statMap = {
-				["main_hand_weapon_minimum_cold_damage"] = {
-					mod("ColdMin", "BASE", nil),
-				},
-				["main_hand_weapon_maximum_cold_damage"] = {
-					mod("ColdMax", "BASE", nil),
-				},
-			},
 			baseFlags = {
 				area = true,
 				nonWeaponAttack = true,

src/Export/Skills/act_dex.txt

@@ -350,7 +350,7 @@ statMap = {
 #skill TriggeredVoltaicMarkNovaPlayer
 #startSets
 #set TriggeredVoltaicMarkNovaPlayer
-#flags attack area
+#flags nonWeaponAttack
 #mods
 #skillEnd
 

src/Export/Skills/act_int.txt

@@ -513,7 +513,7 @@ statMap = {
 #skill TriggeredFreezingMarkNovaPlayer
 #startSets
 #set TriggeredFreezingMarkNovaPlayer
-#flags spell area
+#flags nonWeaponAttack
 #mods
 #skillEnd
 
@@ -581,14 +581,6 @@ statMap = {
 #startSets
 #set FrozenLocusExplodePlayer
 #flags area nonWeaponAttack hit
-statMap = {
-	["main_hand_weapon_minimum_cold_damage"] = {
-		mod("ColdMin", "BASE", nil),
-	},
-	["main_hand_weapon_maximum_cold_damage"] = {
-		mod("ColdMax", "BASE", nil),
-	},
-},
 #mods
 #skillEnd