Maximum resistances can incorrectly exceed 90% via increases to max block chance with the unique shield Saffell's Frame equipped

[drevtpohlman]

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

• I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

With Saffell's Frame equipped, and a combined total of +15% to Maximum Block Chance and Maximum Fire Resistance, the in-game character sheet shows 90% Fire Resistance (with 167% overcap), regardless of further increases to Maximum Block Chance or Maximum Fire Resistance.

What is the behaviour in Path of Building?

This behaviour was replicated on version 0.12.2 as well as the beta build v0.12.2-079d89d67

I was testing some things with a Smith of Kitava Warrior using the unique shield Saffell's Frame, and noticed that my maximum elemental resistances could exceed the 90% hard-cap. With 90% all Maximum Resistances and +5% to Maximum Block Chance, my Maximum Resistances were all shown as 95%.

It seems that this is caused by incorrect behaviour of the Saffell's Frame mod: "Modifiers to Maximum Block Chance instead apply to Maximum Resistances".

I did some experimenting and took note of some odd behaviour regarding Max Hit values with this modifier enabled. I created a new build (default Ranger level 1) with no changes other than these custom modifiers applied in the Configuration tab:

Modifiers to Maximum Block Chance instead apply to Maximum Resistances
+500% to All Elemental Resistances
+450% to Chaos Resistance

+100% to All Maximum Resistances
+100% to Maximum Block Chance

With all of these custom modifiers applied, Fire, Cold, Lightning, and Chaos Resistances are all displayed as 190% (+260%)

Removing Modifiers to Maximum Block Chance instead apply to Maximum Resistances and equipping Saffell's Frame provides the same result.

Removing either Modifiers to Maximum Block Chance instead apply to Maximum Resistances or +100% to Block Chance correctly shows each resistance as 90% (+360%)
Removing only +100% to All Maximum Resistances shows each resistance as 175% (+275%)
Removing only +100% to Maximum Block Chance shows each resistance as 90% (+360%)

It looks to me like this Saffell's Frame modifier is applying Maximum Block Chance to Maximum Resistances in a way which ignores the 90% hard-cap on Maximum Resistances entirely.

---

Everything else below may be irrelevant since it all pertains to Max Hit calculations after exceeding 100% resistances (which shouldn't be possible anyway). But I figured it's possible that some of what I observed could point to some other issue.

---

I also noticed some odd Max Hit calculations when Maximum Resistances exceeded 100%, using the same new build with the custom modifiers listed above, and tweaking some values.

As expected, when Chaos resistance is 100% (while Maximum Chaos resistance is 100% or more), the Chaos Max Hit value is "inf", and at 101% Chaos Resistance or more, Chaos Max Hit isn't shown (I assume because it's just set to hide when "0"). However, the Max Hit values for Fire, Cold, and Lightning (as well as the combined Elemental Max Hit modifier if Fire Cold and Lightning Resistances are equal) all behave differently; each of these values only show as "inf" when the respective Resistance values are increased to 103%, and are shown as "0" with 104% or more resistance. I would assume the Elemental Max Hit values should behave like the Chaos Max Hit does.

Additionally, I noticed that adding any amount of Armour to the build also causes each of the Max Hit values to become negative with 104%+ resistance if any amount of "X% of Armour also applies to Elemental Damage" is applied, and the same happens to Chaos Max Hit when Chaos Resistance exceeds 100% if any amount of "X% of Armour also applies to Chaos Damage" is applied. I used the same new build, only adding the following custom modifiers in the Configuration tab:

Modifiers to Maximum Block Chance instead apply to Maximum Resistances
+500% to All Elemental Resistances
+450% to Chaos Resistance

+100% to All Maximum Resistances
+100% to Maximum Block Chance

+1 to Armour
1% of Armour also applies to Elemental Damage
1% of Armour also applies to Chaos Damage

The negative Max Hit values only seem to change when manipulating the Maximum Resistance values and when setting Character Level between 1 and 100. As maximum resistance increases via increments to +X to Maximum Block Chance, the negative Max Hit values increase. As Character Level increases, the negative Max Hit values decrease, down to -131,300 at Character Level 100 with 104% Elemental Resistance (or 101% Chaos Resistance). With Elemental Resistance values above 103% (100% for Chaos), the Max Hit values are unaffected by manipulating the +X to Armour and respective X% of Armour also applies to X Damage modifiers. At Level 100 with 102% Elemental Resistances, the Elemental Max Hit value is affected by these values (between 131300 Max Hit with 0 Armour, and 1312999 Max Hit with at least 118169811 Armour and 100% of Armour also applies to Elemental Damage).

How to reproduce the issue

Import the build, and tweak the values of the Custom Modifiers under the Configuration tab.

Remove either the first custom modifier (the Saffell's Frame modifier) or the Maximum Block Chance modifier to show that Maximum Resistances are correctly capped at 90% without this mod or the max block chance that it applies to max resistances.

For the additional Max Hit calculation behaviour described later, remove the All Maximum Resistance custom modifier, enable the bottom 3 modifiers for Armour, and set the Maximum Block Chance to 24, 25, then 26 to see Chaos Max Hit behaviour. Then set Maximum Block Chance to 27, 28, then 29 to see how Elemental Max Hit behaves the similarly, but at higher values than (I assume) it should. Also set Character Level to 100 and adjust the custom modifier values.

PoB for PoE2 build code

eNqtW91T47oOf17-ikxn7tPOoV_LAmfKnikUFmbo0tvC7r1POyZxW1-cuBM7QM9ffyQ7Xy11asPlAZJYP1mWLFlSwuCv15gHzzSVTCRnre5hpxXQJBQRSxZnrYf7qz9OWn99OxhMiFrezc8zxnGk9-3g00DfBJw-Uw7AVhByIuUPEtOz1pQkC5q2AiJDmkQX1cAPkdBWoEi6oOpnMWnnN6KXJCWhouktMhxmSoxFBIg54RIgMWHJTIRPVH1PRbbSEz4z-mKIbsaTu-l9C6T6NJhwsqbpTBEVSPh11hrC6siCjkgMvwFFeAaQzmHvqN_tHbXajajzLJXKEzpbURqV1N3DLzbCSUov53MaKvZML1KmLpYkCat5rBPsoO0e9hrJxxlXbMUZWiWH9Gz012-423nfC0X4aDKrKad_9KV_vAcgVAWwUf5iannOQZU-7BF0s0iYor6oiWBSJO9ZygbGaoSMc_AcJ9oplTR9JoptyWPlLeJHlvgpakwSciGkgx2QckJT8GTlBZjRUIDz-87hibxlc-pO6bWOHOArzfvWcTlzpfNm_D6BphDy3ChnIuOOlKoKP8c2ohF9rcKadf_eJMqF1bNAL9ov2X3KHjNFHQjR6S-vJ1VsPOkeHh_3-6enne6X4xNrrF-uJQsJH5NXFmcxxNh78kQryb4e2ffUYqkSiB02qFXWK5ZSb9CF4JE_aEmE9EaN4VC_Jkk0DMMMDv91iTi1QkYkfUqolK5BFIKiMwKd18EecLyHfyLtTRLuP6uR8CFJc2GczD2nU_BTzD8eOXVEVFPk3l65UKfTPNWCJvl8azcd3VIaLr-D7abExWMwtld66jSqFWnram1kukOtR44ADyUhcLeSek0QTyXNVgyyNBd5DOWOtXtgPJZ_mdB0sZ4tGeWRw2FToy70dUFWLusH69fRTrtgczqvjVyHetoKT0bf2Z6JrJ9Dx816MNRuKngmEd1K1-17mUI-7YWYpOJ_WKBwPxgsg3N_xDtnG9E5R5hAA8JB6YxwnWCYxiJLHXexIXYyXpEUmAJzSqMsdEtXyrLxnENR7LqMEqWV7QUdKkXCp5GIFn4W9UJsyjfLVisIWOgJrgww4YFzn9Vy0e6pA_UdeHE9TPW-NqZH7lNU1B5TlAmf-zxbEJ_1YObmsaCK3GOS0rBjiJcxnDy6RTIWtcOroUciKRh_SiKWyTFVcF-irJ2VK6i2nUpnTehYwk_EC6x4ic0r6UcNmXEJ6FtFSWny99qZ_wa50wSXSQRpNujSeY5txK5pzrP5XAahiB-JuoVtcdZqBY_wrLiG1F7S_MYg7lkM55CUI6JIEOUl2k-SMpKonu7sSUrScImgK8L5I0Qe5FQ9xbstYLfYQ4O2bkzi1U28EqkK6Cv-mZBUrYt-oibUT4CPhDNDN1sgzHHeCmZL8TKMnnHd90JwWTYhyWpFk2iDx31KaUCKoBWiEHqNeBPERCpID8zulyh0rSF6E6Hig0SAAJi4fjk6xSVigU7S9XCTMGEgF2x9Wmua9vOWq2GEs34aPExv9cWnpVIr-We7_fLycrgiainm9BWO1UOwU3sFIJD3D_nEOP8DubaH8HO-GOofzahdcBqYrqtsmzt0-pSByGaaAZwLpnIuBkCfrz_MmloBS1R5LVVaXOe82hvMBm3UmTYgKhUvfghlxvBhcTOYodgykGDT7zSW52tw3itM47YaYblVkHpGldlXdcxZS6UZxY00JxnH5__OCGe4STr1p7emw52INC7Ld2AFmwRPKMPxfr3ClQ1vb3Pz57MGLKr2pREcLy8ID82ib5JVpoJEN8djJsPf6DrY1NYK0034y6ury4v7m5-XufvUIdqEv5MsfsTGrvlbBdOZSYoCmT1Kc3nW-snoixZkRBVhHIJAKDgnK0nLja2FzleAWVIDN00FBX_RId_NqyKwc7p8pSnmbr_Ax1NGrXKV43uEMhNieo7hxsYNG9F2RibpuQAvNoWBRVO63W_ngu1363JwsAELEYxw68z56B5NKNyb4FpszkKM7c0mx51sqBr0UvZrrPbOMzY7D93ZtzEwg3aw6dXb0Plog1b1CwKrVs2oHT6iIbGu3QzawWWtKZJrLPh3cympGjj9EIne5OA0Q8Yxq7Ja9pLTksTO8E4taZofVjZOY4hRBUmj45hTwcqnRtGgK92Qs2gIx-xQ03SyrAHHGpwmb8XYvJ01u-xmw8RijzqNnZXJs606zLP2BjPkZavFBGa0YSVF08KyiHy4wVF0DB4-CxaZ-s3iMltkTUEDkpGPs9FF6f-BTdl2-DivK8jknqyWzkft8AfFMHPZwcXkOE5M0KU-xgE962McsNCI342ebichFXbanH6UJdFOcDHa5PV5pfRuDqaeezdcl5vvRuvQD_sZK-3G2F_SNMRPlSUjUEaTYziy0mLtjh_V6rx4mVNw50q9ORrvzt91NQUAQ7KHERzj1w2JohunstFyTQnHbxoE_xjDN-_0PsIM--XZiiRRwe5uV3pe2cFRe0JJ4Kmr_hG25T-qw4TG6x2M7HIN2kVBp_sBWGLlzYqZSrH2_VuI-L-6rMSrvKDs50UkJNsjBnZL9X4r5kHC_xStmcGNgqo1r2jxuixo7QwySc3r_l-UrESiEdhGMDWk4WElyuvWvAPABRSygJg8PkxvcT2m-PzOobwCHeGQaUK0mwFmkqDrD-l5QKbgSUHfA3AuhHrPMoLZC7Y_nXHDOONU-a7EZ-n69PRau0H4z_EeG_rq65xyH23p7MBLsGsKp4G3QbpeWytaB0Ua7rmSt0YZtHO_1TFHxwTdTRLJnC3y6GBu8vigQeWTDaeud5HCTCoRj0Ukq64T3LE5o6kMlAjyUyDQ-XdgavuAJVJREmFXlK_rVKYuQRp58Pmo0_kXDg45D6AMxdOX8E2SL0eGRL9bqA0dHHzu1tA72RcEuyQ8OGh_7nZPul9PT7pdzUUb4qCtQWKe3wdwQAi9Ckb1aisxTaDfCzCC11tcupce0qXgEU1zLVM8V_JvQ4tO3XGnswew8X6mgO0Dla-Dir5cATwtviKxz1f7trRA7cOUhWLZgOweN2BmS7DRDFtr8k3P0i4XPPFfDb7i80flr2Ph6NcfMtfNtU_xeLRX9Cc9O31cfpGLX5_C4R1plVyILFEzyuc11Rw56GZ7ixw1iBrRWCRXIo3fGMF5Y01ozdx9V5SPkOXKvKaqvwF2nwV9bHub9E--uhivyLzUd_hFIooCRO7bepSHsgrR67hMi0VWQvEbG5iarz38CPwbPzmAQ1l_Fre9Bdym11349YP0lGCH2oZxLNx1NguFzqo9Y0davaEozbtvUxSndunLna8Nm0-yBeN3c12Fg3i6leAq3uZXIL7hzdU9Lpb4Qme35qCAKZIEU87ou28Hg_ab__v4BwHPVHI=

Screenshots