Add support gem filtering options in Skills tab #1437
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Needs more work, at the moment the dropdown does filter by Lineage supports. But the
Highest Tier Per Familyis not implemented yet. Some Gem Families have a Lineage, others do not, and the SupportTier in the dat file shows 0 for Lineage like Brutus' Brain, so we can't just use the highest number. We also can't look for 3, as some families only have 2. Need to do some wacky combination probably.Also the isLineage is true for a bunch of persistent support gems. So slight change to exporter so that it looks for the flavour text too, as only true lineage have flavour text.
After screenshot: