Skip to content

Aftershock parsing #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Aftershock parsing #1438

wants to merge 4 commits into from
+29 −10

Conversation

@ImmotephSimon
Copy link
Contributor

@ImmotephSimon ImmotephSimon commented Sep 23, 2025

Description of the problem being solved:

Some more aftershock mods are now properly parsed, under the assumption that "you use yourself" currently means no totems, no triggers, and no traps (which are coming eventually).
Aftershocks now affect TotalDPS.
Aftershock Chance is shown with Crit Chance.

Steps taken to verify a working solution:

  • Cause mods to parse.
  • Assert that DPS is properly affected.
  • Assert that type-restrictions are working correctly (with the skills in the build below).

Link to a build that showcases this PR:

Maxroll

Before screenshot:

Red text.

After screenshot:

image
image
image

LocalIdentity
LocalIdentity requested changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@LocalIdentity LocalIdentity left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Mods / Supports

  • Hrimnor's Hymn
  • Aftershock support (I, II and III)
  • Impact Shockwave
  • Reverberate (Legacy)
  • Tremors (Legacy)
  • Seismic Cry
  • Stampede
  • Supercharged Slam
  • Volcanic Fissure

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Sep 24, 2025
@ImmotephSimon
remove sidebar label
f898b8d 
rework calcOffence to use DPS multiplier (reliant on attack time)
add support for unique: Hrimnor's Hymn
add support for Aftershock III
@ImmotephSimon
Copy link
Contributor Author

ImmotephSimon commented Sep 24, 2025 •
edited
Loading

Regarding Missing Mods / Supports

  • Hrimnor's Hymn: Done, albeit a sad implementation due to "causes aftershock"
  • Aftershock support (I, II and III): First two worked, added support for last.
  • Impact Shockwave: Don't have a good idea for that one.
  • Reverberate (Legacy): Very unlikely to be relevant again.
  • Tremors (Legacy): Independent aftershocks.
  • Seismic Cry: Complicates the MORE multiplier.
  • Stampede: Its quality is already working.
  • Supercharged Slam: Rather unrelated, just needs a better sidebar.
  • Volcanic Fissure: Hard to display properly. An aftershock is triggered by each slam.

Added all your suggestions, moved the offenceCalc code below output.Speed, as it relies on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LocalIdentity LocalIdentity Awaiting requested review from LocalIdentity

Assignees

No one assigned

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ImmotephSimon @LocalIdentity