fix: remove extra invalid glyphs in text draws

zao · zao · commit de7a6fdfebf2 · 2025-06-28T20:15:03.000+12:00
Whenever an invalid code unit was detected, a placeholder should be
emitted. This change fixes a bug where it also wrote out the original
code unit as-is.
diff --git a/engine/common/common.cpp b/engine/common/common.cpp
@@ -484,7 +484,7 @@ IndexedUTF32String IndexUTF8ToUTF32(std::string_view input)
 			byteIdx += 4;
 		}
 		else {
-			codepoints.push_back(0xFFFDu);
+			codepoint = 0xFFFDu;
 			byteIdx += 1;
 		}
 		codepoints.push_back(codepoint);

Original file line number	Diff line number	Diff line change
`@@ -484,7 +484,7 @@ IndexedUTF32String IndexUTF8ToUTF32(std::string_view input)`
`484`	`484`	`byteIdx += 4;`
`485`	`485`	`}`
`486`	`486`	`else {`
`487`		`- codepoints.push_back(0xFFFDu);`
	`487`	`+ codepoint = 0xFFFDu;`
`488`	`488`	`byteIdx += 1;`
`489`	`489`	`}`
`490`	`490`	`codepoints.push_back(codepoint);`