Merge branch 'dev'

Author: LocalIdentity

CHANGELOG.md

@@ -1,5 +1,26 @@
 # Changelog
 
+## [v2.58.1](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/tree/v2.58.1) (2025/11/05)
+
+[Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding/compare/v2.58.0...v2.58.1)
+
+
+## What's Changed
+### User Interface
+- Fix incorrect tooltip when crafting some flask mods [\#9164](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/9164) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix Damage Gain breakdown including skill conversion [\#9170](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/9170) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix insufficient skill cost warning applying to other skills [\#9172](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/9172) ([LocalIdentity](https://github.com/LocalIdentity))
+### Fixed Calculations
+- Fix Spectre conversion multiplier applying to "gain as x" mods and Chaos damage [\#9168](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/9168) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix Pyroclast Mine Exposure being inverted and unscalable [\#9160](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/9160) ([LocalIdentity](https://github.com/LocalIdentity))
+### Fixed Behaviours
+- Fix Intuitive Leap, Thread of Hope and Impossible Escape not parsing correctly [\#9167](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/9167) ([Wires77](https://github.com/Wires77))
+- Fix mod order when crafting Grafts [\#9163](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/9163) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix "Farewell to Flesh" not applying to Agony Crawler ailment damage [\#9162](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/9162) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix Dying Breath Curse effect mod not working [\#9173](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/9173) ([LocalIdentity](https://github.com/LocalIdentity))
+
+
+
 ## [v2.58.0](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/tree/v2.58.0) (2025/11/03)
 
 [Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding/compare/v2.57.0...v2.58.0)

changelog.txt

@@ -1,3 +1,21 @@
+VERSION[2.58.1][2025/11/05]
+
+--- User Interface ---
+- Fix incorrect tooltip when crafting some flask mods (LocalIdentity)
+- Fix Damage Gain breakdown including skill conversion (LocalIdentity)
+- Fix insufficient skill cost warning applying to other skills (LocalIdentity)
+
+--- Fixed Calculations ---
+- Fix Spectre conversion multiplier applying to "gain as x" mods and Chaos damage (LocalIdentity)
+- Fix Pyroclast Mine Exposure being inverted and unscalable (LocalIdentity)
+
+--- Fixed Behaviours ---
+- Fix Intuitive Leap, Thread of Hope and Impossible Escape not parsing correctly (Wires77)
+- Fix mod order when crafting Grafts (LocalIdentity)
+- Fix "Farewell to Flesh" not applying to Agony Crawler ailment damage (LocalIdentity)
+- Fix Dying Breath Curse effect mod not working (LocalIdentity)
+
+
 VERSION[2.58.0][2025/11/03]
 
 --- Keepers of the Flame ---

manifest.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <PoBVersion>
-	<Version number="2.58.0" />
+	<Version number="2.58.1" />
 	<Source part="default" url="https://raw.githubusercontent.com/PathOfBuildingCommunity/PathOfBuilding/{branch}/" />
 	<Source part="runtime" platform="win32" url="https://raw.githubusercontent.com/PathOfBuildingCommunity/PathOfBuilding/{branch}/runtime/" />
 	<Source part="program" url="https://raw.githubusercontent.com/PathOfBuildingCommunity/PathOfBuilding/{branch}/src/" />

src/Classes/CalcBreakdownControl.lua

@@ -201,6 +201,7 @@ function CalcBreakdownClass:AddBreakdownSection(sectionData)
 				{ label = "Converted Damage", key = "convSrc" },
 				{ label = "Total", key = "total" },
 				{ label = "Conversion", key = "convDst" },
+				{ label = "Gain", key = "gainDst" },
 			}
 		}
 		t_insert(self.sectionList, section)

src/Classes/ItemsTab.lua

@@ -852,6 +852,7 @@ holding Shift will put it in the second.]])
 				tooltip:Clear()
 			elseif tooltip:CheckForUpdate(val, modList) then
 				local index, range = slider:GetDivVal(val)
+				range = verifyRange(range, index, drop)
 				local modId = modList[index]
 				local mod = self.displayItem.affixes[modId]
 				for _, line in ipairs(mod) do
@@ -1752,7 +1753,10 @@ function ItemsTabClass:UpdateAffixControl(control, item, type, outputTable, outp
 				return modA.statOrder[i] < modB.statOrder[i]
 			end
 		end
-		return modA.level > modB.level
+		if modA.level ~= modB.level then
+			return modA.level < modB.level
+		end
+		return a < b
 	end)
 	control.selIndex = 1
 	control.list = { "None" }
@@ -1796,7 +1800,7 @@ function ItemsTabClass:UpdateAffixControl(control, item, type, outputTable, outp
 			if selAffix == modId then
 				control.selIndex = #control.list
 			end
-			t_insert(lastSeries.modList, 1, modId)
+			t_insert(lastSeries.modList, modId)
 			if #lastSeries.modList == 2 then
 				lastSeries.label = lastSeries.label:gsub("%(%-?[%d%.]+%-%-?[%d%.]+%)","#"):gsub("%-?%d+%.?%d*","#")
 				lastSeries.haveRange = true

src/Classes/ModStore.lua

@@ -251,7 +251,7 @@ function ModStoreClass:GetStat(stat, cfg)
 			for _, activeSkill in ipairs(self.actor.activeSkillList) do
 				if (activeSkill.skillTypes[SkillType.HasReservation] and not activeSkill.skillFlags.disable and activeSkill.buffList and activeSkill.buffList[1] and cfg and (isNameInBuffList(activeSkill.buffList, cfg.skillName) or isNameInBuffList(activeSkill.buffList, cfg.summonSkillName)) ) then
 					local manaBase = activeSkill.skillData["ManaReservedBase"] or 0
-					reservedPercentMana = manaBase / totalMana * 100
+					reservedPercentMana = m_floor(manaBase / totalMana * 100)
 					break
 				end
 			end
@@ -265,7 +265,7 @@ function ModStoreClass:GetStat(stat, cfg)
 			for _, activeSkill in ipairs(self.actor.activeSkillList) do
 				if (activeSkill.skillTypes[SkillType.HasReservation] and not activeSkill.skillFlags.disable and activeSkill.buffList and activeSkill.buffList[1] and cfg and (isNameInBuffList(activeSkill.buffList, cfg.skillName) or isNameInBuffList(activeSkill.buffList, cfg.summonSkillName)) ) then
 					local lifeBase = activeSkill.skillData["LifeReservedBase"] or 0
-					reservedPercentLife = lifeBase / totalLife * 100
+					reservedPercentLife = m_floor(lifeBase / totalLife * 100)
 					break
 				end
 			end