Skip to content

Commit 3c50e8a

Browse files
NL908LocalIdentity
andauthored
Fix Might of the Meek not working with Light of Meaning (#9220)
* Fix interaction caused by string parsing not parsing to There's a type check when calculating Increased Effect that needs the value to be "number". * regex instead of hardcode * Fix missing tonumber values --------- Co-authored-by: LocalIdentity <[email protected]>
1 parent 15876b7 commit 3c50e8a

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

src/Modules/ModParser.lua

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -5718,7 +5718,7 @@ local jewelOtherFuncs = {
57185718
["(%d+)%% increased Effect of non%-Keystone Passive Skills in Radius"] = function(num)
57195719
return function(node, out, data)
57205720
if node and node.type ~= "Keystone" and node.type ~= "ClassStart" then
5721-
out:NewMod("PassiveSkillEffect", "INC", num, data.modSource)
5721+
out:NewMod("PassiveSkillEffect", "INC", tonumber(num), data.modSource)
57225722
end
57235723
end
57245724
end,
@@ -5730,7 +5730,7 @@ local jewelOtherFuncs = {
57305730
["(%d+)%% increased effect of Tattoos in Radius"] = function(num)
57315731
return function(node, out, data)
57325732
if node and node.isTattoo then
5733-
out:NewMod("PassiveSkillEffect", "INC", num, data.modSource)
5733+
out:NewMod("PassiveSkillEffect", "INC", tonumber(num), data.modSource)
57345734
end
57355735
end
57365736
end,
@@ -5742,15 +5742,15 @@ local jewelOtherFuncs = {
57425742
["Passive Skills in Radius also grant: Traps and Mines deal (%d+) to (%d+) added Physical Damage"] = function(min, max)
57435743
return function(node, out, data)
57445744
if node and node.type ~= "Keystone" and node.type ~= "ClassStart" then
5745-
out:NewMod("PhysicalMin", "BASE", min, data.modSource, 0, bor(KeywordFlag.Trap, KeywordFlag.Mine))
5746-
out:NewMod("PhysicalMax", "BASE", max, data.modSource, 0, bor(KeywordFlag.Trap, KeywordFlag.Mine))
5745+
out:NewMod("PhysicalMin", "BASE", tonumber(min), data.modSource, 0, bor(KeywordFlag.Trap, KeywordFlag.Mine))
5746+
out:NewMod("PhysicalMax", "BASE", tonumber(max), data.modSource, 0, bor(KeywordFlag.Trap, KeywordFlag.Mine))
57475747
end
57485748
end
57495749
end,
57505750
["Passive Skills in Radius also grant: (%d+)%% increased Unarmed Attack Speed with Melee Skills"] = function(num)
57515751
return function(node, out, data)
57525752
if node and node.type ~= "Keystone" and node.type ~= "ClassStart" then
5753-
out:NewMod("Speed", "INC", num, data.modSource, bor(ModFlag.Unarmed, ModFlag.Attack, ModFlag.Melee))
5753+
out:NewMod("Speed", "INC", tonumber(num), data.modSource, bor(ModFlag.Unarmed, ModFlag.Attack, ModFlag.Melee))
57545754
end
57555755
end
57565756
end,
@@ -5764,59 +5764,59 @@ local jewelOtherFuncs = {
57645764
["Passive Skills in Radius also grant %+(%d+) to Maximum Life"] = function(num)
57655765
return function(node, out, data)
57665766
if node and node.type ~= "Keystone" and node.type ~= "Socket" and node.type ~= "ClassStart" then
5767-
out:NewMod("Life", "BASE", num, data.modSource)
5767+
out:NewMod("Life", "BASE", tonumber(num), data.modSource)
57685768
end
57695769
end
57705770
end,
57715771
["Passive Skills in Radius also grant %+(%d+) to Maximum Mana"] = function(num)
57725772
return function(node, out, data)
57735773
if node and node.type ~= "Keystone" and node.type ~= "Socket" and node.type ~= "ClassStart" then
5774-
out:NewMod("Mana", "BASE", num, data.modSource)
5774+
out:NewMod("Mana", "BASE", tonumber(num), data.modSource)
57755775
end
57765776
end
57775777
end,
57785778
["Passive Skills in Radius also grant (%d+)%% increased Energy Shield"] = function(num)
57795779
return function(node, out, data)
57805780
if node and node.type ~= "Keystone" and node.type ~= "Socket" and node.type ~= "ClassStart" then
5781-
out:NewMod("EnergyShield", "INC", num, data.modSource)
5781+
out:NewMod("EnergyShield", "INC", tonumber(num), data.modSource)
57825782
end
57835783
end
57845784
end,
57855785
["Passive Skills in Radius also grant (%d+)%% increased Armour"] = function(num)
57865786
return function(node, out, data)
57875787
if node and node.type ~= "Keystone" and node.type ~= "Socket" and node.type ~= "ClassStart" then
5788-
out:NewMod("Armour", "INC", num, data.modSource)
5788+
out:NewMod("Armour", "INC", tonumber(num), data.modSource)
57895789
end
57905790
end
57915791
end,
57925792
["Passive Skills in Radius also grant (%d+)%% increased Evasion Rating"] = function(num)
57935793
return function(node, out, data)
57945794
if node and node.type ~= "Keystone" and node.type ~= "Socket" and node.type ~= "ClassStart" then
5795-
out:NewMod("Evasion", "INC", num, data.modSource)
5795+
out:NewMod("Evasion", "INC", tonumber(num), data.modSource)
57965796
end
57975797
end
57985798
end,
57995799
["Passive Skills in Radius also grant %+(%d+) to all Attributes"] = function(num)
58005800
return function(node, out, data)
58015801
if node and node.type ~= "Keystone" and node.type ~= "Socket" and node.type ~= "ClassStart" then
5802-
out:NewMod("Str", "BASE", num, data.modSource)
5803-
out:NewMod("Dex", "BASE", num, data.modSource)
5804-
out:NewMod("Int", "BASE", num, data.modSource)
5805-
out:NewMod("All", "BASE", num, data.modSource)
5802+
out:NewMod("Str", "BASE", tonumber(num), data.modSource)
5803+
out:NewMod("Dex", "BASE", tonumber(num), data.modSource)
5804+
out:NewMod("Int", "BASE", tonumber(num), data.modSource)
5805+
out:NewMod("All", "BASE", tonumber(num), data.modSource)
58065806
end
58075807
end
58085808
end,
58095809
["Passive Skills in Radius also grant %+(%d+)%% to Chaos Resistance"] = function(num)
58105810
return function(node, out, data)
58115811
if node and node.type ~= "Keystone" and node.type ~= "Socket" and node.type ~= "ClassStart" then
5812-
out:NewMod("ChaosResist", "BASE", num, data.modSource)
5812+
out:NewMod("ChaosResist", "BASE", tonumber(num), data.modSource)
58135813
end
58145814
end
58155815
end,
58165816
["Passive Skills in Radius also grant (%d+)%% increased (%w+) Damage"] = function(num, type)
58175817
return function(node, out, data)
58185818
if node and node.type ~= "Keystone" and node.type ~= "Socket" and node.type ~= "ClassStart" then
5819-
out:NewMod(firstToUpper(type).."Damage", "INC", num, data.modSource)
5819+
out:NewMod(firstToUpper(type).."Damage", "INC", tonumber(num), data.modSource)
58205820
end
58215821
end
58225822
end,
@@ -5841,7 +5841,7 @@ local jewelOtherFuncs = {
58415841
return function(node, out, data)
58425842
if node and node.type == "Notable" then
58435843
out:NewMod("PassiveSkillHasOtherEffect", "FLAG", true, data.modSource)
5844-
out:NewMod("NodeModifier", "LIST", { mod = mod("MinionModifier", "LIST", { mod = mod("MovementSpeed", "INC", -num, data.modSource) }) }, data.modSource)
5844+
out:NewMod("NodeModifier", "LIST", { mod = mod("MinionModifier", "LIST", { mod = mod("MovementSpeed", "INC", -tonumber(num), data.modSource) }) }, data.modSource)
58455845
end
58465846
end
58475847
end,

0 commit comments

Comments
 (0)