Fix Penance Mark not counting the enemy as cursed (#9301)

* Add Penance Mark Minion + fix skill not counting the enemy as cursed

Penance Mark wasn't counting the enemy as cursed as it didn't have any mods stat mapped to it with a global effect. Added a dummy mod for the phantasm spawn so it now works correctly

* Remove spec change

---------

Co-authored-by: LocalIdentity <[email protected]>

Author: LocalIdentity

src/Data/Minions.lua

@@ -652,7 +652,6 @@ minions["UniqueAnimatedWeapon"] = {
 		mod("Damage", "MORE", 70), -- MonsterUnique5,
 		mod("Speed", "MORE", 33, ModFlag.Attack), -- MonsterUnique8,
 		mod("Damage", "MORE", -33, ModFlag.Attack), -- MonsterUnique8,
-		mod("DamageTaken", "MORE", -95), -- monster_inherent_damage_taken_+%_final : UniqueAnimatedWeapon.ot,
 	},
 }
 
@@ -1722,3 +1721,36 @@ minions["LivingLightningMinion"] = {
 		mod("AvoidProjectilesChance", "BASE", 100, 0, 0), -- set_base_avoid_projectiles_%_chance [set_base_avoid_projectiles_%_chance = 100]
 	},
 }
+
+minions["PenanceMarkPhantasm"] = {
+	name = "Shackled Phantasm",
+	monsterTags = { "caster", "fire_affinity", "ghost", "ghost_armour", "ghost_blood", "is_unarmed", "medium_movement", "slashing_weapon", "undead", },
+	life = 1.3,
+	fireResist = 40,
+	coldResist = 40,
+	lightningResist = 40,
+	chaosResist = 20,
+	damage = 0.9,
+	damageSpread = 0.2,
+	attackTime = 1.755,
+	attackRange = 6,
+	accuracy = 1,
+	limit = "ActiveVoidSpawnLimit",
+	skillList = {
+		"MPSPhantasmBasicBlood",
+	},
+	modList = {
+		-- MonsterNoDropsOrExperience [monster_no_drops_or_experience = 1]
+		-- CannotSpawnBeyondPortals [monster_no_beyond_portal = 1]
+		mod("KnockbackImmune", "FLAG", 1, 0, 0), -- ImmuneToKnockback [cannot_be_knocked_back = 1]
+		-- CannotBeAugmented [cannot_have_azmeri_dust = 1]
+		-- CannotBeAugmented [cant_possess_this = 1]
+		-- CannotBeAugmented [cant_touch_this = 1]
+		-- CannotBeAugmented [cannot_be_tagged_by_sentinel = 1]
+		-- CannotBeAugmented [cannot_be_afflicted = 1]
+		-- CannotBeAugmented [cannot_have_affliction_mods = 1]
+		-- set_monster_no_drops_or_experience [set_monster_no_drops_or_experience = 1]
+		mod("CurseImmune", "FLAG", 1, 0, 0), -- set_immune_to_curses [set_immune_to_curses = 1]
+		-- set_monster_can_grant_vaal_souls_if_no_experience [set_monster_can_grant_vaal_souls_if_no_experience = 1]
+	},
+}

src/Data/Skills/minion.lua

@@ -2119,4 +2119,37 @@ skills["SummonedLivingLightningZap"] = {
 	levels = {
 		[1] = { cooldown = 0.25, levelRequirement = 0, storedUses = 1, },
 	},
+}
+skills["MPSPhantasmBasicBlood"] = {
+	name = "Projectile Spell",
+	hidden = true,
+	color = 4,
+	baseEffectiveness = 1.1059999465942,
+	incrementalEffectiveness = 0.035999998450279,
+	skillTypes = { [SkillType.Spell] = true, [SkillType.Projectile] = true, [SkillType.ProjectilesFromUser] = true, [SkillType.Triggerable] = true, },
+	statDescriptionScope = "skill_stat_descriptions",
+	castTime = 1.17,
+	baseFlags = {
+		spell = true,
+		projectile = true,
+	},
+	constantStats = {
+		{ "monster_projectile_variation", 248 },
+		{ "spell_maximum_action_distance_+%", -40 },
+	},
+	stats = {
+		"spell_minimum_base_physical_damage",
+		"spell_maximum_base_physical_damage",
+		"projectile_uses_contact_position",
+		"use_scaled_contact_offset",
+		"maintain_projectile_direction_when_using_contact_position",
+		"base_is_projectile",
+	},
+	notMinionStat = {
+		"spell_minimum_base_physical_damage",
+		"spell_maximum_base_physical_damage",
+	},
+	levels = {
+		[1] = { 0.80000001192093, 1.2000000476837, levelRequirement = 0, statInterpolation = { 3, 3, }, },
+	},
 }

src/Data/Skills/other.lua

@@ -2388,7 +2388,15 @@ skills["PenanceMark"] = {
 	skillTypes = { [SkillType.Spell] = true, [SkillType.Trappable] = true, [SkillType.Totemable] = true, [SkillType.Mineable] = true, [SkillType.Multicastable] = true, [SkillType.Triggerable] = true, [SkillType.AppliesCurse] = true, [SkillType.CanRapidFire] = true, [SkillType.InstantNoRepeatWhenHeld] = true, [SkillType.InstantShiftAttackForLeftMouse] = true, [SkillType.Mark] = true, [SkillType.Duration] = true, },
 	statDescriptionScope = "brand_skill_stat_descriptions",
 	castTime = 0.5,
-	fromTree = true,
+	fromItem = true,
+	minionList = {
+		"PenanceMarkPhantasm",
+	},
+	statMap = {
+		["penance_mark_summon_phantasms_when_hit"] = {
+			mod("SummonPhantasmWhenHit", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Curse" }),
+		},
+	},
 	baseFlags = {
 		spell = true,
 		curse = true,

src/Export/Minions/Minions.txt

@@ -95,7 +95,6 @@ local minions, mod = ...
 #mod mod("Damage", "MORE", 70), -- MonsterUnique5
 #mod mod("Speed", "MORE", 33, ModFlag.Attack), -- MonsterUnique8
 #mod mod("Damage", "MORE", -33, ModFlag.Attack), -- MonsterUnique8
-#mod mod("DamageTaken", "MORE", -95), -- monster_inherent_damage_taken_+%_final : UniqueAnimatedWeapon.ot
 #emit
 
 #monster Metadata/Monsters/SummonedPhantasm/SummonedPhantasm SummonedPhantasm
@@ -240,4 +239,8 @@ minions["GuardianRelicAll"] = {
 
 #monster Metadata/Monsters/LivingLightning/LivingLightningSummoned LivingLightningMinion
 #limit ActiveLivingLightningLimit
+#emit
+
+#monster Metadata/Monsters/SummonedPhantasm/SummonedPhantasmPenanceMark PenanceMarkPhantasm
+#limit ActiveVoidSpawnLimit
 #emit

src/Export/Skills/minion.txt

@@ -431,4 +431,8 @@ skills["GuardianSentinelFireAura"] = {
 
 #skill SummonedLivingLightningZap
 #flags attack melee
+#mods
+
+#skill MPSPhantasmBasicBlood Projectile Spell
+#flags spell projectile
 #mods

src/Export/Skills/other.txt

@@ -649,7 +649,15 @@ local skills, mod, flag, skill = ...
 
 #skill PenanceMark
 #flags spell curse duration mark
-	fromTree = true,
+	fromItem = true,
+	minionList = {
+		"PenanceMarkPhantasm",
+	},
+	statMap = {
+		["penance_mark_summon_phantasms_when_hit"] = {
+			mod("SummonPhantasmWhenHit", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Curse" }),
+		},
+	},
 #baseMod skill("debuff", true)
 #mods