Add support for Kinetic Fusillade

Introduce support for Kinetic Fusillade's sequential fire damage mod.

Add support for DPS calculations considering all available projectiles
while factoring in duration and attack rate for effective dps calcs.

Signed-off-by: Justin Stitt <[email protected]>

Author: JustinStitt

src/Data/Skills/act_int.lua

@@ -11142,6 +11142,48 @@ skills["KineticFusillade"] = {
 	},
 	statDescriptionScope = "skill_stat_descriptions",
 	castTime = 1,
+	parts = {
+		{
+			name = "1 Projectile"
+		},
+		{
+			name = "All Projectiles",
+		},
+	},
+	preDamageFunc = function(activeSkill, output)
+		if activeSkill.skillPart == 2 then
+			activeSkill.skillData.dpsMultiplier = output.ProjectileCount
+
+			-- Calculate average damage scaling for sequential projectiles
+			-- Each projectile does more damage based on how many came before it
+			local moreDamagePerProj = activeSkill.skillModList:Sum("MORE", activeSkill.skillCfg, "KineticFusilladeSequentialDamage") or 0
+			if moreDamagePerProj ~= 0 and output.ProjectileCount > 1 then
+				-- Average multiplier: sum of (0, X, 2X, 3X, ..., (n-1)X) / n
+				-- This equals: X * (0 + 1 + 2 + ... + (n-1)) / n = X * n(n-1)/2 / n = X * (n-1)/2
+				local avgMoreMult = moreDamagePerProj * (output.ProjectileCount - 1) / 2
+				activeSkill.skillModList:NewMod("Damage", "MORE", avgMoreMult, "Skill:KineticFusillade")
+			end
+		end
+
+		-- Calculate effective attack rate accounting for delayed projectile firing
+		-- Projectiles orbit for base_skill_effect_duration before firing
+		-- Recasting resets the timer, so maximum effective rate is 1 / (duration rounded to server ticks)
+		local baseDuration = activeSkill.skillData.duration or 0.7
+		local actualDuration = output.Duration or baseDuration
+		local ticksNeeded = math.ceil(actualDuration / data.misc.ServerTickTime)
+		local effectiveDelay = ticksNeeded * data.misc.ServerTickTime
+		local maxEffectiveAPS = 1 / effectiveDelay
+
+		-- Store the maximum effective attack rate for display
+		output.KineticFusilladeMaxEffectiveAttackRate = maxEffectiveAPS
+	end,
+	statMap = {
+		["kinetic_fusillade_damage_+%_final_per_projectile_fired"] = {
+			mod("KineticFusilladeSequentialDamage", "MORE", nil),
+		},
+		["quality_display_kinetic_fusillade_is_gem"] = {
+		},
+	},
 	baseFlags = {
 		attack = true,
 		projectile = true,

src/Export/Skills/act_int.txt

@@ -2265,6 +2265,48 @@ local skills, mod, flag, skill = ...
 
 #skill KineticFusillade
 #flags attack projectile area duration
+	parts = {
+		{
+			name = "1 Projectile"
+		},
+		{
+			name = "All Projectiles",
+		},
+	},
+	preDamageFunc = function(activeSkill, output)
+		if activeSkill.skillPart == 2 then
+			activeSkill.skillData.dpsMultiplier = output.ProjectileCount
+
+			-- Calculate average damage scaling for sequential projectiles
+			-- Each projectile does more damage based on how many came before it
+			local moreDamagePerProj = activeSkill.skillModList:Sum("MORE", activeSkill.skillCfg, "KineticFusilladeSequentialDamage") or 0
+			if moreDamagePerProj ~= 0 and output.ProjectileCount > 1 then
+				-- Average multiplier: sum of (0, X, 2X, 3X, ..., (n-1)X) / n
+				-- This equals: X * (0 + 1 + 2 + ... + (n-1)) / n = X * n(n-1)/2 / n = X * (n-1)/2
+				local avgMoreMult = moreDamagePerProj * (output.ProjectileCount - 1) / 2
+				activeSkill.skillModList:NewMod("Damage", "MORE", avgMoreMult, "Skill:KineticFusillade")
+			end
+		end
+
+		-- Calculate effective attack rate accounting for delayed projectile firing
+		-- Projectiles orbit for base_skill_effect_duration before firing
+		-- Recasting resets the timer, so maximum effective rate is 1 / (duration rounded to server ticks)
+		local baseDuration = activeSkill.skillData.duration or 0.7
+		local actualDuration = output.Duration or baseDuration
+		local ticksNeeded = math.ceil(actualDuration / data.misc.ServerTickTime)
+		local effectiveDelay = ticksNeeded * data.misc.ServerTickTime
+		local maxEffectiveAPS = 1 / effectiveDelay
+
+		-- Store the maximum effective attack rate for display
+		output.KineticFusilladeMaxEffectiveAttackRate = maxEffectiveAPS
+	end,
+	statMap = {
+		["kinetic_fusillade_damage_+%_final_per_projectile_fired"] = {
+			mod("KineticFusilladeSequentialDamage", "MORE", nil),
+		},
+		["quality_display_kinetic_fusillade_is_gem"] = {
+		},
+	},
 #mods
 
 #skill KineticRain

src/Modules/BuildDisplayStats.lua

@@ -61,6 +61,9 @@ local displayStats = {
 	{ stat = "WithImpaleDPS", label = "Total DPS inc. Impale", fmt = ".1f", compPercent = true, flag = "impale", flag = "notAverage", condFunc = function(v,o) return v ~= o.TotalDPS and (o.TotalDot or 0) == 0 and (o.IgniteDPS or 0) == 0 and (o.PoisonDPS or 0) == 0 and (o.BleedDPS or 0) == 0 end },
 	{ stat = "MirageDPS", label = "Total Mirage DPS", fmt = ".1f", compPercent = true, flag = "mirageArcher", condFunc = function(v,o) return v > 0 end },
 	{ stat = "MirageDPS", label = "Total Wisp DPS", fmt = ".1f", compPercent = true, flag = "wisp", condFunc = function(v,o) return v > 0 end },
+	{ stat = "KineticFusilladeMaxEffectiveAttackRate", label = "Max Effective Attack Rate", fmt = ".2f", condFunc = function(v,o) return (o.KineticFusilladeMaxEffectiveAttackRate or 0) > 0 end },
+	{ stat = "KineticFusilladeEffectiveDPS", label = "Effective DPS", fmt = ".1f", compPercent = true, condFunc = function(v,o) return (o.KineticFusilladeEffectiveDPS or 0) > 0 end },
+	{ stat = "KineticFusilladeWastedDPS", label = "Wasted DPS", fmt = ".1f", condFunc = function(v,o) return (o.KineticFusilladeWastedDPS or 0) > 0 end },
 	{ stat = "CullingDPS", label = "Culling DPS", fmt = ".1f", compPercent = true, condFunc = function(v,o) return (o.CullingDPS or 0) > 0 end },
 	{ stat = "ReservationDPS", label = "Reservation DPS", fmt = ".1f", compPercent = true, condFunc = function(v,o) return (o.ReservationDPS or 0) > 0 end },
 	{ stat = "CombinedDPS", label = "Combined DPS", fmt = ".1f", compPercent = true, flag = "notAverage", condFunc = function(v,o) return v ~= ((o.TotalDPS or 0) + (o.TotalDot or 0)) and v ~= o.WithImpaleDPS and ( o.showTotalDotDPS or ( v ~= o.WithPoisonDPS and v ~= o.WithIgniteDPS and v ~= o.WithBleedDPS ) ) end },
@@ -245,4 +248,4 @@ local extraSaveStats = {
 	"ActiveMinionLimit",
 }
 
-return displayStats, minionDisplayStats, extraSaveStats
+return displayStats, minionDisplayStats, extraSaveStats

src/Modules/CalcOffence.lua

@@ -5813,4 +5813,33 @@ function calcs.offence(env, actor, activeSkill)
 	output.CullingDPS = output.CombinedDPS * (bestCull - 1)
 	output.ReservationDPS = output.CombinedDPS * (output.ReservationDpsMultiplier - 1)
 	output.CombinedDPS = output.CombinedDPS * bestCull * output.ReservationDpsMultiplier
+
+	-- Kinetic Fusillade: Calculate effective DPS accounting for projectile firing delay
+	if output.KineticFusilladeMaxEffectiveAttackRate then
+		local maxEffectiveAPS = output.KineticFusilladeMaxEffectiveAttackRate
+		if output.Speed and output.Speed > maxEffectiveAPS then
+			-- Attacking faster than the projectiles can fire wasts some DPS
+			local efficiencyRatio = maxEffectiveAPS / output.Speed
+			output.KineticFusilladeEffectiveDPS = output.TotalDPS * efficiencyRatio
+			output.KineticFusilladeWastedDPS = output.TotalDPS - output.KineticFusilladeEffectiveDPS
+		else
+			-- attack rate is within effective limits
+			output.KineticFusilladeEffectiveDPS = output.TotalDPS
+			output.KineticFusilladeWastedDPS = 0
+		end
+		if breakdown then
+			breakdown.KineticFusilladeEffectiveDPS = {}
+			if output.Speed then
+				t_insert(breakdown.KineticFusilladeEffectiveDPS, s_format("%.2f ^8(current attack rate)", output.Speed))
+			end
+			t_insert(breakdown.KineticFusilladeEffectiveDPS, s_format("%.2f ^8(max effective attack rate)", maxEffectiveAPS))
+			if output.Speed and output.Speed > maxEffectiveAPS then
+				t_insert(breakdown.KineticFusilladeEffectiveDPS, s_format("%.2f ^8(efficiency: max/current)", maxEffectiveAPS / output.Speed))
+				t_insert(breakdown.KineticFusilladeEffectiveDPS, s_format("%.1f ^8(total DPS)", output.TotalDPS))
+				t_insert(breakdown.KineticFusilladeEffectiveDPS, s_format("= %.1f ^8(effective DPS)", output.KineticFusilladeEffectiveDPS))
+			else
+				t_insert(breakdown.KineticFusilladeEffectiveDPS, "^8Attack rate is within effective limits")
+			end
+		end
+	end
 end

src/Modules/CalcSections.lua

@@ -345,6 +345,9 @@ return {
 		{ label = "DPS Multiplier", modName = "DPS" }, 
 	}, },
 	{ label = "Skill DPS", flag = "triggered", { format = "{1:output:TotalDPS}", { breakdown = "TotalDPS" }, { label = "DPS Multiplier", modName = "DPS" }, }, },
+	{ label = "Max Effective APS", haveOutput = "KineticFusilladeMaxEffectiveAttackRate", { format = "{2:output:KineticFusilladeMaxEffectiveAttackRate}", }, },
+	{ label = "Effective DPS", haveOutput = "KineticFusilladeEffectiveDPS", { format = "{1:output:KineticFusilladeEffectiveDPS}", { breakdown = "KineticFusilladeEffectiveDPS" }, }, },
+	{ label = "Wasted DPS", haveOutput = "KineticFusilladeWastedDPS", { format = "{1:output:KineticFusilladeWastedDPS}", }, },
 } }
 } },
 { 3, "Warcries", 1, colorCodes.OFFENCE, {{ defaultCollapsed = false, label = "Exerting Warcries", data = {