Fix crash when sorting some gems by Full DPS (#9143)

* Fix crash when sorting some gems by Full DPS

When we were checking to see if a gem could be affected by a possible support gem we were not considering if the gem had a additional granted effect which was the supporting part of the gem
Instead of using the granted effect of the support, we were using the granted effect of the gem which caused a bunch of issues for the code that only expects to deal with supports
Also applied this logic to cross linked supports too as I noticed it had a similar issue
Also made cross link supports skip it's own socketgroup as it's trying to look for other socketgroups that can support it
e.g. Ngamahu's Flame was checking it's own Molten Burst gem group which couldn't possible have supports

* Fix error with supports granted by items

Supports granted by many items do not have any gemData as they are just a grantedEffect

* Fix test issues

* Use function to remove duplicate code

---------

Co-authored-by: LocalIdentity <[email protected]>

Author: LocalIdentity

src/Modules/CalcActiveSkill.lua

@@ -107,13 +107,36 @@ function calcs.createActiveSkill(activeEffect, supportList, actor, socketGroup,
 	activeSkill.effectList = { activeEffect }
 	local rejectedSupportsIndices = {}
 
+	-- Return first compatible support grantedEffect plus a flag indicating the support has a support component
+	local function getGrantedSupportEffect(supportEffect)
+		local hasSupport = false
+		if supportEffect.gemData then
+			for _, grantedEffect in ipairs(supportEffect.gemData.grantedEffectList) do
+				if grantedEffect and grantedEffect.support then
+					hasSupport = true
+					if calcLib.canGrantedEffectSupportActiveSkill(grantedEffect, activeSkill) then
+						return grantedEffect, true
+					end
+				end
+			end
+		elseif supportEffect.grantedEffect then
+			hasSupport = true
+			if calcLib.canGrantedEffectSupportActiveSkill(supportEffect.grantedEffect, activeSkill) then
+				return supportEffect.grantedEffect, true
+			end
+		end
+		return nil, hasSupport
+	end
+
 	for index, supportEffect in ipairs(supportList) do
-		-- Pass 1: Add skill types from compatible supports
-		if calcLib.canGrantedEffectSupportActiveSkill(supportEffect.grantedEffect, activeSkill) then
-			for _, skillType in pairs(supportEffect.grantedEffect.addSkillTypes) do
+		-- Loop through grantedEffectList until we find a support gem if the gem has an active and support component e.g. Autoexertion
+		local grantedSupportEffect, hasSupport = getGrantedSupportEffect(supportEffect)
+		if grantedSupportEffect then
+			-- Pass 1: Add skill types from compatible supports
+			for _, skillType in pairs(grantedSupportEffect.addSkillTypes) do
 				activeSkill.skillTypes[skillType] = true
 			end
-		else
+		elseif hasSupport then
 			t_insert(rejectedSupportsIndices, index)
 		end
 	end
@@ -125,10 +148,11 @@ function calcs.createActiveSkill(activeEffect, supportList, actor, socketGroup,
 		notAddedNewSupport = true
 		for index, supportEffectIndex in ipairs(rejectedSupportsIndices) do
 			local supportEffect = supportList[supportEffectIndex]
-			if calcLib.canGrantedEffectSupportActiveSkill(supportEffect.grantedEffect, activeSkill) then
+			local grantedSupportEffect = getGrantedSupportEffect(supportEffect)
+			if grantedSupportEffect then
 				notAddedNewSupport = false
 				rejectedSupportsIndices[index] = nil
-				for _, skillType in pairs(supportEffect.grantedEffect.addSkillTypes) do
+				for _, skillType in pairs(grantedSupportEffect.addSkillTypes) do
 					activeSkill.skillTypes[skillType] = true
 				end
 			end
@@ -137,14 +161,15 @@ function calcs.createActiveSkill(activeEffect, supportList, actor, socketGroup,
 
 	for _, supportEffect in ipairs(supportList) do
 		-- Pass 2: Add all compatible supports
-		if calcLib.canGrantedEffectSupportActiveSkill(supportEffect.grantedEffect, activeSkill) then
+		local grantedSupportEffect = getGrantedSupportEffect(supportEffect)
+		if grantedSupportEffect then
 			t_insert(activeSkill.effectList, supportEffect)
 			if supportEffect.isSupporting and activeEffect.srcInstance then
 				supportEffect.isSupporting[activeEffect.srcInstance] = true
 			end
-			if supportEffect.grantedEffect.addFlags and not summonSkill then
+			if grantedSupportEffect.addFlags and not summonSkill then
 				-- Support skill adds flags to supported skills (eg. Remote Mine adds 'mine')
-				for k in pairs(supportEffect.grantedEffect.addFlags) do
+				for k in pairs(grantedSupportEffect.addFlags) do
 					skillFlags[k] = true
 				end
 			end

src/Modules/CalcSetup.lua

@@ -1578,10 +1578,14 @@ function calcs.initEnv(build, mode, override, specEnv)
 										if supportLists[slotName] then
 											-- add socketed supports from other socketGroups
 											for _, otherSocketGroup in ipairs(build.skillsTab.socketGroupList) do
-												if otherSocketGroup.slot and otherSocketGroup.slot == group.slot then
+												if otherSocketGroup.slot and otherSocketGroup.slot == group.slot and not (otherSocketGroup.source and otherSocketGroup.source == group.source) then
 													for _, gem in ipairs(otherSocketGroup.gemList) do
-														if gem.gemData and gem.gemData.grantedEffect and gem.gemData.grantedEffect.support then
-															t_insert(group.displayGemList, gem)
+														if gem.gemData and gem.gemData.grantedEffectList then
+															for _, grantedEffect in ipairs(gem.gemData.grantedEffectList) do
+																if grantedEffect.support then
+																	t_insert(group.displayGemList, gem)
+																end
+															end
 														end
 													end
 												end