Merge pull request #663 from PathfinderHonorManager/develop #152
brian-cummingsmain_pathfinderhonormanager.yml
on: push
Annotations
21 warnings
|
Test:
PathfinderHonorManager.Tests/Service/ClubServiceTests.cs#L261
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Test:
PathfinderHonorManager.Tests/Service/ClubServiceTests.cs#L170
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
SonarQube Analysis:
PathfinderHonorManager/Dto/Incoming/PathfinderHonorDto.cs#L49
Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
|
|
SonarQube Analysis:
PathfinderHonorManager/Dto/Incoming/PathfinderHonorDto.cs#L43
Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
|
|
SonarQube Analysis:
PathfinderHonorManager/Dto/Incoming/PathfinderHonorDto.cs#L32
Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
|
|
SonarQube Analysis:
PathfinderHonorManager/Dto/Incoming/HonorDto.cs#L12
Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
|
|
SonarQube Analysis:
PathfinderHonorManager/Dto/Incoming/PathfinderHonorDto.cs#L23
Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
|
|
SonarQube Analysis:
PathfinderHonorManager/Controllers/HonorsController.cs#L54
Use 'Count' property here instead. (https://rules.sonarsource.com/csharp/RSPEC-2971)
|
|
SonarQube Analysis:
PathfinderHonorManager/Controllers/ClubController.cs#L60
Use 'Count' property here instead. (https://rules.sonarsource.com/csharp/RSPEC-2971)
|
|
SonarQube Analysis:
PathfinderHonorManager/Validators/PathfinderValidator.cs#L12
'AbstractValidator<PathfinderDtoInternal>' implements 'IValidator<PathfinderDtoInternal>' so 'IValidator<PathfinderDtoInternal>' can be removed from the inheritance list. (https://rules.sonarsource.com/csharp/RSPEC-1939)
|
|
SonarQube Analysis:
PathfinderHonorManager/Startup.cs#L192
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
|
|
SonarQube Analysis:
PathfinderHonorManager/Startup.cs#L187
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
|
|
Analyze (csharp):
PathfinderHonorManager.Tests/Service/ClubServiceTests.cs#L261
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Analyze (csharp):
PathfinderHonorManager.Tests/Service/ClubServiceTests.cs#L170
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Analyze (csharp):
PathfinderHonorManager.Tests/Service/ClubServiceTests.cs#L261
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Analyze (csharp):
PathfinderHonorManager.Tests/Service/ClubServiceTests.cs#L170
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
|
|
build:
PathfinderHonorManager.Tests/Service/ClubServiceTests.cs#L261
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build:
PathfinderHonorManager.Tests/Service/ClubServiceTests.cs#L170
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build:
PathfinderHonorManager.Tests/Service/ClubServiceTests.cs#L261
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build:
PathfinderHonorManager.Tests/Service/ClubServiceTests.cs#L170
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
.net-app
Expired
|
7.22 MB |
sha256:d41dadd3d6a68e65b345b3ef357e5e7278b58cb4e51c41af5636f8e58ab96f88
|
|
|
coverage-report
Expired
|
34.8 KB |
sha256:75b215920956f61d9874c7b175f556105cbdfd9440bf1802011086f819b4204b
|
|